Skip to content

Narrow usages of 037DD6 to 'primary-blue'#9008

Merged
brad-decker merged 1 commit intodevelopfrom
curious-blue
Jul 17, 2020
Merged

Narrow usages of 037DD6 to 'primary-blue'#9008
brad-decker merged 1 commit intodevelopfrom
curious-blue

Conversation

@brad-decker
Copy link
Copy Markdown
Contributor

@brad-decker brad-decker commented Jul 15, 2020

replaces the raw hex value, info-blue and curious-blue to primary-blue

Depends on #9007

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [2bb7d2f]
Page Load Metrics (599 ± 38 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint309046199
domContentLoaded3437045987938
load3457055997938
domInteractive3437045987938

@brad-decker brad-decker marked this pull request as ready for review July 17, 2020 16:15
@brad-decker brad-decker requested a review from a team as a code owner July 17, 2020 16:15
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [9907cfb]
Page Load Metrics (610 ± 12 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint297938147
domContentLoaded5736706092512
load5756716102512
domInteractive5736696092512

}

&--info {
fill: $info-blue;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This variable is now unused, so it could be removed as well.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like i missed this line when trying to split my commits. it is removed in the next PR

Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brad-decker brad-decker merged commit 549eb32 into develop Jul 17, 2020
@brad-decker brad-decker deleted the curious-blue branch July 17, 2020 18:11
@brad-decker
Copy link
Copy Markdown
Contributor Author

Update fonts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants