Skip to content

Version v12.4.2 RC#27879

Merged
Gudahtt merged 4 commits intomasterfrom
Version-v12.4.2
Oct 16, 2024
Merged

Version v12.4.2 RC#27879
Gudahtt merged 4 commits intomasterfrom
Version-v12.4.2

Conversation

@metamaskbot
Copy link
Copy Markdown
Collaborator

📦 🚀

@github-actions github-actions bot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Oct 15, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator Author

Builds ready [516af04]
Page Load Metrics (1858 ± 96 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15772479186920498
domContentLoaded15692464183619795
load15782477185820196
domInteractive137239178

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

Take changes from
5e08c06

## **Description**

Hotfixes a problem preventing certain name resolution Snaps from being
triggered due to faulty `IS_FLASK` conditions in `12.4.1`. These
conditions were removed in
#26242. This PR picks
these changes from the previously mentioned PR, without touching the ENS
integration.

The problem in question occurs when trying to trigger name resolution
for a given input. `lookupDomainName` is never called on stable unless
the input looks similar to an ENS name. This prevents resolution of
inputs that don't use TLDs for instance.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27880?quickstart=1)

## **Manual testing steps**

1. Use a build of stable
2. Install https://snaps.metamask.io/snap/npm/social-names-snap/
3. See that you can resolve a Farcaster name using that Snap, e.g.
`fc:frederik`
4. Check that you can also type a valid ENS name
5. Check that you can also type a valid address

---------

Co-authored-by: Hassan Malik <hbmalik88@gmail.com>
@metamaskbot
Copy link
Copy Markdown
Collaborator Author

Builds ready [e4672a8]
Page Load Metrics (1978 ± 114 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24022161676620298
domContentLoaded148125631939238114
load149125751978237114
domInteractive14145392713

FrederikBolding and others added 2 commits October 16, 2024 08:44
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Updates the hotfix RC changelog to mention the PR that was picked into
the RC.
Cherry picks f523617
(#27856) to v12.4.2
RC branch

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.09%. Comparing base (ccb9706) to head (36fe5a8).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #27879   +/-   ##
=======================================
  Coverage   70.08%   70.09%           
=======================================
  Files        1423     1423           
  Lines       49722    49721    -1     
  Branches    13898    13895    -3     
=======================================
+ Hits        34847    34848    +1     
+ Misses      14875    14873    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator Author

Builds ready [36fe5a8]
Page Load Metrics (1973 ± 108 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint29627381815547263
domContentLoaded16742565192719694
load168327631973225108
domInteractive15124362512

@Gudahtt Gudahtt marked this pull request as ready for review October 16, 2024 14:08
@Gudahtt Gudahtt requested review from a team as code owners October 16, 2024 14:08
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Release QA performed by @Montoya

@Gudahtt Gudahtt merged commit 626289d into master Oct 16, 2024
@Gudahtt Gudahtt deleted the Version-v12.4.2 branch October 16, 2024 18:51
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants