Skip to content

chore: Add react-beautiful-dnd to deprecated packages list#27856

Merged
FrederikBolding merged 1 commit intodevelopfrom
fb/deprecated-dep-audit-fix
Oct 15, 2024
Merged

chore: Add react-beautiful-dnd to deprecated packages list#27856
FrederikBolding merged 1 commit intodevelopfrom
fb/deprecated-dep-audit-fix

Conversation

@FrederikBolding
Copy link
Copy Markdown
Member

@FrederikBolding FrederikBolding commented Oct 15, 2024

Description

Adds react-beautiful-dnd to list of deprecated packages that are ignored when using yarn audit. This unblocks develop. The package is currently in use for the network selection drag and drop functionality and cannot be removed.

This PR also removes some packages from the list that were previously ignored, but are no longer in the dependency tree.

Open in GitHub Codespaces

@FrederikBolding FrederikBolding added the team-extension-platform Extension Platform team label Oct 15, 2024
@FrederikBolding FrederikBolding requested a review from a team as a code owner October 15, 2024 09:25
@github-actions github-actions bot added the team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues) label Oct 15, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 15, 2024
@sonarqubecloud
Copy link
Copy Markdown

@FrederikBolding FrederikBolding added this pull request to the merge queue Oct 15, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [d58921d]
Page Load Metrics (2125 ± 149 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint42527531931576276
domContentLoaded167726982022240115
load169027662125311149
domInteractive28127552512
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Merged via the queue into develop with commit f523617 Oct 15, 2024
@FrederikBolding FrederikBolding deleted the fb/deprecated-dep-audit-fix branch October 15, 2024 11:13
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 15, 2024
@gauthierpetetin gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-extension-platform Extension Platform team team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants