fix: Correct conditions for triggering name lookup during send#27880
Merged
danjm merged 5 commits intoVersion-v12.4.2from Oct 16, 2024
Merged
fix: Correct conditions for triggering name lookup during send#27880danjm merged 5 commits intoVersion-v12.4.2from
danjm merged 5 commits intoVersion-v12.4.2from
Conversation
5276217 to
e6e2454
Compare
Mrtenz
reviewed
Oct 15, 2024
Comment on lines
+70
to
+73
| * Determines if a string is a possible ethereum address | ||
| * | ||
| * @param candidate - the input to check | ||
| * @returns true if the input is a 40 char hex string with optional 0x prefix, false otherwise |
Member
There was a problem hiding this comment.
Suggested change
| * Determines if a string is a possible ethereum address | |
| * | |
| * @param candidate - the input to check | |
| * @returns true if the input is a 40 char hex string with optional 0x prefix, false otherwise | |
| * Determine if a string is a possible Ethereum address. | |
| * | |
| * @param candidate - The input to check. | |
| * @returns `true` if the input is a 40-character-long hex string with optional 0x-prefix, `false` otherwise. |
Member
Author
There was a problem hiding this comment.
This is picked directly from develop. I don't think it makes sense to improve it much in master 😄
Mrtenz
previously approved these changes
Oct 15, 2024
Mrtenz
previously approved these changes
Oct 15, 2024
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [0c9f4e8]
Page Load Metrics (1838 ± 89 ms)
|
danjm
approved these changes
Oct 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Take changes from 5e08c06
Description
Hotfixes a problem preventing certain name resolution Snaps from being triggered due to faulty
IS_FLASKconditions in12.4.1. These conditions were removed in #26242. This PR picks these changes from the previously mentioned PR, without touching the ENS integration.The problem in question occurs when trying to trigger name resolution for a given input.
lookupDomainNameis never called on stable unless the input looks similar to an ENS name. This prevents resolution of inputs that don't use TLDs for instance.Manual testing steps
fc:frederik