chore: removing deprecated info colors from codebase#25124
Merged
georgewrmarshall merged 1 commit intodevelopfrom Jun 7, 2024
Merged
chore: removing deprecated info colors from codebase#25124georgewrmarshall merged 1 commit intodevelopfrom
georgewrmarshall merged 1 commit intodevelopfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
georgewrmarshall
commented
Jun 6, 2024
.storybook/3.COLORS.stories.mdx
Outdated
Contributor
Author
beae90c to
52a2df4
Compare
georgewrmarshall
commented
Jun 6, 2024
| successInverse = 'success-inverse', | ||
| successDisabled = 'success-disabled', | ||
| infoDefault = 'info-default', | ||
| infoAlternative = 'info-alternative', |
Contributor
Author
darkwing
approved these changes
Jun 6, 2024
brianacnguyen
approved these changes
Jun 6, 2024
7 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25124 +/- ##
===========================================
- Coverage 65.66% 65.66% -0.00%
===========================================
Files 1359 1359
Lines 54014 54011 -3
Branches 14015 14015
===========================================
- Hits 35464 35461 -3
Misses 18550 18550 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [52a2df4]
Page Load Metrics (48 ± 3 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
georgewrmarshall
added a commit
that referenced
this pull request
Jun 11, 2024
## **Description** This pull request aims to upgrade the extension to [design tokens v4](https://github.com/MetaMask/design-tokens/blob/main/MIGRATION.md#from-version-300-to-400). This upgrade ensures the most up-to-date colors are being used that align with design and primes the extension for the upcoming brand evolution. Included in this PR are third-party network color CSS variables that have been removed from the design tokens package and renamed CSS variables for shadow. This PR is the final update from a series of PRs that replace deprecated CSS colors that have been removed in v4. **Dependency PRs that should be merged before this one:** - #24970 - #24970 - #25125 - #25124 - #25122 - #25011 - #25010 - #25083 - #24971 - #25158 [](https://codespaces.new/MetaMask/metamask-extension/pull/24953?quickstart=1)   ## **Related issues** Fixes: #24916 ## **Manual testing steps** Check all [removed and changed](https://github.com/MetaMask/design-tokens/blob/main/MIGRATION.md#from-version-300-to-400) CSS variables are no longer in the codebase: 1. Pull this branch. 2. Copy [this script](https://gist.github.com/georgewrmarshall/1ca0d7044bfa3c91343cadbf2bd5c828) that checks for all deprecated colors to the root of the extension. 3. Run `node searchDeprecatedTokens.js`. 4. Ensure there are no results. Check shadows and network colors work as expected: 1. Navigate to stories that use primary and error shadows (`ButtonPrimary`, `ButtonSecondary`, `Button` (deprecated)) as well as network colors (`Box` BackgroundColors story). 2. Verify that shadows and network colors work as expected. Run the extension and navigate around to ensure colors work as expected: 1. Pull this branch. 2. Run `yarn start`. 3. Navigate around the extension in light and dark mode to ensure colors work as expected. ## **Screenshots/Recordings** ### **Before** Checking the codebase for any existing deprecated colors returns many results in the `develop` branch. https://github.com/MetaMask/metamask-extension/assets/8112138/8ad23392-a0cc-4be5-8a50-12a126f5b71c ### **After** Checking the codebase for any deprecated removed colors that could break the UI using the provided script, after removing network colors, returns no results. https://github.com/MetaMask/metamask-extension/assets/8112138/3b82862d-5302-466f-bc55-bbb05a924ac0 Checking components that use updated CSS variables and newly added still work as expected https://github.com/MetaMask/metamask-extension/assets/8112138/b70279b9-07f3-4315-abcd-83090ca03eef Checking extension colors are working as expected in light and dark mode. In dark mode primary and error are a shade lighter in v4 https://github.com/MetaMask/metamask-extension/assets/8112138/d748f8cb-f2f2-4bd5-b9f4-f3bb376f22cd ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
This pull request removes the deprecated info colors in preparation for upgrading to design token v4.
Related issues
Fixes: #24968
Manual testing steps
info-alternativeandinfoAlternativeScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist