chore: remove deprecated success colors by georgewrmarshall · Pull Request #25122 · MetaMask/metamask-extension

georgewrmarshall · 2024-06-06T20:55:48Z

Description

This pull request removes the deprecated success colors (success-alternative and success-disabled) in preparation for upgrading to design token v4.

Related issues

Fixes: #24967

Manual testing steps

Go to the storybook build of this PR
Go to all stories that did use the success alternative and success disabled
See color updates are working as expected

Screenshots/Recordings

Before/After screenshots in code comments for easier review

Pre-merge author checklist

I’ve followed MetaMask Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-06-06T20:56:01Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

georgewrmarshall · 2024-06-06T21:00:18Z

.storybook/3.COLORS.stories.mdx

 var(--color-success-alternative) [DEPRECATED]
 var(--color-success-muted)
 var(--color-success-inverse)
-var(--color-success-disabled) [DEPRECATED]


No success-disabled left in the codebase. Removing from color docs

georgewrmarshall · 2024-06-06T21:08:58Z

ui/components/component-library/header-base/header-base.stories.tsx

+            backgroundColor={BackgroundColor.successDefault}
            size={ButtonSize.Sm}
          >
            Unlock


georgewrmarshall · 2024-06-06T21:11:56Z

ui/helpers/constants/design-system.ts

  warningInverse = 'warning-inverse',
  warningDisabled = 'warning-disabled',
  successDefault = 'success-default',
-  successAlternative = 'success-alternative',


No instances of successAlternative remain in the codebase

georgewrmarshall · 2024-06-06T21:12:07Z

ui/helpers/constants/design-system.ts

-  successAlternative = 'success-alternative',
  successMuted = 'success-muted',
  successInverse = 'success-inverse',
-  successDisabled = 'success-disabled',


No instances of successDisabled remain in the codebase

georgewrmarshall · 2024-06-06T21:15:46Z

ui/pages/onboarding-flow/create-password/index.scss

  &__strong {
-    color: var(--color-success-alternative);
+    color: var(--color-success-default);
  }


georgewrmarshall · 2024-06-06T21:25:11Z

ui/components/multichain/pages/page/page.stories.tsx

        Connect
      </Header>
-      <Content backgroundColor={BackgroundColor.successAlternative}>
+      <Content backgroundColor={BackgroundColor.successDefault}>


georgewrmarshall · 2024-06-06T21:25:16Z

ui/components/multichain/pages/page/page.stories.tsx

        Connect
      </Header>
-      <Content background={BackgroundColor.successAlternative}>
+      <Content backgroundColor={BackgroundColor.successDefault}>


georgewrmarshall · 2024-06-06T21:25:21Z

ui/components/multichain/pages/page/page.stories.tsx

        Connect
      </Header>
-      <Content backgroundColor={BackgroundColor.successAlternative}>
+      <Content backgroundColor={BackgroundColor.successDefault}>


georgewrmarshall · 2024-06-06T21:25:27Z

ui/components/multichain/pages/page/page.stories.tsx

        Connect
      </Header>
-      <Content background={BackgroundColor.successAlternative}>
+      <Content backgroundColor={BackgroundColor.successDefault}>


codecov · 2024-06-06T22:11:13Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.65%. Comparing base (a7fbbd3) to head (ca9365e).
Report is 3 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #25122      +/-   ##
===========================================
- Coverage    65.66%   65.65%   -0.00%     
===========================================
  Files         1359     1359              
  Lines        54014    54010       -4     
  Branches     14015    14015              
===========================================
- Hits         35464    35460       -4     
  Misses       18550    18550

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-06-06T22:24:28Z

Builds ready [ca9365e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (47 ± 6 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	69	123	81	12	6
		domContentLoaded	8	42	11	7	3
		load	40	86	47	12	6
		domInteractive	8	42	11	7	3

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: -166 Bytes (-0.00%)

georgewrmarshall added 2 commits June 5, 2024 15:50

chore: removing success alternative colors from codebase

fe2f5f3

chore: removing success-disabled colors

ca5f4ef

georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jun 6, 2024

georgewrmarshall self-assigned this Jun 6, 2024

georgewrmarshall commented Jun 6, 2024

View reviewed changes

georgewrmarshall requested a review from brianacnguyen June 6, 2024 21:16

georgewrmarshall marked this pull request as ready for review June 6, 2024 21:16

georgewrmarshall requested review from a team as code owners June 6, 2024 21:16

chroe: fixing incorrect prop name in story

2f19e6b

georgewrmarshall force-pushed the remove-deprecated-success-colors branch from 8503af9 to 2f19e6b Compare June 6, 2024 21:20

georgewrmarshall commented Jun 6, 2024

View reviewed changes

georgewrmarshall changed the title ~~Remove deprecated success colors~~ chore: remove deprecated success colors Jun 6, 2024

Merge branch 'develop' into remove-deprecated-success-colors

ca9365e

darkwing added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Jun 6, 2024

brianacnguyen approved these changes Jun 6, 2024

View reviewed changes

georgewrmarshall mentioned this pull request Jun 6, 2024

chore: upgrading to design tokens v4 #24953

Merged

7 tasks

darkwing approved these changes Jun 6, 2024

View reviewed changes

georgewrmarshall merged commit 254ac95 into develop Jun 7, 2024

georgewrmarshall deleted the remove-deprecated-success-colors branch June 7, 2024 16:14

github-actions bot locked and limited conversation to collaborators Jun 7, 2024

metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: remove deprecated success colors#25122

chore: remove deprecated success colors#25122
georgewrmarshall merged 4 commits intodevelopfrom
remove-deprecated-success-colors

georgewrmarshall commented Jun 6, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Jun 6, 2024

Uh oh!

georgewrmarshall Jun 6, 2024 •

edited

Loading

Uh oh!

georgewrmarshall Jun 6, 2024 •

edited

Loading

Uh oh!

georgewrmarshall Jun 6, 2024 •

edited

Loading

Uh oh!

georgewrmarshall Jun 6, 2024 •

edited

Loading

Uh oh!

georgewrmarshall Jun 6, 2024

Uh oh!

georgewrmarshall Jun 6, 2024

Uh oh!

georgewrmarshall Jun 6, 2024

Uh oh!

georgewrmarshall Jun 6, 2024

Uh oh!

georgewrmarshall Jun 6, 2024

Uh oh!

codecov bot commented Jun 6, 2024 •

edited

Loading

Uh oh!

metamaskbot commented Jun 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

georgewrmarshall commented Jun 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Jun 6, 2024

Uh oh!

georgewrmarshall Jun 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

georgewrmarshall Jun 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

georgewrmarshall Jun 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

georgewrmarshall Jun 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

georgewrmarshall Jun 6, 2024

Choose a reason for hiding this comment

Uh oh!

georgewrmarshall Jun 6, 2024

Choose a reason for hiding this comment

Uh oh!

georgewrmarshall Jun 6, 2024

Choose a reason for hiding this comment

Uh oh!

georgewrmarshall Jun 6, 2024

Choose a reason for hiding this comment

Uh oh!

georgewrmarshall Jun 6, 2024

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jun 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

metamaskbot commented Jun 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

georgewrmarshall commented Jun 6, 2024 •

edited

Loading

georgewrmarshall Jun 6, 2024 •

edited

Loading

georgewrmarshall Jun 6, 2024 •

edited

Loading

georgewrmarshall Jun 6, 2024 •

edited

Loading

georgewrmarshall Jun 6, 2024 •

edited

Loading

codecov bot commented Jun 6, 2024 •

edited

Loading