-
Notifications
You must be signed in to change notification settings - Fork 5.5k
chore: remove all instances of deprecated success colors #24967
Copy link
Copy link
Closed
Labels
release-12.1.0Issue or pull request that will be included in release 12.1.0Issue or pull request that will be included in release 12.1.0team-design-systemAll issues relating to design system in ExtensionAll issues relating to design system in Extension
Description
What is this about?
In preparation for upgrading the @metamask/design-tokens library to version 4, we need to remove all instances of the deprecated --color-success-alternative and --color-success-disabled. This color has been removed in v4 and its presence will cause breakages in the application.
Design tokens migration v3 => v4 documentation
Scenario
No response
Design
No response
Technical Details
- Search the codebase for all instances of
--color-success-alternativeand--color-success-disabled. - Replace
--color-success-alternativeand--color-success-disabledwith an appropriate alternative from the updated design tokens. - Ensure all components using this color are updated accordingly and tested for visual consistency.
- Update any documentation or style guides referencing
--color-success-alternativeand--color-success-disabled.
Threat Modeling Framework
No response
Acceptance Criteria
- All instances of
--color-success-alternativeand--color-success-disabledare removed from the codebase. - The application functions correctly without any references to
--color-success-alternativeand--color-success-disabled. - Visual appearance of components previously using
--color-success-alternativeand--color-success-disabledis consistent with design specifications. - No breaking changes introduced in the application due to this update.
Stakeholder review needed before the work gets merged
- Engineering (needed in most cases)
- Design
- Product
- QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- Security
- Legal
- Marketing
- Management (please specify)
- Other (please specify)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
release-12.1.0Issue or pull request that will be included in release 12.1.0Issue or pull request that will be included in release 12.1.0team-design-systemAll issues relating to design system in ExtensionAll issues relating to design system in Extension