chore: removing deprecated button color css variables#25125
Merged
georgewrmarshall merged 2 commits intodevelopfrom Jun 7, 2024
Merged
chore: removing deprecated button color css variables#25125georgewrmarshall merged 2 commits intodevelopfrom
georgewrmarshall merged 2 commits intodevelopfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
georgewrmarshall
commented
Jun 6, 2024
georgewrmarshall
commented
Jun 6, 2024
georgewrmarshall
commented
Jun 6, 2024
georgewrmarshall
commented
Jun 6, 2024
georgewrmarshall
commented
Jun 6, 2024
Comment on lines
+4
to
+6
| box-shadow: | ||
| var(--shadow-size-sm) | ||
| var(--color-primary-shadow); |
Contributor
Author
There was a problem hiding this comment.
Searching --component-button-primary-shadow returns no results
georgewrmarshall
commented
Jun 6, 2024
Comment on lines
+18
to
+20
| box-shadow: | ||
| var(--shadow-size-sm) | ||
| var(--color-error-shadow); |
Contributor
Author
There was a problem hiding this comment.
Searching --component-button-danger-shadow returns no results
georgewrmarshall
commented
Jun 6, 2024
| var(--color-error-shadow); | ||
| } | ||
|
|
||
| &:active { |
Contributor
Author
There was a problem hiding this comment.
Shadows for the ButtonPrimary component work as expected
Before
before.primary720.mov
After
after.primary720.mov
georgewrmarshall
commented
Jun 6, 2024
| box-shadow: | ||
| var(--shadow-size-sm) | ||
| var(--color-error-shadow); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Before
Shadows for the ButtonSecondary component work as expected
Before
before.secondary720.mov
After
after.secondary.mov
georgewrmarshall
commented
Jun 6, 2024
| boxShadow: 'var(--shadow-size-sm) var(--color-error-shadow)', | ||
| backgroundColor: 'var(--color-error-default)', | ||
| color: 'var(--color-error-inverse)', | ||
| }} |
Contributor
Author
There was a problem hiding this comment.
Updating shadow docs: there will be a future update where we change:
--color-error-shadowto--color-shadow-error--color-primary-shadowto--color-shadow-primary
But that will happen in the PR that upgrades to design tokens v4.
Before
before.shadows720.mov
After
after.shadows720.mov
7 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25125 +/- ##
========================================
Coverage 65.66% 65.66%
========================================
Files 1359 1359
Lines 54014 54014
Branches 14015 14015
========================================
Hits 35464 35464
Misses 18550 18550 ☔ View full report in Codecov by Sentry. |
| height: 100, | ||
| backgroundColor: 'var(--color-primary-default)', | ||
| boxShadow: 'var(--shadow-size-lg) var(--color-primary-shadow', | ||
| boxShadow: 'var(--shadow-size-lg) var(--color-primary-shadow)', |
brianacnguyen
approved these changes
Jun 6, 2024
Collaborator
Builds ready [ce1b375]
Page Load Metrics (134 ± 167 ms)
Bundle size diffs
|
darkwing
approved these changes
Jun 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request removes the deprecated button component colors in preparation for upgrading to design token v4.
Related issues
Fixes: #24965
Manual testing steps
yarn storybookButtonPrimaryandButtonSecondaryScreenshots/Recordings
Before/After scereenshots/recordings in code comments for easier review and context
Pre-merge author checklist
Pre-merge reviewer checklist