Skip to content

Version v11.16.3#24917

Merged
danjm merged 6 commits intomasterfrom
Version-v11.16.3
May 31, 2024
Merged

Version v11.16.3#24917
danjm merged 6 commits intomasterfrom
Version-v11.16.3

Conversation

@danjm
Copy link
Copy Markdown
Contributor

@danjm danjm commented May 30, 2024

No description provided.

@danjm danjm changed the base branch from develop to master May 30, 2024 19:23
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added INVALID-PR-TEMPLATE PR's body doesn't match template release-11.16.3 Issue or pull request that will be included in release 11.16.3 labels May 30, 2024
…24919)

## **Description**

Updates the privacy policy date so that it shows up on June 18

[![Open in GitHub

Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24902?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page... 2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24919?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Co-authored-by: Jony Bursztyn <jony.bursztyn@consensys.net>
…ng cap to allow other accounts to transfer tokens @no-mmi` (#24734)

## **Description**
This PR fixes the flaky test `Increase Token Allowance increases token
spending cap to allow other accounts to transfer tokens @no-mmi).`
The problem with this flaky test is that we are changing the allowance
amount (from 0 to 1) and we confirm the transaction before the gas has
been updated. This makes that the increase token allowance transaction
fails, and the subsequent transaction with the Account 2 cannot be
performed as it doesn't have the allowance for doing a transfer from
action. So the dialog window cannot be found, as the popup is never
triggered (see dapp error).

The fix is to simply await for the expected gas for the
increaseAllowance with amount 1.

This can be clearly seen when you check the tx history from Account 1:

- Here is a successful increaseAllowance with amount 1, and the total
gas is `31000` -- correct

![Screenshot from 2024-05-23
09-41-59](https://github.com/MetaMask/metamask-extension/assets/54408225/727cc834-de9c-452a-81a6-e8fb40e2f75d)

- Here is a failed increaseAllowance with amount 1, and the total gas
limit is `26776` -- incorrect (this value corresponds to the
increaseAllowance with amount 0)

![Screenshot from 2024-05-23
09-41-53](https://github.com/MetaMask/metamask-extension/assets/54408225/e23fdc1b-0c53-48e5-9368-a17a6bdc7fb4)

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24734?quickstart=1)

## **Related issues**

Fixes: one of this cases, but not all of them, as the rest of testcases
need to be looked separately
#24603

## **Manual testing steps**

1. Run this test locally multiple times
2. Check ci jobs `yarn test:e2e:single
test/e2e/tests/tokens/increase-token-allowance.spec.js --browser=firefox
--leave-running --retryUntilFailure --retries=10`

## **Screenshots/Recordings**


https://github.com/MetaMask/metamask-extension/assets/54408225/c0d32e57-6ace-4c59-a667-dcafc3421a7c



## **Pre-merge author checklist**

- [X] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@danjm danjm force-pushed the Version-v11.16.3 branch from ca8da94 to 8f7ef25 Compare May 31, 2024 16:20
Cherry picks #24343 (06127ad) to v11.16.3

Co-authored-by: Sébastien Van Eyck <sebastien.vaneyck@consensys.net>
@danjm danjm marked this pull request as ready for review May 31, 2024 16:59
@danjm danjm requested review from a team as code owners May 31, 2024 16:59
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [1811403]
Page Load Metrics (1068 ± 532 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint682171204622
domContentLoaded11432584
load53281410681107532
domInteractive11432584

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [598158a]
Page Load Metrics (841 ± 516 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint711931012914
domContentLoaded146828147
load5932588411074516
domInteractive146828147

@danjm danjm merged commit 9fe5a06 into master May 31, 2024
@danjm danjm deleted the Version-v11.16.3 branch May 31, 2024 19:25
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-11.16.3 Issue or pull request that will be included in release 11.16.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants