Skip to content

fix(cherry-pick): move new privacy policy date to June 18 (#24902)#24919

Merged
danjm merged 1 commit intoVersion-v11.16.3from
Version-v11.16.3-cherry-pick-privacy
May 31, 2024
Merged

fix(cherry-pick): move new privacy policy date to June 18 (#24902)#24919
danjm merged 1 commit intoVersion-v11.16.3from
Version-v11.16.3-cherry-pick-privacy

Conversation

@darkwing
Copy link
Copy Markdown
Contributor

@darkwing darkwing commented May 30, 2024

Description

Updates the privacy policy date so that it shows up on June 18

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page... 2.

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Updates the privacy policy date so that it shows up on June 18

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24902?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@darkwing darkwing requested a review from a team as a code owner May 30, 2024 20:01
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing darkwing changed the title feat: move new privacy policy date to June 18 (#24902) fix(cherry-pick): move new privacy policy date to June 18 (#24902) May 30, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.46%. Comparing base (a7f8bc7) to head (cdb2cfc).

Additional details and impacted files
@@                Coverage Diff                @@
##           Version-v11.16.3   #24919   +/-   ##
=================================================
  Coverage             67.46%   67.46%           
=================================================
  Files                  1265     1265           
  Lines                 49403    49403           
  Branches              12853    12853           
=================================================
  Hits                  33329    33329           
  Misses                16074    16074           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [cdb2cfc]
Page Load Metrics (741 ± 481 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint592101123718
domContentLoaded991322210
load4824127411002481
domInteractive991322210

@danjm danjm merged commit 97b4bc7 into Version-v11.16.3 May 31, 2024
@danjm danjm deleted the Version-v11.16.3-cherry-pick-privacy branch May 31, 2024 11:47
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2024
@metamaskbot metamaskbot added the release-11.16.3 Issue or pull request that will be included in release 11.16.3 label May 31, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-11.16.3 on PR, as PR was cherry-picked in branch 11.16.3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-11.16.3 Issue or pull request that will be included in release 11.16.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants