Skip to content

feat: move new privacy policy date to June 18#24902

Merged
darkwing merged 1 commit intodevelopfrom
jb-update-privacy-policy-date
May 30, 2024
Merged

feat: move new privacy policy date to June 18#24902
darkwing merged 1 commit intodevelopfrom
jb-update-privacy-policy-date

Conversation

@jonybur
Copy link
Copy Markdown
Contributor

@jonybur jonybur commented May 30, 2024 •
edited by github-actions bot
Loading

Description

Updates the privacy policy date so that it shows up on June 18

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jonybur jonybur requested a review from a team as a code owner May 30, 2024 13:01
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 30, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jonybur jonybur added the team-core-extension-ux Core Extension UX team label May 30, 2024
mirceanis
mirceanis approved these changes May 30, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented May 30, 2024

Builds ready [83d7628]
Page Load Metrics (296 ± 315 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint63165932713
domContentLoaded94719147
load552336296656315
domInteractive94719147
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.73%. Comparing base (0bcb4d3) to head (83d7628).
Report is 2 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #24902   +/-   ##
========================================
  Coverage    65.73%   65.73%           
========================================
  Files         1363     1363           
  Lines        54270    54270           
  Branches     14108    14108           
========================================
  Hits         35674    35674           
  Misses       18596    18596

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darkwing darkwing merged commit 50fdee3 into develop May 30, 2024
@darkwing darkwing deleted the jb-update-privacy-policy-date branch May 30, 2024 19:21
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2024
@metamaskbot metamaskbot added release-11.18.0 release-11.16.3 Issue or pull request that will be included in release 11.16.3 and removed release-11.18.0 labels May 30, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented May 31, 2024

Missing release label release-11.16.3 on PR. Adding release label release-11.16.3 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.16.3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@darkwing darkwing darkwing approved these changes

@mirceanis mirceanis mirceanis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-11.16.3 Issue or pull request that will be included in release 11.16.3 team-core-extension-ux Core Extension UX team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jonybur @metamaskbot @darkwing @mirceanis