Skip to content

feat(1753): update trezor logo#24343

Merged
legobeat merged 6 commits intodevelopfrom
feat/1753
May 28, 2024
Merged

feat(1753): update trezor logo#24343
legobeat merged 6 commits intodevelopfrom
feat/1753

Conversation

@Akaryatrh
Copy link
Copy Markdown
Contributor

@Akaryatrh Akaryatrh commented May 2, 2024 •
edited
Loading

Description

Update Trezor logo to its latest version.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/mobile-planning/issues/1753

Manual testing steps

  1. Open account dropdown and click on "add account or hardware wallet" button.
  2. Click on add hardware wallet button
  3. Check that Trezor logo is updated on hardware wallet selection page

Screenshots/Recordings

Before

Capture d’écran 2024-05-02 à 12 39 50

After

Capture d’écran 2024-05-02 à 12 38 17

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Akaryatrh Akaryatrh added the team-hardware-wallets-deprecated DEPRECATED: please use "team-accounts-framework" instead label May 2, 2024
@Akaryatrh Akaryatrh requested a review from a team as a code owner May 2, 2024 10:58
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

legobeat
legobeat suggested changes May 2, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@legobeat legobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs update of unit test.

https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/78625/workflows/5ee7663a-2229-4b75-96d4-cf0e84450bd6/jobs/2743117

@Akaryatrh Akaryatrh requested a review from legobeat May 2, 2024 11:51
@Akaryatrh Akaryatrh self-assigned this May 6, 2024
@legobeat legobeat requested review from a team and removed request for legobeat May 6, 2024 10:24
@legobeat

This comment was marked as off-topic.

Sign in to view
@legobeat legobeat requested a review from a team May 6, 2024 10:28
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented May 21, 2024

Builds ready [83213d7]
Page Load Metrics (1152 ± 579 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint621731023115
domContentLoaded96019136
load48279311521205579
domInteractive96019136
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -741 Bytes (-0.01%)
  • common: 0 Bytes (0.00%)

@legobeat legobeat merged commit 666a87b into develop May 28, 2024
@legobeat legobeat deleted the feat/1753 branch May 28, 2024 11:21
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2024
@metamaskbot metamaskbot added release-11.18.0 release-11.16.3 Issue or pull request that will be included in release 11.16.3 and removed release-11.18.0 labels May 28, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented May 31, 2024

Missing release label release-11.16.3 on PR. Adding release label release-11.16.3 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.16.3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@salimtb salimtb salimtb approved these changes

+1 more reviewer

@legobeat legobeat legobeat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Akaryatrh Akaryatrh

Labels

release-11.16.3 Issue or pull request that will be included in release 11.16.3 team-hardware-wallets-deprecated DEPRECATED: please use "team-accounts-framework" instead

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Akaryatrh @legobeat @metamaskbot @salimtb @dawnseeker8