Skip to content

Revert stake button and announcement#22669

Merged
chloeYue merged 5 commits intodevelopfrom
revert-stake-button-and-announcement
Jan 31, 2024
Merged

Revert stake button and announcement#22669
chloeYue merged 5 commits intodevelopfrom
revert-stake-button-and-announcement

Conversation

@martahj
Copy link
Copy Markdown
Contributor

@martahj martahj commented Jan 25, 2024

Description

Reverts the commits related to staking. The relevant PRs being reverted are:

Related issues

No issue for the revert exists.

Manual testing steps

  1. Install the build and open MM
  2. Look at the "What's new" announcements
  3. Confirm that the one for staking has been removed but the following one (Blockaid) remains
  4. Go to token listing
  5. Confirm that the "Stake" button no longer appears by the mainnet ETH token symbol

Screenshots/Recordings

Before

Screenshot 2024-01-25 at 3 52 36 PM

After

Screenshot 2024-01-25 at 3 58 38 PM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@martahj martahj requested a review from a team as a code owner January 25, 2024 23:52
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 25, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@martahj martahj force-pushed the revert-stake-button-and-announcement branch from 58e9f5d to a7d63db Compare January 26, 2024 03:47
@martahj martahj force-pushed the revert-stake-button-and-announcement branch from a7d63db to a2ad6d1 Compare January 26, 2024 04:28
@danjm danjm added release-11.9.0 Issue or pull request that will be included in release 11.9.0 release-blocker This bug is blocking the next release labels Jan 26, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 30, 2024

Builds ready [6dd438a]
Page Load Metrics (795 ± 16 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint10113211294
domContentLoaded16211821
load7568967953416
domInteractive16211821
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -1.48 KiB (-0.02%)
  • common: -1.11 KiB (-0.02%)

@chloeYue chloeYue merged commit 7c15b31 into develop Jan 31, 2024
@chloeYue chloeYue deleted the revert-stake-button-and-announcement branch January 31, 2024 13:03
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2024
@metamaskbot metamaskbot added the release-11.11.0 Issue or pull request that will be included in release 11.11.0 label Jan 31, 2024
@metamaskbot metamaskbot removed the release-11.11.0 Issue or pull request that will be included in release 11.11.0 label Feb 17, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 17, 2024

More than one release label on PR. Keeping the lowest one (release-11.9.0) on PR and removing other release labels (release-11.11.0).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@darkwing darkwing darkwing approved these changes

@brad-decker brad-decker brad-decker approved these changes

@danjm danjm danjm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-11.9.0 Issue or pull request that will be included in release 11.9.0 release-blocker This bug is blocking the next release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@martahj @metamaskbot @darkwing @brad-decker @danjm @chloeYue