Skip to content

chore: disable link to portfolio staking in MMI#22511

Merged
Gudahtt merged 3 commits intodevelopfrom
MMI-4426-fix-stake-test
Jan 12, 2024
Merged

chore: disable link to portfolio staking in MMI#22511
Gudahtt merged 3 commits intodevelopfrom
MMI-4426-fix-stake-test

Conversation

@shane-t
Copy link
Copy Markdown
Member

@shane-t shane-t commented Jan 12, 2024 •
edited
Loading

Description

MMI and MetaMask both have staking features that link to different places. This hides the MetaMask staking feature in MMI.

Related issues

Fixes:

Jira issue https://consensyssoftware.atlassian.net/jira/software/projects/MMI/boards/315?selectedIssue=MMI-4426

Manual testing steps

  1. Create an MMI build
  2. Open the home screen on mainnet
  3. Observe that there is no link to stake ether from the assets list.

Screenshots/Recordings

Before

image

After

image ## **Pre-merge author checklist**
  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@shane-t shane-t force-pushed the MMI-4426-fix-stake-test branch from 153fc62 to d93820d Compare January 12, 2024 12:31
@shane-t shane-t added the mmi DEPRECATED: The product got sunset label Jan 12, 2024
@shane-t shane-t marked this pull request as ready for review January 12, 2024 13:50
@shane-t shane-t requested a review from a team as a code owner January 12, 2024 13:50
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (50c0f34) 68.06% compared to head (5366433) 68.06%.
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #22511   +/-   ##
========================================
  Coverage    68.06%   68.06%           
========================================
  Files         1083     1083           
  Lines        42520    42522    +2     
  Branches     11367    11367           
========================================
+ Hits         28937    28940    +3     
+ Misses       13583    13582    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 12, 2024

Builds ready [5366433]
Page Load Metrics (1282 ± 137 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint882791616029
domContentLoaded9192586632
load81217211282285137
domInteractive9192586632
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 10 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Gudahtt
Gudahtt approved these changes Jan 12, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit a6bffb1 into develop Jan 12, 2024
@Gudahtt Gudahtt deleted the MMI-4426-fix-stake-test branch January 12, 2024 17:41
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2024
@metamaskbot metamaskbot added the release-11.9.0 Issue or pull request that will be included in release 11.9.0 label Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@DDDDDanica DDDDDanica DDDDDanica approved these changes

+1 more reviewer

@darkwing darkwing darkwing approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

mmi DEPRECATED: The product got sunset release-11.9.0 Issue or pull request that will be included in release 11.9.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shane-t @metamaskbot @darkwing @Gudahtt @DDDDDanica