Add Staking entrypoint for Mainnet on Token List Item#22347
Merged
Add Staking entrypoint for Mainnet on Token List Item#22347
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
6a2f015 to
2a9e22b
Compare
1706088 to
cdbe89f
Compare
Collaborator
Builds ready [cdbe89f]
Page Load Metrics (1259 ± 138 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #22347 +/- ##
===========================================
+ Coverage 68.15% 68.17% +0.01%
===========================================
Files 1081 1081
Lines 42295 42312 +17
Branches 11302 11309 +7
===========================================
+ Hits 28826 28842 +16
- Misses 13469 13470 +1 ☔ View full report in Codecov by Sentry. |
NidhiKJha
reviewed
Jan 5, 2024
cdbe89f to
9156545
Compare
NidhiKJha
reviewed
Jan 8, 2024
DDDDDanica
reviewed
Jan 8, 2024
ui/components/multichain/token-list-item/token-list-item.test.js
Outdated
Show resolved
Hide resolved
darkwing
suggested changes
Jan 8, 2024
Contributor
darkwing
left a comment
There was a problem hiding this comment.
Actually, a quick accessibility check shows the "Stake" link isn't keyboard-accessible. Could we make that possible?
b41c786 to
bb717c1
Compare
Co-authored-by: Danica Shen <zhaodanica@gmail.com>
DDDDDanica
approved these changes
Jan 9, 2024
darkwing
approved these changes
Jan 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Staking team would like to add an entry point for users to get to Portfolio Staking from the extension.
This PR adds a prop to TokenListItem, which would add the staking button for a given token when the flag is true.
The scope of the story is limited to ETH mainnet, with the expectation that there will be other tokens to stake in the future.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1781
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist