Skip to content

Adds "What's New" popup for staking#22291

Merged
vthomas13 merged 2 commits intodevelopfrom
martahj/add-stake-whats-new
Jan 10, 2024
Merged

Adds "What's New" popup for staking#22291
vthomas13 merged 2 commits intodevelopfrom
martahj/add-stake-whats-new

Conversation

@martahj
Copy link
Copy Markdown
Contributor

@martahj martahj commented Dec 14, 2023 •
edited
Loading

Description

The Staking team is hoping to add a "What's new" announcement corresponding with the addition of the "Stake" CTA. This PR creates that announcement

This change should please be released at the same time as https://github.com/MetaMask/MetaMask-planning/issues/1781

Manual testing steps

  1. Install MM build with this change
  2. The Stake announcement should appear, either last on the "What's New" list (after Ledger Live) if you haven't seen previous announcements or as the only item in "What's New" if you have
  3. CTA should not click through to anything (just close the notification)

Screenshots/Recordings

Before

No staking announcement

After

Screenshot 2023-12-18 at 11 20 32 AM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable [not applicable]
  • I’ve documented my code using JSDoc format if applicable [not applicable]
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors. [I think so but please feel free to update the labels or request that I do if not]
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@martahj martahj requested a review from a team as a code owner December 14, 2023 17:15
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 14, 2023 •
edited
Loading

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Dec 14, 2023
@martahj
Copy link
Copy Markdown
Contributor Author

martahj commented Dec 14, 2023

I have read the CLA Document and I hereby sign the CLA

@martahj martahj force-pushed the martahj/add-stake-whats-new branch 2 times, most recently from 1743574 to 3890229 Compare December 14, 2023 17:26
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 14, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (0881d66) 67.88% compared to head (47c601c) 67.88%.
Report is 11 commits behind head on develop.

Files Patch % Lines
.../components/app/whats-new-popup/whats-new-popup.js 0.00% 2 Missing ⚠️
shared/notifications/index.js 66.67% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #22291      +/-   ##
===========================================
- Coverage    67.88%   67.88%   -0.01%     
===========================================
  Files         1068     1068              
  Lines        41309    41315       +6     
  Branches     11090    11093       +3     
===========================================
+ Hits         28042    28044       +2     
- Misses       13267    13271       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Dec 15, 2023

Builds ready [3890229]
Page Load Metrics (1176 ± 107 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint81174100189
domContentLoaded9321452
load76019611176222107
domInteractive8321452
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 189 Bytes (0.00%)
  • common: 1.07 KiB (0.02%)

@martahj martahj force-pushed the martahj/add-stake-whats-new branch from 3890229 to 47c601c Compare December 18, 2023 17:21
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Dec 18, 2023

Builds ready [47c601c]
Page Load Metrics (1431 ± 120 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint902931816230
domContentLoaded10208636833
load99317171431251120
domInteractive10208636833
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 189 Bytes (0.00%)
  • common: 1.07 KiB (0.02%)

@metamaskbot metamaskbot added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Dec 19, 2023
@kevinghim
Copy link
Copy Markdown
Contributor

kevinghim commented Jan 10, 2024

@vthomas13 would you be able to merge?

@vthomas13 vthomas13 merged commit 7aa328a into develop Jan 10, 2024
@vthomas13 vthomas13 deleted the martahj/add-stake-whats-new branch January 10, 2024 15:26
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 10, 2024
@metamaskbot metamaskbot added the release-11.9.0 Issue or pull request that will be included in release 11.9.0 label Jan 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@HowardBraham HowardBraham HowardBraham approved these changes

+1 more reviewer

@vthomas13 vthomas13 vthomas13 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-11.9.0 Issue or pull request that will be included in release 11.9.0 team-portfolio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@martahj @metamaskbot @kevinghim @HowardBraham @vthomas13