Conversation
Gudahtt
approved these changes
Feb 19, 2025
Member
Gudahtt
left a comment
There was a problem hiding this comment.
Note that we could still alias the imports, so we're not beholden to package authors completely here.
But still, loosening this seems harmless to me, LGTM
…ats for import names
d6b10ac to
0fa8bf3
Compare
Member
Author
True, but in the case of class imports for example, we'd want to use |
7 tasks
Merged
7 tasks
7 tasks
Gudahtt
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Jul 3, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Note: This PR is an update version from #32021 due to loosened eslint rules. Discussion can be found #32021 (comment). This PR addresses TypeScript ESLint error `@typescript-eslint/naming-convention` across the repository following the planned upgrade to `@metamask/eslint-config` v14.x.0(release notes [here](https://github.com/MetaMask/eslint-config/releases?page=1)). For `@typescript-eslint/naming-convention` violations: - Use latest `@metamask/eslint-config` rule from MetaMask/eslint-config#388 - Added eslint-disable directives where proper typing would require significant refactoring - Each disable directive includes a TODO comment pointing to the tracking issue #31860 This approach follows our strategy for handling ESLint upgrades. The comprehensive fixes for these typing issues will be addressed in dedicated PRs to avoid blocking development. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/32106?quickstart=1) ## **Related issues** Fixes: #23528 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> Co-authored-by: Mark Stacey <mark.stacey@consensys.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bump to a more recent version of the TypeScript ESLint plugin added support for specifying naming conventions for import names (
import name from 'package';). We didn't add a case for this, so the default format ofcamelCaseapplied, meaning that this is not allowed:I've updated the rule to allow
camelCase,PascalCase,snake_case, andUPPER_CASE, since the names of imports can depend on the (3rd party) package, and it feels unnecessary to enforce more strict formats in this case.