chore(23528): add TODO for linting `@typescript-eslint/naming-convention` by DDDDDanica · Pull Request #32021 · MetaMask/metamask-extension

DDDDDanica · 2025-04-15T21:48:08Z

Description

This PR addresses TypeScript ESLint error @typescript-eslint/naming-convention across the repository following the planned upgrade to @metamask/eslint-config v12.0.0(release notes here). For @typescript-eslint/naming-convention violations:

Added eslint-disable directives where proper typing would require significant refactoring
Each disable directive includes a TODO comment pointing to the tracking issue [Typescript-eslint] Fix @typescript-eslint/naming-convention violations #31860

This approach follows our strategy for handling ESLint upgrades. The comprehensive fixes for these typing issues will be addressed in dedicated PRs to avoid blocking development.

Related issues

Fixes: #23528

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-04-15T21:48:55Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-04-15T21:50:29Z

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations

app/scripts/controller-init/confirmations/ppom-controller-init.test.ts
app/scripts/controller-init/confirmations/ppom-controller-init.ts
app/scripts/controller-init/confirmations/transaction-controller-init.test.ts
app/scripts/controller-init/confirmations/transaction-controller-init.ts

🪪 @MetaMask/identity

app/scripts/controller-init/identity/user-storage-controller-init.ts

🔄 @MetaMask/swaps-engineers

app/scripts/controllers/bridge-status/bridge-status-controller.test.ts
app/scripts/controllers/bridge-status/types.ts
app/scripts/controllers/swaps/index.ts
app/scripts/controllers/swaps/swaps.test.ts
app/scripts/controllers/swaps/swaps.types.ts
app/scripts/lib/bridge-status/metrics.ts

metamaskbot · 2025-04-15T22:49:02Z

Builds ready [de55992]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1207 ± 62 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1207	1099	1411	62	1243	1331
			load	1044	920	1218	56	1078	1157
			domContentLoaded	1039	915	1211	56	1072	1151
			domInteractive	17	13	60	6	16	28
			firstPaint	665	77	1165	417	1051	1106
			backgroundConnect	7	4	18	2	7	12
			firstReactRender	22	15	128	13	21	40
			getState	12	5	35	7	17	29
			initialActions	0	0	1	0	0	1
			loadScripts	800	667	973	53	828	895
			setupStore	7	5	18	2	8	11
	Webpack	Home	uiStartup	2038	1665	2434	179	2173	2286
			load	1556	1223	1838	137	1685	1740
			domContentLoaded	1549	1215	1821	136	1678	1729
			domInteractive	15	11	54	10	13	44
			firstPaint	175	68	514	63	213	281
			backgroundConnect	32	10	450	59	28	60
			firstReactRender	205	53	398	122	333	360
			getState	11	3	38	6	12	23
			initialActions	3	1	8	1	3	5
			loadScripts	1545	1213	1798	136	1675	1727
			setupStore	20	7	298	37	18	30
Firefox	Browserify	Home	uiStartup	1328	1151	1695	114	1381	1575
			load	1185	1024	1564	119	1244	1436
			domContentLoaded	1185	1024	1563	119	1243	1436
			domInteractive	97	35	172	27	106	166
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	19	12	49	6	20	32
			firstReactRender	22	19	33	3	23	28
			getState	7	4	37	3	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1167	991	1545	119	1227	1418
			setupStore	6	4	34	3	6	7
	Webpack	Home	uiStartup	1487	1329	1892	107	1555	1708
			load	1274	1135	1596	98	1326	1483
			domContentLoaded	1274	1134	1596	98	1326	1483
			domInteractive	79	54	147	21	84	129
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	14	56	7	23	40
			firstReactRender	34	28	59	5	36	45
			getState	10	4	64	9	9	29
			initialActions	0	0	1	0	1	1
			loadScripts	1255	1123	1577	98	1306	1467
			setupStore	8	5	43	5	8	14

Bundle size diffs

background: 0 Bytes (0%)
ui: 0 Bytes (0%)
common: 0 Bytes (0%)

metamaskbot · 2025-04-16T11:33:05Z

Builds ready [2ee0243]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1206 ± 60 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1206	1101	1395	60	1240	1325
			load	1042	948	1191	54	1075	1154
			domContentLoaded	1036	944	1181	54	1067	1145
			domInteractive	17	13	62	8	16	31
			firstPaint	750	88	1190	396	1058	1130
			backgroundConnect	7	4	15	2	8	10
			firstReactRender	20	15	42	4	21	29
			getState	13	5	33	8	19	29
			initialActions	0	0	1	0	0	0
			loadScripts	798	715	942	51	827	906
			setupStore	8	4	27	3	9	12
	Webpack	Home	uiStartup	2168	1573	2524	164	2301	2389
			load	1688	1234	2073	126	1779	1846
			domContentLoaded	1681	1229	2068	125	1768	1836
			domInteractive	17	11	57	11	14	49
			firstPaint	175	68	574	79	213	292
			backgroundConnect	31	9	273	40	33	55
			firstReactRender	209	55	400	124	330	368
			getState	14	3	158	17	16	36
			initialActions	3	1	7	1	4	5
			loadScripts	1676	1227	2045	125	1763	1834
			setupStore	18	6	182	19	20	35
Firefox	Browserify	Home	uiStartup	1357	1192	1717	104	1418	1565
			load	1212	1028	1595	112	1271	1401
			domContentLoaded	1212	1028	1595	112	1270	1400
			domInteractive	109	38	286	41	124	202
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	19	12	83	10	19	39
			firstReactRender	22	19	32	3	22	27
			getState	7	4	12	1	8	9
			initialActions	0	0	1	0	0	1
			loadScripts	1194	1010	1581	113	1254	1383
			setupStore	6	4	35	3	6	7
	Webpack	Home	uiStartup	1499	1330	1902	120	1555	1772
			load	1278	1140	1650	107	1317	1500
			domContentLoaded	1278	1140	1650	107	1316	1499
			domInteractive	76	33	153	20	81	120
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	13	269	27	24	42
			firstReactRender	36	28	62	6	40	47
			getState	9	4	30	5	9	23
			initialActions	1	0	2	1	1	1
			loadScripts	1256	1123	1633	103	1301	1462
			setupStore	9	5	45	7	8	30

Bundle size diffs

background: 0 Bytes (0%)
ui: 0 Bytes (0%)
common: 0 Bytes (0%)

metamaskbot · 2025-04-16T13:45:17Z

Builds ready [dd4e069]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1203 ± 57 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1203	1107	1377	57	1239	1306
			load	1039	929	1197	55	1073	1147
			domContentLoaded	1033	895	1186	55	1067	1130
			domInteractive	18	13	61	9	17	35
			firstPaint	741	76	1194	404	1062	1119
			backgroundConnect	7	4	27	3	7	12
			firstReactRender	21	15	150	14	21	33
			getState	13	5	117	13	19	26
			initialActions	0	0	1	0	0	1
			loadScripts	795	662	946	53	830	900
			setupStore	8	4	41	4	8	13
	Webpack	Home	uiStartup	2061	1669	2594	176	2168	2289
			load	1590	1319	2000	136	1704	1777
			domContentLoaded	1584	1316	1991	134	1700	1770
			domInteractive	16	11	58	10	13	47
			firstPaint	181	67	468	70	233	312
			backgroundConnect	24	9	85	13	25	52
			firstReactRender	199	54	388	116	327	353
			getState	11	4	38	5	13	21
			initialActions	3	1	6	1	3	5
			loadScripts	1579	1314	1967	134	1699	1767
			setupStore	23	6	293	41	20	35
Firefox	Browserify	Home	uiStartup	1351	1139	1778	115	1408	1608
			load	1202	1008	1631	119	1282	1436
			domContentLoaded	1201	1007	1631	119	1282	1436
			domInteractive	104	38	209	31	123	171
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	12	108	12	20	28
			firstReactRender	23	19	56	6	24	31
			getState	7	4	25	3	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	1182	994	1611	121	1267	1423
			setupStore	6	4	49	6	6	8
	Webpack	Home	uiStartup	1553	1370	2129	146	1637	1878
			load	1324	1167	1874	126	1401	1614
			domContentLoaded	1323	1167	1874	126	1400	1614
			domInteractive	85	38	303	36	88	143
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	15	42	5	22	34
			firstReactRender	35	29	50	4	37	46
			getState	8	4	46	6	8	20
			initialActions	1	0	2	1	1	1
			loadScripts	1305	1151	1862	126	1382	1598
			setupStore	12	5	300	30	9	22

Bundle size diffs

background: 0 Bytes (0%)
ui: 0 Bytes (0%)
common: 0 Bytes (0%)

metamaskbot · 2025-04-16T17:29:21Z

Builds ready [dfb691f]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1221 ± 74 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1221	1089	1589	74	1255	1353
			load	1056	944	1333	66	1082	1181
			domContentLoaded	1050	939	1325	66	1076	1176
			domInteractive	18	13	65	8	17	28
			firstPaint	605	71	1234	422	1053	1149
			backgroundConnect	7	4	20	3	8	11
			firstReactRender	20	15	54	5	21	33
			getState	12	5	31	7	19	27
			initialActions	0	0	1	0	0	1
			loadScripts	810	702	1054	63	838	931
			setupStore	8	4	23	3	8	12
	Webpack	Home	uiStartup	2098	1725	2447	165	2199	2386
			load	1619	1298	1867	125	1712	1819
			domContentLoaded	1612	1292	1857	125	1708	1813
			domInteractive	15	11	61	10	13	48
			firstPaint	176	64	518	69	214	299
			backgroundConnect	26	9	188	21	29	56
			firstReactRender	207	55	392	121	338	368
			getState	13	3	230	23	14	23
			initialActions	3	1	8	1	3	5
			loadScripts	1608	1290	1852	126	1707	1810
			setupStore	19	7	249	24	19	35
Firefox	Browserify	Home	uiStartup	1356	1170	1809	108	1412	1567
			load	1207	1005	1689	110	1279	1383
			domContentLoaded	1207	1004	1689	110	1279	1382
			domInteractive	105	38	249	31	121	154
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	13	67	8	21	35
			firstReactRender	22	19	58	4	23	28
			getState	9	4	171	17	8	18
			initialActions	0	0	1	0	0	1
			loadScripts	1188	992	1676	110	1260	1362
			setupStore	6	4	30	4	6	18
	Webpack	Home	uiStartup	1538	1351	2072	146	1629	1879
			load	1317	1153	1797	132	1393	1604
			domContentLoaded	1317	1153	1795	132	1393	1604
			domInteractive	85	34	163	24	101	136
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	14	41	5	22	31
			firstReactRender	35	29	48	5	37	47
			getState	9	4	30	6	8	28
			initialActions	0	0	1	0	1	1
			loadScripts	1298	1139	1775	131	1373	1584
			setupStore	9	5	55	8	8	29

Bundle size diffs

background: 0 Bytes (0%)
ui: 0 Bytes (0%)
common: 0 Bytes (0%)

metamaskbot · 2025-04-16T18:11:58Z

Builds ready [20ed87b]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1209 ± 63 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1209	1075	1515	63	1239	1312
			load	1045	954	1228	53	1072	1144
			domContentLoaded	1039	950	1220	52	1065	1140
			domInteractive	18	13	61	8	17	30
			firstPaint	719	131	1164	409	1058	1144
			backgroundConnect	7	4	26	3	7	11
			firstReactRender	21	15	37	5	21	33
			getState	13	5	86	11	17	31
			initialActions	0	0	2	0	0	1
			loadScripts	800	710	962	51	826	904
			setupStore	8	4	25	4	9	16
	Webpack	Home	uiStartup	2061	1636	2346	131	2117	2284
			load	1600	1302	1840	99	1690	1763
			domContentLoaded	1593	1298	1837	99	1684	1760
			domInteractive	16	10	65	11	13	51
			firstPaint	177	69	367	66	219	323
			backgroundConnect	26	9	357	36	25	57
			firstReactRender	198	54	374	122	332	351
			getState	12	4	248	24	11	21
			initialActions	3	1	5	1	3	4
			loadScripts	1588	1297	1835	101	1680	1759
			setupStore	17	6	283	27	17	31
Firefox	Browserify	Home	uiStartup	1328	1156	1772	129	1372	1569
			load	1185	995	1653	128	1234	1442
			domContentLoaded	1184	995	1653	128	1234	1442
			domInteractive	97	36	249	38	109	183
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	115	14	20	46
			firstReactRender	21	18	39	3	21	26
			getState	9	4	155	15	8	26
			initialActions	0	0	1	0	0	1
			loadScripts	1165	982	1630	128	1218	1426
			setupStore	6	4	22	2	6	9
	Webpack	Home	uiStartup	1507	1349	1853	124	1579	1770
			load	1287	1157	1603	107	1349	1529
			domContentLoaded	1287	1157	1603	107	1349	1529
			domInteractive	81	50	167	22	88	122
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	15	78	9	23	41
			firstReactRender	35	28	51	5	37	46
			getState	12	4	278	28	9	31
			initialActions	0	0	2	1	1	1
			loadScripts	1268	1139	1581	107	1331	1516
			setupStore	8	5	31	5	8	22

metamaskbot · 2025-04-17T09:11:14Z

Builds ready [d3fee30]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1213 ± 69 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1213	1091	1609	69	1245	1332
			load	1049	950	1360	60	1071	1169
			domContentLoaded	1043	946	1357	60	1066	1159
			domInteractive	18	13	65	9	16	36
			firstPaint	719	90	1215	417	1059	1140
			backgroundConnect	7	4	25	2	7	9
			firstReactRender	21	16	51	6	21	33
			getState	12	5	30	7	16	27
			initialActions	0	0	1	0	0	1
			loadScripts	801	711	959	50	828	877
			setupStore	8	6	24	3	8	12
	Webpack	Home	uiStartup	2108	1698	2527	169	2225	2395
			load	1629	1278	2148	156	1715	1936
			domContentLoaded	1623	1271	2144	156	1708	1908
			domInteractive	16	11	65	12	13	53
			firstPaint	180	68	411	64	210	293
			backgroundConnect	23	9	72	13	25	59
			firstReactRender	217	54	467	127	345	362
			getState	17	4	355	43	14	28
			initialActions	3	1	7	1	3	4
			loadScripts	1618	1268	2142	155	1706	1885
			setupStore	19	6	296	29	18	31
Firefox	Browserify	Home	uiStartup	1949	1215	3283	522	2289	2984
			load	1761	1092	3118	501	2103	2782
			domContentLoaded	1761	1091	3118	501	2103	2782
			domInteractive	193	49	666	115	239	441
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	15	93	11	28	45
			firstReactRender	29	20	95	12	33	51
			getState	12	5	167	18	10	32
			initialActions	0	0	1	0	0	1
			loadScripts	1739	1064	3097	500	2068	2761
			setupStore	11	4	273	27	8	17
	Webpack	Home	uiStartup	1537	1328	1965	154	1625	1885
			load	1308	1143	1649	122	1367	1578
			domContentLoaded	1307	1142	1649	122	1367	1578
			domInteractive	84	39	198	31	94	159
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	14	166	16	24	40
			firstReactRender	35	29	51	4	37	45
			getState	13	4	301	30	10	30
			initialActions	1	0	2	1	1	1
			loadScripts	1288	1123	1632	122	1352	1559
			setupStore	12	5	338	33	8	30

metamaskbot · 2025-04-17T09:34:21Z

Builds ready [96c1e19]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1197 ± 59 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1197	1072	1341	59	1241	1295
			load	1035	945	1183	51	1062	1123
			domContentLoaded	1029	941	1176	49	1056	1118
			domInteractive	17	13	41	5	17	28
			firstPaint	718	132	1183	401	1044	1118
			backgroundConnect	7	4	36	3	7	9
			firstReactRender	22	16	51	7	22	39
			getState	12	5	36	8	17	29
			initialActions	0	0	1	0	0	1
			loadScripts	792	705	945	48	814	877
			setupStore	7	5	18	2	8	12
	Webpack	Home	uiStartup	2142	1722	2645	174	2246	2370
			load	1657	1341	2023	130	1758	1848
			domContentLoaded	1650	1337	2011	130	1754	1840
			domInteractive	16	11	64	10	13	50
			firstPaint	176	73	419	61	213	287
			backgroundConnect	24	9	106	14	25	55
			firstReactRender	215	55	458	126	348	367
			getState	10	4	31	5	13	22
			initialActions	6	1	277	27	3	6
			loadScripts	1645	1336	1987	129	1752	1835
			setupStore	19	6	311	30	19	32
Firefox	Browserify	Home	uiStartup	1344	1166	1707	116	1396	1612
			load	1192	1036	1546	109	1244	1432
			domContentLoaded	1191	1036	1545	109	1244	1432
			domInteractive	99	39	292	37	104	180
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	13	121	15	23	45
			firstReactRender	23	19	62	6	24	31
			getState	9	4	201	20	8	19
			initialActions	0	0	1	0	0	1
			loadScripts	1171	1023	1529	110	1225	1417
			setupStore	8	4	187	18	6	8
	Webpack	Home	uiStartup	1534	1339	2171	142	1613	1784
			load	1314	1158	1918	127	1392	1529
			domContentLoaded	1314	1157	1918	127	1391	1528
			domInteractive	84	36	151	23	95	130
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	15	93	9	24	38
			firstReactRender	34	29	60	5	36	44
			getState	12	5	266	26	9	29
			initialActions	0	0	1	0	1	1
			loadScripts	1294	1139	1900	127	1374	1508
			setupStore	8	5	37	6	8	27

Gudahtt · 2025-04-17T13:02:09Z

I noticed that the imported names were flagged in a lot of places here. This was unintended, and we recently loosened this rule in the config repo to be more accepting of different import names: MetaMask/eslint-config#388
(not released yet, expected to land in the next v14.x config release)

Perhaps we could bring those config changes in early here, and drop those lint violations? We do want to keep using capitalized imports for imported classes I think.

Let me know if you'd prefer to make those changes here, or in a later PR.

DDDDDanica · 2025-04-17T13:38:19Z

@Gudahtt thanks for sharing the updates ! Actually currently all the todos are made against v12.0.0 as after that we need a migration of eslint for extension to be able to achieve further migration to v14.0.0. What we can do is to have an override for the current rule in extension, which will be the exact same as the PR you showed me. So we can achieve all in 1 PR. WdYt ?

Gudahtt · 2025-04-17T14:40:38Z

What we can do is to have an override for the current rule in extension, which will be the exact same as the PR you showed me. So we can achieve all in 1 PR. WdYt ?

An override is exactly what I meant to suggest, sorry for the miscommunication. This sounds great.

DDDDDanica · 2025-04-17T20:20:47Z

Closed due to an updated rule, and new directives are collected in https://github.com/MetaMask/metamask-extension/pull/32106/files

DDDDDanica added the team-extension-platform Extension Platform team label Apr 15, 2025

DDDDDanica self-assigned this Apr 15, 2025

DDDDDanica force-pushed the chore/23528-naming-convention branch from fb5d772 to de55992 Compare April 15, 2025 22:15

DDDDDanica marked this pull request as ready for review April 16, 2025 10:31

DDDDDanica requested review from a team as code owners April 16, 2025 10:31

sahar-fehri previously approved these changes Apr 16, 2025

View reviewed changes

NidhiKJha previously approved these changes Apr 16, 2025

View reviewed changes

DDDDDanica dismissed stale reviews from NidhiKJha and sahar-fehri via dd4e069 April 16, 2025 13:07

DDDDDanica force-pushed the chore/23528-naming-convention branch from 2ee0243 to dd4e069 Compare April 16, 2025 13:07

sahar-fehri previously approved these changes Apr 16, 2025

View reviewed changes

GustavoRSSilva previously approved these changes Apr 16, 2025

View reviewed changes

NidhiKJha previously approved these changes Apr 16, 2025

View reviewed changes

DDDDDanica added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Apr 16, 2025

DDDDDanica dismissed stale reviews from GustavoRSSilva, sahar-fehri, and NidhiKJha via d3fee30 April 16, 2025 23:12

DDDDDanica force-pushed the chore/23528-naming-convention branch 2 times, most recently from d3fee30 to 96c1e19 Compare April 17, 2025 08:57

GustavoRSSilva previously approved these changes Apr 17, 2025

View reviewed changes

sahar-fehri previously approved these changes Apr 17, 2025

View reviewed changes

MajorLift previously approved these changes Apr 17, 2025

View reviewed changes

chore(23528): resolve conflicts

ac7a660

DDDDDanica dismissed stale reviews from MajorLift, sahar-fehri, and GustavoRSSilva via ac7a660 April 17, 2025 16:03

DDDDDanica force-pushed the chore/23528-naming-convention branch from 96c1e19 to ac7a660 Compare April 17, 2025 16:03

DDDDDanica mentioned this pull request Apr 17, 2025

refactor(23528): lint out @typescript-eslint/naming-convention #32106

Merged

7 tasks

DDDDDanica closed this Apr 17, 2025

github-actions bot locked and limited conversation to collaborators Apr 17, 2025

HowardBraham deleted the chore/23528-naming-convention branch January 19, 2026 18:46

Conversation

DDDDDanica commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Apr 15, 2025

Uh oh!

metamaskbot commented Apr 15, 2025

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Apr 15, 2025

Uh oh!

metamaskbot commented Apr 16, 2025

Uh oh!

metamaskbot commented Apr 16, 2025

Uh oh!

metamaskbot commented Apr 16, 2025

Uh oh!

metamaskbot commented Apr 16, 2025

Uh oh!

metamaskbot commented Apr 17, 2025

Uh oh!

metamaskbot commented Apr 17, 2025

Uh oh!

Gudahtt commented Apr 17, 2025

Uh oh!

DDDDDanica commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Gudahtt commented Apr 17, 2025

Uh oh!

DDDDDanica commented Apr 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

DDDDDanica commented Apr 15, 2025 •

edited

Loading

DDDDDanica commented Apr 17, 2025 •

edited

Loading