refactor(23528): lint out @typescript-eslint/naming-convention#32106
Merged
refactor(23528): lint out @typescript-eslint/naming-convention#32106
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (5 files, +14 -0)
🪪 @MetaMask/identity (1 files, +22 -0)
🔄 @MetaMask/swaps-engineers (3 files, +40 -2)
|
f722850 to
2da071d
Compare
Collaborator
Builds ready [2da071d]
UI Startup Metrics (1227 ± 61 ms)
Benchmark value 181 exceeds gate value 175 for chrome webpack home mean firstPaint Benchmark value 324 exceeds gate value 310 for chrome webpack home p95 firstPaint Benchmark value 112 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 199 exceeds gate value 195 for firefox browserify home p95 domInteractive Sum of mean exceeds: 9ms | Sum of p95 exceeds: 18ms Sum of all benchmark exceeds: 27ms |
DDDDDanica
commented
Apr 17, 2025
Collaborator
Builds ready [2343659]
UI Startup Metrics (1227 ± 61 ms)
Benchmark value 53 exceeds gate value 50 for firefox webpack home p95 firstReactRender Sum of mean exceeds: 8ms | Sum of p95 exceeds: 3ms Sum of all benchmark exceeds: 11ms Bundle size diffs
|
Collaborator
Builds ready [b040b5d]
UI Startup Metrics (1204 ± 70 ms)
Benchmark value 329 exceeds gate value 310 for chrome webpack home p95 firstPaint Benchmark value 47 exceeds gate value 45 for firefox webpack home p95 backgroundConnect Sum of mean exceeds: 9ms | Sum of p95 exceeds: 21ms Sum of all benchmark exceeds: 30ms Bundle size diffs
|
Collaborator
Builds ready [e765ed8]
UI Startup Metrics (1216 ± 66 ms)
Benchmark value 39 exceeds gate value 35 for chrome browserify home p95 domInteractive Benchmark value 191 exceeds gate value 175 for chrome webpack home mean firstPaint Benchmark value 312 exceeds gate value 310 for chrome webpack home p95 firstPaint Benchmark value 113 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 234 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 29 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 19ms | Sum of p95 exceeds: 46ms Sum of all benchmark exceeds: 65ms Bundle size diffs
|
GustavoRSSilva
previously approved these changes
Apr 18, 2025
Collaborator
Builds ready [0effece]
UI Startup Metrics (1221 ± 60 ms)
Sum of mean exceeds: 0ms | Sum of p95 exceeds: 15ms Sum of all benchmark exceeds: 15ms Bundle size diffs
|
0effece to
434b44d
Compare
Collaborator
Builds ready [434b44d]
UI Startup Metrics (1247 ± 79 ms)
Benchmark value 1248 exceeds gate value 1234 for chrome browserify home mean uiStartup Benchmark value 1077 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1071 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 1381 exceeds gate value 1365 for chrome browserify home p95 uiStartup Sum of mean exceeds: 32ms | Sum of p95 exceeds: 16ms Sum of all benchmark exceeds: 48ms Bundle size diffs
|
georgewrmarshall
previously approved these changes
Apr 22, 2025
Contributor
georgewrmarshall
left a comment
There was a problem hiding this comment.
Approving on behalf of @MetaMask/design-system-engineers
sahar-fehri
previously approved these changes
Apr 22, 2025
Collaborator
Builds ready [b014f64]
UI Startup Metrics (1226 ± 66 ms)
Sum of mean exceeds: 0ms | Sum of p95 exceeds: 15ms Sum of all benchmark exceeds: 15ms Bundle size diffs
|
991a06e
Collaborator
Builds ready [fbe8e94]
UI Startup Metrics (1187 ± 75 ms)
Benchmark value 2219 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 265 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 2667 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 62 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 398 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 1411 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 124 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 14 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 16 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1744 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 302 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 83 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 39 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 75 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 112 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 16 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 2068 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1768 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1768 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 320 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 50 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 1746 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 107ms | Sum of p95 exceeds: 1164ms Sum of all benchmark exceeds: 1271ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [281a3aa]
UI Startup Metrics (1188 ± 60 ms)
Benchmark value 2271 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1733 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1726 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 240 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 1723 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2737 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2062 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2046 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 72 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 403 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2044 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 116 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 1662 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 293 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 61 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 1721 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1493 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1493 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 115 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 27 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1468 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 16 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2087 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1753 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1753 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 350 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 53 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 33 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 1714 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 625ms | Sum of p95 exceeds: 1246ms Sum of all benchmark exceeds: 1871ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [312bdbe]
UI Startup Metrics (1202 ± 60 ms)
Benchmark value 20 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2242 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 255 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 2680 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2009 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 407 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 12 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1999 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 123 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 14 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 14 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1697 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 322 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 56 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 67 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1630 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1401 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1401 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 103 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1378 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 15 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 1979 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 303 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 45 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 70 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 178ms | Sum of p95 exceeds: 786ms Sum of all benchmark exceeds: 964ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [1c06f69]
UI Startup Metrics (1191 ± 72 ms)
Benchmark value 2220 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 257 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 2547 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 62 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 403 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 10 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1986 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1414 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 124 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 19 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 14 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1742 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 350 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 96 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 86 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 67 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1686 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1456 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1456 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 106 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 16 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 1434 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2009 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1740 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1739 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 299 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 52 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 38 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 1714 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 29 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 401ms | Sum of p95 exceeds: 986ms Sum of all benchmark exceeds: 1387ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [bc06e46]
UI Startup Metrics (1184 ± 57 ms)
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2270 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1724 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1718 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 1714 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2768 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2061 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2049 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 74 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 341 exceeds gate value 334 for chrome webpack home p95 firstPaint Benchmark value 398 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2038 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 119 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 14 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 16 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1676 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 314 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 36 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 66 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1654 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1427 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1427 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 109 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1406 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2020 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1747 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1746 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 312 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 1720 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 32 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 335ms | Sum of p95 exceeds: 1212ms Sum of all benchmark exceeds: 1547ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
MajorLift
approved these changes
Jul 2, 2025
MajorLift
previously approved these changes
Jul 2, 2025
Collaborator
Builds ready [68aa45f]
UI Startup Metrics (1223 ± 64 ms)
Benchmark value 17 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2235 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 255 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 2629 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 66 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 342 exceeds gate value 334 for chrome webpack home p95 firstPaint Benchmark value 401 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 8 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1440 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1263 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1263 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 126 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 1243 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1735 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 322 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 47 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 53 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1620 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1391 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1391 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 112 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 19 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 1369 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 15 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2099 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1798 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1797 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 315 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 34 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 1780 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 234ms | Sum of p95 exceeds: 1227ms Sum of all benchmark exceeds: 1461ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [b19e606]
UI Startup Metrics (1208 ± 82 ms)
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 34 exceeds gate value 33 for chrome browserify home p95 getState Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2240 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 240 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 2656 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 63 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 407 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 1422 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 124 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 20 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 16 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 298 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 59 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 75 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1736 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1507 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1507 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 114 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1484 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2170 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1861 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1861 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 286 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 34 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 1837 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 31 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 623ms | Sum of p95 exceeds: 1412ms Sum of all benchmark exceeds: 2035ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
MajorLift
approved these changes
Jul 3, 2025
Collaborator
Builds ready [847eab2]
UI Startup Metrics (1213 ± 51 ms)
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 20 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2294 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1723 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1715 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 271 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 16 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1712 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2725 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2043 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2028 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 80 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 413 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 37 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2016 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1433 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1253 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1253 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 129 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1232 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1755 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 303 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 25 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 47 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1709 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1475 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1475 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 106 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1454 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2091 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1718 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1718 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 289 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 33 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 17 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1698 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 48 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 661ms | Sum of p95 exceeds: 1221.8ms Sum of all benchmark exceeds: 1882.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Note: This PR is an update version from #32021 due to loosened eslint rules. Discussion can be found #32021 (comment).
This PR addresses TypeScript ESLint error
@typescript-eslint/naming-conventionacross the repository following the planned upgrade to@metamask/eslint-configv14.x.0(release notes here). For@typescript-eslint/naming-conventionviolations:@metamask/eslint-configrule from Loosen@typescript-eslint/naming-conventionrule to allow more formats for import names eslint-config#388@typescript-eslint/naming-conventionviolations #31860This approach follows our strategy for handling ESLint upgrades. The comprehensive fixes for these typing issues will be addressed in dedicated PRs to avoid blocking development.
Related issues
Fixes: #23528
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist