Skip to content

refactor(23528): lint out @typescript-eslint/naming-convention#32106

Merged
Gudahtt merged 41 commits intomainfrom
chore/23528-naming-convention-v2
Jul 3, 2025
Merged

refactor(23528): lint out @typescript-eslint/naming-convention#32106
Gudahtt merged 41 commits intomainfrom
chore/23528-naming-convention-v2

Conversation

@DDDDDanica
Copy link
Copy Markdown
Contributor

@DDDDDanica DDDDDanica commented Apr 17, 2025

Description

Note: This PR is an update version from #32021 due to loosened eslint rules. Discussion can be found #32021 (comment).

This PR addresses TypeScript ESLint error @typescript-eslint/naming-convention across the repository following the planned upgrade to @metamask/eslint-config v14.x.0(release notes here). For @typescript-eslint/naming-convention violations:

This approach follows our strategy for handling ESLint upgrades. The comprehensive fixes for these typing issues will be addressed in dedicated PRs to avoid blocking development.

Open in GitHub Codespaces

Related issues

Fixes: #23528

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@DDDDDanica DDDDDanica added team-extension-platform Extension Platform team no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels Apr 17, 2025
@DDDDDanica DDDDDanica self-assigned this Apr 17, 2025
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Apr 17, 2025

✨ Files requiring CODEOWNER review ✨

@MetaMask/confirmations (5 files, +14 -0)
  • 📁 app/
    • 📁 scripts/
      • 📁 controller-init/
        • 📁 confirmations/
          • 📄 ppom-controller-init.test.ts +2 -0
          • 📄 transaction-controller-init.test.ts +2 -0
      • 📁 lib/
        • 📁 ppom/
          • 📄 ppom-middleware.test.ts +2 -0
          • 📄 ppom-util.test.ts +6 -0
          • 📄 ppom-util.ts +2 -0

🪪 @MetaMask/identity (1 files, +22 -0)
  • 📁 app/
    • 📁 scripts/
      • 📁 controller-init/
        • 📁 identity/
          • 📄 user-storage-controller-init.ts +22 -0

🔄 @MetaMask/swaps-engineers (3 files, +40 -2)
  • 📁 app/
    • 📁 scripts/
      • 📁 controllers/
        • 📁 swaps/
          • 📄 index.ts +4 -0
          • 📄 swaps.test.ts +24 -0
      • 📁 lib/
        • 📁 bridge-status/
          • 📄 metrics.ts +12 -2

@DDDDDanica DDDDDanica force-pushed the chore/23528-naming-convention-v2 branch from f722850 to 2da071d Compare April 17, 2025 20:19
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [2da071d]
UI Startup Metrics (1227 ± 61 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1227110314586112601328
load106195112445210891147
domContentLoaded105594612395210821141
domInteractive17133141728
firstPaint710135124641910681152
backgroundConnect74233812
firstReactRender24164982645
getState1263471829
initialActions001001
loadScripts81371093449842890
setupStore84193914
WebpackHomeuiStartup20991701238615822102317
load16181323182911517251771
domContentLoaded16111320182511517181762
domInteractive15115691338
firstPaint1817336363224323
backgroundConnect251372142759
firstReactRender21854371117344359
getState1244571427
initialActions316136
loadScripts16061318182411617161759
setupStore1764372033
FirefoxBrowserifyHomeuiStartup13751199163110114431593
load12221045148110612921439
domContentLoaded12221044148110612921439
domInteractive1123931441125199
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect20139692134
firstReactRender23193932330
getState84405815
initialActions001001
loadScripts12031031146410612711414
setupStore8416716612
WebpackHomeuiStartup15521350206412916151817
load13301154178411913991588
domContentLoaded13301154178411913981588
domInteractive895723728102137
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2213102102240
firstReactRender35295053845
getState94336827
initialActions002111
loadScripts13111134176011913781570
setupStore85344813
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 181 exceeds gate value 175 for chrome webpack home mean firstPaint
Benchmark value 324 exceeds gate value 310 for chrome webpack home p95 firstPaint
Benchmark value 112 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 199 exceeds gate value 195 for firefox browserify home p95 domInteractive
Sum of mean exceeds: 9ms | Sum of p95 exceeds: 18ms
Sum of all benchmark exceeds: 27ms

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [2343659]
UI Startup Metrics (1227 ± 61 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1227112014166112601336
load106396612415510981166
domContentLoaded105796212345410871160
domInteractive18146381730
firstPaint685166119041410651126
backgroundConnect74223811
firstReactRender20153952134
getState1354791929
initialActions003001
loadScripts81471695850845916
setupStore75142812
WebpackHomeuiStartup21271777256814722322360
load16551395196611417381851
domContentLoaded16481390195511317311845
domInteractive171181131352
firstPaint1827038859223288
backgroundConnect24970142658
firstReactRender19555371126336356
getState174307391434
initialActions316135
loadScripts16441388193111317281825
setupStore266317492139
FirefoxBrowserifyHomeuiStartup13091138176713213681569
load1172969162513412441441
domContentLoaded1171969162413412441441
domInteractive983725631111149
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2013198191928
firstReactRender21185342126
getState73304710
initialActions001001
loadScripts1153947160613312161424
setupStore64344611
WebpackHomeuiStartup15181362187411515911750
load12951157164310413551496
domContentLoaded12951157164310313541496
domInteractive82421882393141
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2414110132440
firstReactRender36295963853
getState94325920
initialActions001011
loadScripts1273114315759813371477
setupStore105669927
Benchmark value 183 exceeds gate value 175 for chrome webpack home mean firstPaint
Benchmark value 53 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Sum of mean exceeds: 8ms | Sum of p95 exceeds: 3ms
Sum of all benchmark exceeds: 11ms

Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [b040b5d]
UI Startup Metrics (1204 ± 70 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1204106714647012401307
load104094412696310661151
domContentLoaded103493912616110581147
domInteractive17135971628
firstPaint67681123742010541121
backgroundConnect74263817
firstReactRender20164252131
getState1253071827
initialActions001000
loadScripts799712103360826914
setupStore75152811
WebpackHomeuiStartup20331609250618621242300
load15741283193614016761847
domContentLoaded15671276190813816701839
domInteractive151161101344
firstPaint1836454573232329
backgroundConnect22982132552
firstReactRender19854376127343356
getState1043151120
initialActions319135
loadScripts15631272188513616661815
setupStore176305291824
FirefoxBrowserifyHomeuiStartup13541184166810714131567
load12081029154310812621424
domContentLoaded12071029154310812621424
domInteractive1063725941112190
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2113147142036
firstReactRender23195652332
getState7427389
initialActions001001
loadScripts11881010152910612411403
setupStore7467768
WebpackHomeuiStartup15091340188612216051723
load12911160164210913691478
domContentLoaded12901159164210913691478
domInteractive84353053292137
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect231490102347
firstReactRender35295043743
getState94517922
initialActions102111
loadScripts12701142162810613411457
setupStore85536814
Benchmark value 184 exceeds gate value 175 for chrome webpack home mean firstPaint
Benchmark value 329 exceeds gate value 310 for chrome webpack home p95 firstPaint
Benchmark value 47 exceeds gate value 45 for firefox webpack home p95 backgroundConnect
Sum of mean exceeds: 9ms | Sum of p95 exceeds: 21ms
Sum of all benchmark exceeds: 30ms

Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [e765ed8]
UI Startup Metrics (1216 ± 66 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1216108814736612551325
load105495313086210911176
domContentLoaded104894913016110841169
domInteractive18146291739
firstPaint72874120641810671166
backgroundConnect74122810
firstReactRender22155682241
getState1246691730
initialActions001001
loadScripts811715105259845918
setupStore84152813
WebpackHomeuiStartup21081706255919622472387
load16311285207515417481869
domContentLoaded16241281207015217421858
domInteractive161177111351
firstPaint1906837668249312
backgroundConnect2610170202658
firstReactRender19655396118312368
getState134206201225
initialActions3110135
loadScripts16191278204615117401837
setupStore196300291929
FirefoxBrowserifyHomeuiStartup13521143172411214051541
load12081014160011812651416
domContentLoaded12081014159911812651415
domInteractive1123928145124234
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect19138392031
firstReactRender22195752226
getState6416279
initialActions002001
loadScripts11901000158211812481392
setupStore6436467
WebpackHomeuiStartup15141332202212615911766
load12981150176111413601532
domContentLoaded12981149176011413601532
domInteractive864616926102138
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2514267272245
firstReactRender352910183646
getState84314911
initialActions102111
loadScripts12761131174411113341498
setupStore95699829
cc: @HowardBraham
Benchmark value 39 exceeds gate value 35 for chrome browserify home p95 domInteractive
Benchmark value 191 exceeds gate value 175 for chrome webpack home mean firstPaint
Benchmark value 312 exceeds gate value 310 for chrome webpack home p95 firstPaint
Benchmark value 113 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 234 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 29 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 19ms | Sum of p95 exceeds: 46ms
Sum of all benchmark exceeds: 65ms

Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

@DDDDDanica DDDDDanica marked this pull request as ready for review April 18, 2025 14:08
@DDDDDanica DDDDDanica requested review from a team as code owners April 18, 2025 14:08
GustavoRSSilva
GustavoRSSilva previously approved these changes Apr 18, 2025
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [0effece]
UI Startup Metrics (1221 ± 60 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1221111513696012641335
load105192611956010831165
domContentLoaded104592011865910791159
domInteractive191369111755
firstPaint655136117442010621128
backgroundConnect6411179
firstReactRender22165172339
getState1353071827
initialActions001001
loadScripts80767294458846904
setupStore84273814
WebpackHomeuiStartup20961671242716622382305
load16221252187112917231811
domContentLoaded16161246186712817151807
domInteractive151160101344
firstPaint1796336066221310
backgroundConnect289359362755
firstReactRender20154374117323356
getState1043851319
initialActions316135
loadScripts16111243184412817131785
setupStore197282272032
FirefoxBrowserifyHomeuiStartup13521150164411114131605
load12101004152911712831469
domContentLoaded12101003152911812831469
domInteractive1044124132111176
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2213100142047
firstReactRender22195552127
getState7444479
initialActions001001
loadScripts1190990151411612581451
setupStore6323368
WebpackHomeuiStartup15001317176411315731722
load12841142153810013671474
domContentLoaded12831142153810013671474
domInteractive80361622288122
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect22147592340
firstReactRender35295343744
getState94386924
initialActions002111
loadScripts1264112815219913431451
setupStore85274822
Benchmark value 56 exceeds gate value 41 for chrome browserify home p95 domInteractive
Sum of mean exceeds: 0ms | Sum of p95 exceeds: 15ms
Sum of all benchmark exceeds: 15ms

Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [434b44d]
UI Startup Metrics (1247 ± 79 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1247110415657913081380
load107695113657111261178
domContentLoaded107094613587111231173
domInteractive18146481731
firstPaint655112120843510911170
backgroundConnect74223812
firstReactRender2415170162437
getState1354481629
initialActions001001
loadScripts825716111767872933
setupStore84193813
WebpackHomeuiStartup21261758256017322572383
load16491302216114817561929
domContentLoaded16421293215514717501923
domInteractive161168121351
firstPaint1786539968226296
backgroundConnect2710175203154
firstReactRender20256374119333355
getState1143461424
initialActions316135
loadScripts16381289215314617471900
setupStore187203202032
FirefoxBrowserifyHomeuiStartup13321134171211714101548
load11831008159211912701413
domContentLoaded11831008159211912691413
domInteractive993819129116150
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect201386102130
firstReactRender22194632226
getState83547721
initialActions001001
loadScripts1165986157912012521392
setupStore941672169
WebpackHomeuiStartup14721321183110415261703
load1256114215578912841478
domContentLoaded1255114115578912831478
domInteractive81591632389132
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2114102102234
firstReactRender34296153644
getState84313912
initialActions102111
loadScripts1236111815388912671460
setupStore12529329825
cc: @HowardBraham
Benchmark value 1248 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1077 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1071 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 1381 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Sum of mean exceeds: 32ms | Sum of p95 exceeds: 16ms
Sum of all benchmark exceeds: 48ms

Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

Copy link
Copy Markdown
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on behalf of @MetaMask/design-system-engineers

sahar-fehri
sahar-fehri previously approved these changes Apr 22, 2025
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [b014f64]
UI Startup Metrics (1226 ± 66 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1226113015296612681325
load104691313736510811168
domContentLoaded104090813716510781159
domInteractive191466101755
firstPaint72282119241410561138
backgroundConnect7433379
firstReactRender21156172237
getState1353371927
initialActions001000
loadScripts802682110161838904
setupStore85313812
WebpackHomeuiStartup20971730241317822402351
load16181353196113017181795
domContentLoaded16111349195412917101787
domInteractive161160101346
firstPaint1876350572235334
backgroundConnect26971133253
firstReactRender20855393120330357
getState144167171527
initialActions318136
loadScripts16071348193212917081785
setupStore226286352134
FirefoxBrowserifyHomeuiStartup13311168175311113801573
load11891017161611212411372
domContentLoaded11891017161611212411372
domInteractive1054035641115169
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect20137482043
firstReactRender22185042226
getState841681679
initialActions001001
loadScripts11711005158911212241355
setupStore6428369
WebpackHomeuiStartup15491397204012716171850
load13161177164910713731546
domContentLoaded13151176164910813721546
domInteractive83372793189148
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect23144452435
firstReactRender36304943944
getState115175171020
initialActions102111
loadScripts12951157162710713511530
setupStore105587928
Benchmark value 56 exceeds gate value 41 for chrome browserify home p95 domInteractive
Sum of mean exceeds: 0ms | Sum of p95 exceeds: 15ms
Sum of all benchmark exceeds: 15ms

Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

@DDDDDanica DDDDDanica dismissed stale reviews from georgewrmarshall and sahar-fehri via 991a06e April 23, 2025 17:30
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [fbe8e94]
UI Startup Metrics (1187 ± 75 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1187106514837512261312
load101390212826710411128
domContentLoaded100689712776710341123
domInteractive17134051634
firstPaint61973121240410181095
backgroundConnect84324813
firstReactRender23174962339
getState1563382130
initialActions001001
loadScripts80070198860832915
setupStore95314921
WebpackHomeuiStartup22191691280520623102667
load16701280210616717521986
domContentLoaded16641276209516517471975
domInteractive1812123181361
firstPaint1646337067190315
backgroundConnect22127482538
firstReactRender26491407119385398
getState1255981530
initialActions215134
loadScripts16611274208216317451963
setupStore227308412034
FirefoxBrowserifyHomeuiStartup14111195219816314811744
load12311062203412712921408
domContentLoaded12301062203312712921408
domInteractive1243648874133302
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2814194302383
firstReactRender25225142630
getState13519824939
initialActions001001
loadScripts12071042201812312581379
setupStore16418933775
WebpackHomeuiStartup16051380230120117052068
load13761164196716514581768
domContentLoaded13751164196716514571768
domInteractive112345289394320
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect23156382540
firstReactRender42304944447
getState165251271150
initialActions001011
loadScripts13541143194516614351746
setupStore105779823
Benchmark value 21 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2219 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 265 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 2667 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 62 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 398 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 1411 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 124 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 14 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 16 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1744 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 302 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 83 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 39 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 75 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 112 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 16 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 2068 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1768 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1768 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 320 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 50 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 1746 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 107ms | Sum of p95 exceeds: 1164ms
Sum of all benchmark exceeds: 1271ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 33 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 15 Bytes (0%)

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [281a3aa]
UI Startup Metrics (1188 ± 60 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1188105913296012371292
load101290811625810571102
domContentLoaded100690211565710501097
domInteractive17146071728
firstPaint60481110740410131080
backgroundConnect74253812
firstReactRender22174852335
getState1463672027
initialActions006100
loadScripts79969593155842889
setupStore95255921
WebpackHomeuiStartup22701670279524424052736
load17321265222920918652061
domContentLoaded17251261221520718592045
domInteractive1912100161672
firstPaint1626543562172302
backgroundConnect2612331322844
firstReactRender24090422116373403
getState1354991732
initialActions31173314
loadScripts17221259220520618552043
setupStore227332411944
FirefoxBrowserifyHomeuiStartup13941215184412114611662
load1224103815109612941395
domContentLoaded1223103715109712941395
domInteractive1153136959128293
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect211381102239
firstReactRender26225352635
getState1259017961
initialActions001001
loadScripts1205101914939512781369
setupStore74385714
WebpackHomeuiStartup17211426265920818102087
load14921242197715816041753
domContentLoaded14921242197615816041753
domInteractive1143654285103350
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2615274272546
firstReactRender43315754553
getState124163191033
initialActions002111
loadScripts14671220194215215701714
setupStore16529639928
Benchmark value 21 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2271 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1733 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1726 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 240 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 1723 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2737 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2062 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2046 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 72 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 403 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 2044 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 116 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 1662 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 293 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 61 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 1721 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1493 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1493 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 115 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 27 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1468 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 16 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2087 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1753 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1753 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 350 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 53 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 33 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 1714 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 625ms | Sum of p95 exceeds: 1246ms
Sum of all benchmark exceeds: 1871ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 33 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 15 Bytes (0%)

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [312bdbe]
UI Startup Metrics (1202 ± 60 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1202109314186012371299
load102593511915310651113
domContentLoaded101893111855210561106
domInteractive18145471739
firstPaint73078120140310541115
backgroundConnect84324812
firstReactRender22163642333
getState1563372228
initialActions001001
loadScripts80672095750843890
setupStore95284920
WebpackHomeuiStartup22411688285221723622680
load17001241211017417932025
domContentLoaded16941237209217217842009
domInteractive181287141457
firstPaint1646673489175328
backgroundConnect2410280272642
firstReactRender25591437118379407
getState164324321730
initialActions31153312
loadScripts16911236208117117831998
setupStore207313312138
FirefoxBrowserifyHomeuiStartup14011206215414614521697
load12251058160110012871396
domContentLoaded12251058160110012861395
domInteractive1223759482130322
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2513215282256
firstReactRender24215232428
getState13529131956
initialActions001001
loadScripts1205104215839812601380
setupStore14418728867
WebpackHomeuiStartup16301411212516817251979
load14001198176512914971637
domContentLoaded14001198176412914971636
domInteractive103343516396303
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect241685102544
firstReactRender42365344449
getState145119161145
initialActions002111
loadScripts13781177173912914781606
setupStore15528432870
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 20 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2242 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 255 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 2680 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2009 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 407 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 12 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1999 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 123 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 14 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 14 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1697 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 322 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 56 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 67 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1630 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1401 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1401 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 103 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1378 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 15 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 1979 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 303 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 45 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 70 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 178ms | Sum of p95 exceeds: 786ms
Sum of all benchmark exceeds: 964ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 33 Bytes (0%)
  • ui: 983 Bytes (0.01%)
  • common: 15 Bytes (0%)

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [1c06f69]
UI Startup Metrics (1191 ± 72 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1191107614727212301312
load101691313106210401121
domContentLoaded101090713056110341115
domInteractive18135271740
firstPaint716139130939910341110
backgroundConnect74152811
firstReactRender22164552335
getState1564482030
initialActions001001
loadScripts803704109760828905
setupStore96213919
WebpackHomeuiStartup22191662275020523372547
load16801246220317417612006
domContentLoaded16731242218717217561996
domInteractive1912197231462
firstPaint1696446272218297
backgroundConnect2410262252634
firstReactRender25689415118386403
getState1244871426
initialActions31143310
loadScripts16701240217617117531986
setupStore227315421940
FirefoxBrowserifyHomeuiStartup14131197196015914891742
load12281063166311212841482
domContentLoaded12281063166211212841482
domInteractive1233255985128350
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2613203292496
firstReactRender26224952839
getState185209341086
initialActions001001
loadScripts12051050147210412571461
setupStore144229271067
WebpackHomeuiStartup16861411235019518192009
load14561221182815915891740
domContentLoaded14561221182815915881739
domInteractive1053746767102299
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect23158692437
firstReactRender44347254752
getState166297361038
initialActions102112
loadScripts14331202180615815701714
setupStore1059711929
Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2220 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 257 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 2547 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 62 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 403 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 10 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1986 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 1414 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 124 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 19 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 14 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1742 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 350 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 96 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 86 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 67 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1686 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1456 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1456 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 106 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 16 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 1434 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2009 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1740 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1739 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 299 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 52 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 38 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 1714 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 29 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 401ms | Sum of p95 exceeds: 986ms
Sum of all benchmark exceeds: 1387ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 33 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 15 Bytes (0%)

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [bc06e46]
UI Startup Metrics (1184 ± 57 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1184105313705712261280
load101091611655010361105
domContentLoaded100390811605110311100
domInteractive18145271736
firstPaint679134112040210181100
backgroundConnect84273811
firstReactRender23174262539
getState1573882130
initialActions001001
loadScripts79670794749821892
setupStore96224919
WebpackHomeuiStartup22701762297024223772767
load17231257229621818512061
domContentLoaded17171253228521718472049
domInteractive1912100171574
firstPaint1716741669183341
backgroundConnect2610286282551
firstReactRender21990411106333398
getState175281291829
initialActions6128028314
loadScripts17141251227321518412038
setupStore227316362040
FirefoxBrowserifyHomeuiStartup13961235195414014691676
load1213108714989012721388
domContentLoaded1212108614979012721388
domInteractive1183646375116314
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2413128162350
firstReactRender25214852636
getState13519622936
initialActions001001
loadScripts1193105614799012551374
setupStore164328381066
WebpackHomeuiStartup16531397248120017532020
load14261200190716015171747
domContentLoaded14261200190716015171746
domInteractive1083352478101312
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21154062235
firstReactRender42335134548
getState135120161029
initialActions102111
loadScripts14061184188416014971720
setupStore1057610832
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2270 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1724 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1718 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 1714 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2768 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2061 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2049 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 74 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 341 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 398 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 2038 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 119 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 14 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 16 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1676 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 314 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 36 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 66 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1654 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1427 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1427 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 109 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1406 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2020 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1747 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1746 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 312 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 1720 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 32 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 335ms | Sum of p95 exceeds: 1212ms
Sum of all benchmark exceeds: 1547ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 33 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 15 Bytes (0%)

MajorLift
MajorLift previously approved these changes Jul 2, 2025
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [68aa45f]
UI Startup Metrics (1223 ± 64 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1223110314036412611339
load104392911955910861154
domContentLoaded103692111875810801146
domInteractive17144851727
firstPaint671146118941510521123
backgroundConnect84222911
firstReactRender24175172539
getState16681122329
initialActions001001
loadScripts82771898058869937
setupStore95274919
WebpackHomeuiStartup22351653293523423492629
load16901243221719217991975
domContentLoaded16831236219519117941963
domInteractive2012152201566
firstPaint1566242378183342
backgroundConnect2510274262741
firstReactRender25589421118383401
getState194366481736
initialActions3112238
loadScripts16781234218419017891952
setupStore1774782136
FirefoxBrowserifyHomeuiStartup14391229231415715021735
load12631078217413413211433
domContentLoaded12631078217413413211432
domInteractive1263648374141322
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect231496122444
firstReactRender26225542630
getState1158613947
initialActions001001
loadScripts12431052215513413061406
setupStore1047313753
WebpackHomeuiStartup16201402274222716872099
load13911212200316614461798
domContentLoaded13901212200316614461797
domInteractive112335688397315
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect231582102539
firstReactRender42326554449
getState195305421234
initialActions002111
loadScripts13681191197016514251780
setupStore15532739823
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 17 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2235 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 255 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 2629 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 66 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 342 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 401 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 8 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1440 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1263 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1263 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 126 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 1243 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1735 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 322 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 47 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 53 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1620 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1391 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1391 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 112 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 19 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 1369 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 15 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2099 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1798 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1797 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 315 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 34 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 1780 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 234ms | Sum of p95 exceeds: 1227ms
Sum of all benchmark exceeds: 1461ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 33 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 15 Bytes (0%)

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [b19e606]
UI Startup Metrics (1208 ± 82 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1208106716598212521319
load102691314617610661141
domContentLoaded101990914557510581135
domInteractive18144761737
firstPaint64673146141810321128
backgroundConnect74122810
firstReactRender2516161162443
getState16658102134
initialActions001000
loadScripts810696124374846924
setupStore95234918
WebpackHomeuiStartup22401785269819223542656
load17011308201116618261983
domContentLoaded16941304199816518201977
domInteractive1913120161562
firstPaint1576946666169299
backgroundConnect2610347342741
firstReactRender23991414120376407
getState194330431742
initialActions3112236
loadScripts16911303198916418161966
setupStore227281372044
FirefoxBrowserifyHomeuiStartup14211196195114114921650
load1236106714338813061389
domContentLoaded1235106714338813061388
domInteractive1243647272134298
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21137592234
firstReactRender26225262640
getState19529547959
initialActions001001
loadScripts1217105214178712911374
setupStore16431939875
WebpackHomeuiStartup17361444360328518392170
load15071245335425416191861
domContentLoaded15061245335325416181861
domInteractive1133558678102286
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2616280272439
firstReactRender44325954750
getState155208281034
initialActions002111
loadScripts14841226332925315971837
setupStore11511314931
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 34 exceeds gate value 33 for chrome browserify home p95 getState
Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2240 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 240 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 2656 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 63 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 407 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 1422 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 124 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 20 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 16 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 298 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 59 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 75 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1736 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1507 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1507 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 114 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1484 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2170 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1861 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1861 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 286 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 34 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 1837 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 31 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 623ms | Sum of p95 exceeds: 1412ms
Sum of all benchmark exceeds: 2035ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 33 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 15 Bytes (0%)

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [847eab2]
UI Startup Metrics (1213 ± 51 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1213112713405112511316
load104195311574910721121
domContentLoaded103494811474910661110
domInteractive18135481741
firstPaint714129115140610531108
backgroundConnect84273814
firstReactRender22164152335
getState16686102229
initialActions30205316
loadScripts78870288847822861
setupStore85224820
WebpackHomeuiStartup22931753285721424032724
load17221305213917218102043
domContentLoaded17141301212317018022027
domInteractive2113119201580
firstPaint1607440670172315
backgroundConnect24105492944
firstReactRender27191432115381413
getState194269272244
initialActions162210321237
loadScripts17111299211116918002016
setupStore268364452448
FirefoxBrowserifyHomeuiStartup14331213220514515031755
load12521069207113013241443
domContentLoaded12521069207013013241443
domInteractive129361098116131303
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2414112162553
firstReactRender26215142731
getState11519120920
initialActions40588325
loadScripts12311052205612813061399
setupStore1147614947
WebpackHomeuiStartup17091411224019618122091
load14741187188915615921718
domContentLoaded14741187188815615911718
domInteractive1063538458104289
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect24174262637
firstReactRender43325144550
getState1155191033
initialActions518511617
loadScripts14531167186515515731698
setupStore14528530948
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 20 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2294 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1723 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1715 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 271 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 16 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 1712 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2725 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2043 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2028 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 80 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 413 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 37 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 2016 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 1433 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1253 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1253 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 129 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 1232 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1755 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 303 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 25 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 47 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1709 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1475 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1475 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 106 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1454 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2091 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1718 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1718 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 289 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 33 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 17 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1698 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 48 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 661ms | Sum of p95 exceeds: 1221.8ms
Sum of all benchmark exceeds: 1882.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 24 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 15 Bytes (0%)

Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 0ab73e3 into main Jul 3, 2025
145 of 146 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2025
@Gudahtt Gudahtt deleted the chore/23528-naming-convention-v2 branch July 3, 2025 15:07
@metamaskbot metamaskbot added the release-12.23.0 Issue or pull request that will be included in release 12.23.0 label Jul 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-12.23.0 Issue or pull request that will be included in release 12.23.0 team-extension-platform Extension Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: Bump @metamask/eslint-config-typescript to latest