Skip to content

Disassembler: Print colour codes only when writing to a terminal#777

Merged
dneto0 merged 1 commit intoKhronosGroup:masterfrom
dneto0:color-only-stdout
Aug 28, 2017
Merged

Disassembler: Print colour codes only when writing to a terminal#777
dneto0 merged 1 commit intoKhronosGroup:masterfrom
dneto0:color-only-stdout

Conversation

@dneto0
Copy link
Copy Markdown
Collaborator

@dneto0 dneto0 commented Aug 28, 2017

No description provided.

// limitations under the License.

#if defined(__unix__) || (defined(__APPLE__) && defined(__MACH__))
#include <stdio.h> // Need fileno
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want, you could switch this to a CMake configuration step,
CHECK_INCLUDE_FILE(unistd.h HAS_UNISTD)
CHECK_FUNCTION_EXISTS(isatty, HAS_ISATTY)

But I don't mind this either.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know.

@dneto0 dneto0 force-pushed the color-only-stdout branch from b75d266 to 1687bd3 Compare August 28, 2017 23:15
@dneto0
Copy link
Copy Markdown
Collaborator Author

dneto0 commented Aug 28, 2017

Rebased

@dneto0 dneto0 merged commit 1687bd3 into KhronosGroup:master Aug 28, 2017
@dneto0 dneto0 changed the title vim Disassembler: Print colour codes only when writing to a terminal Disassembler: Print colour codes only when writing to a terminal Aug 29, 2017
@dneto0 dneto0 deleted the color-only-stdout branch September 1, 2017 14:13
dneto0 pushed a commit to dneto0/SPIRV-Tools that referenced this pull request Sep 14, 2024
Also updated known_failures

Roll third_party/glslang/ 3cea2e5..37fc4d2 (4 commits)

KhronosGroup/glslang@3cea2e5...37fc4d2

$ git log 3cea2e5..37fc4d2 --date=short --no-merges --format='%ad %ae %s'
2019-08-09 rharrison Make non-emscripten flags platform agnostic.
2019-08-09 rharrison Converted ENABLE_HLSL to a dependent option, so it can be always disabled in web builds
2019-08-09 rharrison Move build instructions to README.md
2019-08-08 rharrison Add WASM build target for Web version of glslang

Roll third_party/googletest/ b4961ab1c..90a443f9c (6 commits)

google/googletest@b4961ab...90a443f

$ git log b4961ab1c..90a443f9c --date=short --no-merges --format='%ad %ae %s'
2019-08-07 absl-team Googletest export
2019-08-07 absl-team Googletest export
2019-08-07 krystian.kuzniarek fix an improperly generated table
2019-08-06 krystian.kuzniarek fix broken links
2019-08-06 antoine Fix KhronosGroup#2371: Redirect Windows CRT assertions to stderr
2019-08-01 krystian.kuzniarek remove an excessive mutable type specifier

Roll third_party/spirv-tools/ 698b56a..f701237 (9 commits)

KhronosGroup/SPIRV-Tools@698b56a...f701237

$ git log 698b56a..f701237 --date=short --no-merges --format='%ad %ae %s'
2019-08-12 stevenperron Remove useless semi-colons (KhronosGroup#2789)
2019-08-09 greg Instrument: Fix version 2 output record write for tess eval shaders. (KhronosGroup#2782)
2019-08-08 stevenperron Start SPIRV-Tools v2019.5
2019-08-08 stevenperron Finalize SPIRV-Tools v2019.4
2019-08-08 stevenperron Add descriptor array scalar replacement (KhronosGroup#2742)
2019-08-08 stevenperron Update CHANGES
2019-08-08 greg Add SPV_EXT_physical_storage_buffer to opt whitelists (KhronosGroup#2779)
2019-08-07 stevenperron Handle RelaxedPrecision in SROA (KhronosGroup#2788)
2019-08-07 zoddicus Add -fextra-semi to Clang builds (KhronosGroup#2787)

Created with:
  roll-dep third_party/effcee third_party/glslang third_party/googletest third_party/re2 third_party/spirv-cross third_party/spirv-headers third_party/spirv-tools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants