Skip to content

Add descriptor array scalar replacement#2742

Merged
s-perron merged 4 commits intoKhronosGroup:masterfrom
s-perron:i2740
Aug 8, 2019
Merged

Add descriptor array scalar replacement#2742
s-perron merged 4 commits intoKhronosGroup:masterfrom
s-perron:i2740

Conversation

@s-perron
Copy link
Copy Markdown
Collaborator

Creates a pass that will replace a descriptor array with individual variables. See #2740 for details.

Fixes #2740.

@s-perron s-perron self-assigned this Jul 16, 2019
@s-perron s-perron requested review from dnovillo and ehsannas July 16, 2019 13:39
@s-perron
Copy link
Copy Markdown
Collaborator Author

@ehsannas Let me know if the will work with DXC. We should not merge until we know this will work.

@s-perron
Copy link
Copy Markdown
Collaborator Author

I still need to add tests.

@s-perron s-perron removed the request for review from dnovillo July 16, 2019 13:41
Creates a pass that will replace a descriptor array with individual variables.  See KhronosGroup#2740 for details.

Fixes KhronosGroup#2740.
Copy link
Copy Markdown
Contributor

@ehsannas ehsannas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM. PTAL @dnovillo

Copy link
Copy Markdown
Contributor

@dnovillo dnovillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this check that it has enough bindings to do the replacements?

@s-perron s-perron merged commit 4b64beb into KhronosGroup:master Aug 8, 2019
@s-perron s-perron deleted the i2740 branch September 10, 2021 20:10
dneto0 pushed a commit to dneto0/SPIRV-Tools that referenced this pull request Sep 14, 2024
Also updated known_failures

Roll third_party/glslang/ 3cea2e5..37fc4d2 (4 commits)

KhronosGroup/glslang@3cea2e5...37fc4d2

$ git log 3cea2e5..37fc4d2 --date=short --no-merges --format='%ad %ae %s'
2019-08-09 rharrison Make non-emscripten flags platform agnostic.
2019-08-09 rharrison Converted ENABLE_HLSL to a dependent option, so it can be always disabled in web builds
2019-08-09 rharrison Move build instructions to README.md
2019-08-08 rharrison Add WASM build target for Web version of glslang

Roll third_party/googletest/ b4961ab1c..90a443f9c (6 commits)

google/googletest@b4961ab...90a443f

$ git log b4961ab1c..90a443f9c --date=short --no-merges --format='%ad %ae %s'
2019-08-07 absl-team Googletest export
2019-08-07 absl-team Googletest export
2019-08-07 krystian.kuzniarek fix an improperly generated table
2019-08-06 krystian.kuzniarek fix broken links
2019-08-06 antoine Fix KhronosGroup#2371: Redirect Windows CRT assertions to stderr
2019-08-01 krystian.kuzniarek remove an excessive mutable type specifier

Roll third_party/spirv-tools/ 698b56a..f701237 (9 commits)

KhronosGroup/SPIRV-Tools@698b56a...f701237

$ git log 698b56a..f701237 --date=short --no-merges --format='%ad %ae %s'
2019-08-12 stevenperron Remove useless semi-colons (KhronosGroup#2789)
2019-08-09 greg Instrument: Fix version 2 output record write for tess eval shaders. (KhronosGroup#2782)
2019-08-08 stevenperron Start SPIRV-Tools v2019.5
2019-08-08 stevenperron Finalize SPIRV-Tools v2019.4
2019-08-08 stevenperron Add descriptor array scalar replacement (KhronosGroup#2742)
2019-08-08 stevenperron Update CHANGES
2019-08-08 greg Add SPV_EXT_physical_storage_buffer to opt whitelists (KhronosGroup#2779)
2019-08-07 stevenperron Handle RelaxedPrecision in SROA (KhronosGroup#2788)
2019-08-07 zoddicus Add -fextra-semi to Clang builds (KhronosGroup#2787)

Created with:
  roll-dep third_party/effcee third_party/glslang third_party/googletest third_party/re2 third_party/spirv-cross third_party/spirv-headers third_party/spirv-tools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scalar replacement on descriptor arrays

3 participants