Handle RelaxedPrecision in SROA#2788
Merged
s-perron merged 1 commit intoKhronosGroup:masterfrom Aug 7, 2019
Merged
Conversation
If a member of a struct has a relaxed precision, sroa will not split the struct. This means we do not get all cases. This commit handles these cases. The other part is that the decoration needs to be passed on to the new variables. Fixes KhronosGroup#2786
alan-baker
approved these changes
Aug 7, 2019
dneto0
pushed a commit
to dneto0/SPIRV-Tools
that referenced
this pull request
Sep 14, 2024
Also updated known_failures Roll third_party/glslang/ 3cea2e5..37fc4d2 (4 commits) KhronosGroup/glslang@3cea2e5...37fc4d2 $ git log 3cea2e5..37fc4d2 --date=short --no-merges --format='%ad %ae %s' 2019-08-09 rharrison Make non-emscripten flags platform agnostic. 2019-08-09 rharrison Converted ENABLE_HLSL to a dependent option, so it can be always disabled in web builds 2019-08-09 rharrison Move build instructions to README.md 2019-08-08 rharrison Add WASM build target for Web version of glslang Roll third_party/googletest/ b4961ab1c..90a443f9c (6 commits) google/googletest@b4961ab...90a443f $ git log b4961ab1c..90a443f9c --date=short --no-merges --format='%ad %ae %s' 2019-08-07 absl-team Googletest export 2019-08-07 absl-team Googletest export 2019-08-07 krystian.kuzniarek fix an improperly generated table 2019-08-06 krystian.kuzniarek fix broken links 2019-08-06 antoine Fix KhronosGroup#2371: Redirect Windows CRT assertions to stderr 2019-08-01 krystian.kuzniarek remove an excessive mutable type specifier Roll third_party/spirv-tools/ 698b56a..f701237 (9 commits) KhronosGroup/SPIRV-Tools@698b56a...f701237 $ git log 698b56a..f701237 --date=short --no-merges --format='%ad %ae %s' 2019-08-12 stevenperron Remove useless semi-colons (KhronosGroup#2789) 2019-08-09 greg Instrument: Fix version 2 output record write for tess eval shaders. (KhronosGroup#2782) 2019-08-08 stevenperron Start SPIRV-Tools v2019.5 2019-08-08 stevenperron Finalize SPIRV-Tools v2019.4 2019-08-08 stevenperron Add descriptor array scalar replacement (KhronosGroup#2742) 2019-08-08 stevenperron Update CHANGES 2019-08-08 greg Add SPV_EXT_physical_storage_buffer to opt whitelists (KhronosGroup#2779) 2019-08-07 stevenperron Handle RelaxedPrecision in SROA (KhronosGroup#2788) 2019-08-07 zoddicus Add -fextra-semi to Clang builds (KhronosGroup#2787) Created with: roll-dep third_party/effcee third_party/glslang third_party/googletest third_party/re2 third_party/spirv-cross third_party/spirv-headers third_party/spirv-tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a member of a struct has a relaxed precision, sroa will not split the
struct. This means we do not get all cases. This commit handles these
cases. The other part is that the decoration needs to be passed on to
the new variables.
Fixes #2786