Use array for clUpdateMutableCommandsKHR#245
Merged
bashbaug merged 1 commit intoKhronosGroup:mainfrom Sep 6, 2024
Merged
Conversation
EwanC
pushed a commit
to EwanC/oneapi-construction-kit
that referenced
this pull request
Jan 17, 2024
Implementation change to prototype specification changes proposed in KhronosGroup/OpenCL-Docs#1041 Uses OpenCL-Docs and OpenCL-Header changes from * KhronosGroup/OpenCL-Docs#1045 * KhronosGroup/OpenCL-Headers#245
EwanC
pushed a commit
to EwanC/OpenCL-CTS
that referenced
this pull request
Jun 19, 2024
CTS change to reflect proposed change from KhronosGroup/OpenCL-Docs#1041 Taking advantage of the extension version macros to avoid breaking existing implementations immediately. This reflects PRs: * KhronosGroup/OpenCL-Docs#1045 * KhronosGroup/OpenCL-Headers#245
EwanC
pushed a commit
to EwanC/OpenCL-CTS
that referenced
this pull request
Jun 19, 2024
CTS change to reflect proposed change from KhronosGroup/OpenCL-Docs#1041 Taking advantage of the extension version macros to avoid breaking existing implementations immediately. This reflects PRs: * KhronosGroup/OpenCL-Docs#1045 * KhronosGroup/OpenCL-Headers#245
EwanC
pushed a commit
to EwanC/oneapi-construction-kit
that referenced
this pull request
Jun 19, 2024
Implementation change to prototype specification changes proposed in KhronosGroup/OpenCL-Docs#1041 Uses OpenCL changes from * KhronosGroup/OpenCL-Docs#1045 * KhronosGroup/OpenCL-Headers#245 * KhronosGroup/OpenCL-CTS#1984
aharon-abramson
approved these changes
Jun 20, 2024
Proposal to pass the update configs to `clUpdateMutableCommandsKHR` as an array, rather than pointer changed linked list. See KhronosGroup/OpenCL-Docs#1041 for motivation and KhronosGroup/OpenCL-Docs#1045 for OpenCL-Docs PR.
EwanC
pushed a commit
to EwanC/oneapi-construction-kit
that referenced
this pull request
Jul 19, 2024
Implementation change to prototype specification changes proposed in KhronosGroup/OpenCL-Docs#1041 Uses OpenCL changes from * KhronosGroup/OpenCL-Docs#1045 * KhronosGroup/OpenCL-Headers#245 * KhronosGroup/OpenCL-CTS#1984
EwanC
pushed a commit
to EwanC/oneapi-construction-kit
that referenced
this pull request
Jul 19, 2024
Implementation change to prototype specification changes proposed in KhronosGroup/OpenCL-Docs#1041 Uses OpenCL changes from * KhronosGroup/OpenCL-Docs#1045 * KhronosGroup/OpenCL-Headers#245 * KhronosGroup/OpenCL-CTS#1984
EwanC
pushed a commit
to EwanC/oneapi-construction-kit
that referenced
this pull request
Jul 19, 2024
Implementation change to prototype specification changes proposed in KhronosGroup/OpenCL-Docs#1041 Uses OpenCL changes from * KhronosGroup/OpenCL-Docs#1045 * KhronosGroup/OpenCL-Headers#245 * KhronosGroup/OpenCL-CTS#1984
bashbaug
reviewed
Jul 30, 2024
Contributor
bashbaug
left a comment
There was a problem hiding this comment.
LGTM
Do we need to stage these changes with changes in any other repos, such as the C++ bindings (OpenCL-CLHPP) or the CTS tests?
I'll take care of updating the command buffer emulation layer.
Contributor
Author
Should probably be staged with CTS PR KhronosGroup/OpenCL-CTS#1984, I don't have a OpenCL-CLHPP PR but will look into making one there. I'm not that familiar with the C++ bindings, but I'd expect that would break without an update. Edit: created a OpenCL-CLHPP PR here will update KhronosGroup/OpenCL-CLHPP#298 |
EwanC
pushed a commit
to EwanC/OpenCL-CLHPP
that referenced
this pull request
Jul 31, 2024
In OpenCL-Docs PR KhronosGroup/OpenCL-Docs#1045 the API for `cl_khr_command_buffer_mutable_dispatch` API `clUpdateMutableCommandsKHR` changed in a breaking way. When the headers update OpenCL-Headers PR KhronosGroup/OpenCL-Headers#245 the bindings will break if they are not updated to reflect this change. Bindings updated in this PR to pass to arrays of templated length to the C++ method. The underlying `.data()` pointers of these parameters can be passed through to the OpenCL API.
EwanC
pushed a commit
to EwanC/OpenCL-CLHPP
that referenced
this pull request
Aug 1, 2024
In OpenCL-Docs PR KhronosGroup/OpenCL-Docs#1045 the API for `cl_khr_command_buffer_mutable_dispatch` API `clUpdateMutableCommandsKHR` changed in a breaking way. When the headers update OpenCL-Headers PR KhronosGroup/OpenCL-Headers#245 the bindings will break if they are not updated to reflect this change. Bindings updated in this PR to pass to arrays of templated length to the C++ method. The underlying `.data()` pointers of these parameters can be passed through to the OpenCL API.
EwanC
pushed a commit
to EwanC/OpenCL-CTS
that referenced
this pull request
Sep 5, 2024
CTS change to reflect proposed change from KhronosGroup/OpenCL-Docs#1041 Taking advantage of the extension version macros to avoid breaking existing implementations immediately. This reflects PRs: * KhronosGroup/OpenCL-Docs#1045 * KhronosGroup/OpenCL-Headers#245
bashbaug
approved these changes
Sep 6, 2024
Contributor
bashbaug
left a comment
There was a problem hiding this comment.
Merging as discussed in the September 3rd teleconference + email.
bashbaug
pushed a commit
to KhronosGroup/OpenCL-CLHPP
that referenced
this pull request
Sep 6, 2024
In OpenCL-Docs PR KhronosGroup/OpenCL-Docs#1045 the API for `cl_khr_command_buffer_mutable_dispatch` API `clUpdateMutableCommandsKHR` changed in a breaking way. When the headers update OpenCL-Headers PR KhronosGroup/OpenCL-Headers#245 the bindings will break if they are not updated to reflect this change. Bindings updated in this PR to pass to arrays of templated length to the C++ method. The underlying `.data()` pointers of these parameters can be passed through to the OpenCL API.
bashbaug
pushed a commit
to KhronosGroup/OpenCL-CTS
that referenced
this pull request
Sep 6, 2024
CTS changes to reflect the spec changes merged in KhronosGroup/OpenCL-Docs#1045 and requires header updates from KhronosGroup/OpenCL-Headers#245 Tested using OCK implementation from uxlfoundation/oneapi-construction-kit#501
EwanC
pushed a commit
to Bensuo/unified-runtime
that referenced
this pull request
Sep 16, 2024
Update OpenCL adapter code to reflect the 2 API breaking changes to the command-buffer family of extensions that have been made upstream: * [Add properties parameter to all command-buffer commands](KhronosGroup/OpenCL-Headers#260) * [Use array for clUpdateMutableCommandsKHR](KhronosGroup/OpenCL-Headers#245)
EwanC
pushed a commit
to Bensuo/unified-runtime
that referenced
this pull request
Sep 16, 2024
Update OpenCL adapter code to reflect the 2 API breaking changes to the command-buffer family of extensions that have been made upstream: * [Add properties parameter to all command-buffer commands](KhronosGroup/OpenCL-Headers#260) * [Use array for clUpdateMutableCommandsKHR](KhronosGroup/OpenCL-Headers#245)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal to pass the update configs to
clUpdateMutableCommandsKHRas an array, rather than pointer changed linked list.Generated from XML changes in KhronosGroup/OpenCL-Docs#1045
See KhronosGroup/OpenCL-Docs#1041 for motivation.
Related PRs: