Update clUpdateMutableCommandsKHR binding#298
Conversation
|
|
bashbaug
left a comment
There was a problem hiding this comment.
These changes look good, but they'll break without the corrosponding header updates. Should we use the extension versioning mechanism to either a) only expose this function when the headers are sufficiently new, or b) select between both versions, for some time at least?
In OpenCL-Docs PR KhronosGroup/OpenCL-Docs#1045 the API for `cl_khr_command_buffer_mutable_dispatch` API `clUpdateMutableCommandsKHR` changed in a breaking way. When the headers update OpenCL-Headers PR KhronosGroup/OpenCL-Headers#245 the bindings will break if they are not updated to reflect this change. Bindings updated in this PR to pass to arrays of templated length to the C++ method. The underlying `.data()` pointers of these parameters can be passed through to the OpenCL API.
I forgot to reply when I made this change, but I updated to option b) |
bashbaug
left a comment
There was a problem hiding this comment.
Merging as discussed in the September 3rd teleconference + email.
In OpenCL-Docs PR KhronosGroup/OpenCL-Docs#1045 the API for
cl_khr_command_buffer_mutable_dispatchAPIclUpdateMutableCommandsKHRchanged in a breaking way.When the headers update OpenCL-Headers PR KhronosGroup/OpenCL-Headers#245 the bindings will break if they are not updated to reflect this change.
Bindings updated in this PR to pass to arrays of templated length to the C++ method. The underlying
.data()pointers of these parameters can be passed through to the OpenCL API. I don't think any tests for this API currently exist in the repo to be updated.