Add properties parameter to all command-buffer commands#260
Merged
bashbaug merged 3 commits intoKhronosGroup:mainfrom Sep 6, 2024
Merged
Add properties parameter to all command-buffer commands#260bashbaug merged 3 commits intoKhronosGroup:mainfrom
bashbaug merged 3 commits intoKhronosGroup:mainfrom
Conversation
EwanC
pushed a commit
to EwanC/OpenCL-CLHPP
that referenced
this pull request
Aug 15, 2024
Updates to compile with header change KhronosGroup/OpenCL-Headers#260
This was referenced Aug 15, 2024
EwanC
pushed a commit
to EwanC/OpenCL-CLHPP
that referenced
this pull request
Aug 15, 2024
Updates to compile with header change KhronosGroup/OpenCL-Headers#260
EwanC
pushed a commit
to EwanC/OpenCL-CLHPP
that referenced
this pull request
Aug 15, 2024
Updates to compile with header change KhronosGroup/OpenCL-Headers#260
EwanC
pushed a commit
to EwanC/OpenCL-CTS
that referenced
this pull request
Aug 15, 2024
Make changes to reflect OpenCL-Docs change KhronosGroup/OpenCL-Docs#1215 and requires header change KhronosGroup/OpenCL-Headers#260 to use preprocessor path with extra parameters
EwanC
pushed a commit
to EwanC/OpenCL-CTS
that referenced
this pull request
Aug 15, 2024
Make changes to reflect OpenCL-Docs change KhronosGroup/OpenCL-Docs#1215 and requires header change KhronosGroup/OpenCL-Headers#260 to use preprocessor path with extra parameters
EwanC
pushed a commit
to EwanC/OpenCL-CLHPP
that referenced
this pull request
Aug 16, 2024
Updates to compile with header change KhronosGroup/OpenCL-Headers#260
EwanC
commented
Sep 5, 2024
|
|
||
|
|
||
| #define CL_KHR_COMMAND_BUFFER_MUTABLE_DISPATCH_EXTENSION_VERSION CL_MAKE_VERSION(0, 9, 1) | ||
| #define CL_KHR_COMMAND_BUFFER_MUTABLE_DISPATCH_EXTENSION_VERSION CL_MAKE_VERSION(0, 9, 3) |
Contributor
Author
There was a problem hiding this comment.
#245 needs to merge first, otherwise we bump two patch versions
added 2 commits
September 5, 2024 16:55
Header changes to reflect XML changes from KhronosGroup/OpenCL-Docs#1215 to address KhronosGroup/OpenCL-Docs#1207 A new `cl_command_properties_khr` properties parameter is added to all command recording entry-points, and the patch version is bumped.
da8dc3b to
dc2e46e
Compare
EwanC
pushed a commit
to EwanC/OpenCL-CTS
that referenced
this pull request
Sep 5, 2024
Make changes to reflect OpenCL-Docs change KhronosGroup/OpenCL-Docs#1215 and requires header change KhronosGroup/OpenCL-Headers#260 to use preprocessor path with extra parameters
bashbaug
approved these changes
Sep 6, 2024
Contributor
bashbaug
left a comment
There was a problem hiding this comment.
Merging as discussed in the September 3rd teleconference + email.
bashbaug
pushed a commit
to KhronosGroup/OpenCL-CLHPP
that referenced
this pull request
Sep 6, 2024
* Add properties parameter to all command-buffer commands Updates to compile with header change KhronosGroup/OpenCL-Headers#260 * Update to reflect CL_MUTABLE_COMMAND_PROPERTIES_ARRAY_KHR See KhronosGroup/OpenCL-Docs#1215 (comment)
EwanC
pushed a commit
to Bensuo/unified-runtime
that referenced
this pull request
Sep 16, 2024
Update OpenCL adapter code to reflect the 2 API breaking changes to the command-buffer family of extensions that have been made upstream: * [Add properties parameter to all command-buffer commands](KhronosGroup/OpenCL-Headers#260) * [Use array for clUpdateMutableCommandsKHR](KhronosGroup/OpenCL-Headers#245)
EwanC
pushed a commit
to Bensuo/unified-runtime
that referenced
this pull request
Sep 16, 2024
Update OpenCL adapter code to reflect the 2 API breaking changes to the command-buffer family of extensions that have been made upstream: * [Add properties parameter to all command-buffer commands](KhronosGroup/OpenCL-Headers#260) * [Use array for clUpdateMutableCommandsKHR](KhronosGroup/OpenCL-Headers#245)
kenba
added a commit
to kenba/opencl-sys-rs
that referenced
this pull request
Feb 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Header changes to reflect XML changes from KhronosGroup/OpenCL-Docs#1215 to address KhronosGroup/OpenCL-Docs#1207
A new
cl_command_properties_khrproperties parameter is added to all command recording entry-points, and the patch version is bumped.