Add support for the Allocs profiles produced by Julia's Allocs Profiler by NHDaly · Pull Request #46 · JuliaPerf/PProf.jl

NHDaly · 2022-01-04T02:43:44Z

Add support for the Allocs profiles produced by Julia's Allocs Profiler

Support for visualizing the results from the allocations profiler in
draft PR:
JuliaLang/julia#42768.

This was basically copy/pasted from
https://github.com/vilterp/AllocProfileParser.jl.

codecov-commenter · 2022-01-04T02:45:55Z

Codecov Report

Merging #46 (be54421) into master (eaadf51) will decrease coverage by 1.82%.
The diff coverage is 91.25%.

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
- Coverage   98.22%   96.39%   -1.83%     
==========================================
  Files           2        3       +1     
  Lines         225      305      +80     
==========================================
+ Hits          221      294      +73     
- Misses          4       11       +7

Impacted Files	Coverage Δ
src/PProf.jl	`99.19% <ø> (ø)`
src/Allocs.jl	`91.25% <91.25%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaadf51...be54421. Read the comment docs.

Support for visualizing the results from the allocations profiler in draft PR: JuliaLang/julia#42768. This was basically copy/pasted from https://github.com/vilterp/AllocProfileParser.jl.

vilterp

nice, thanks!

vilterp · 2022-01-04T20:31:26Z

src/allocs_profile.jl

+using PProf.OrderedCollections
+
+# input: e.g. "maybe_handle_const_call! at ./compiler/ssair/inlining.jl:1243"
+function parse_location(loc_str::String)


* make from_c work * skip Array constructor * Leave out the "skip Array constructor" part for now... Co-authored-by: Nathan Daly <NHDaly@gmail.com>

@Profile

## Overview Record the type and stack of every allocation (or only at a given sample interval), and return as Julia objects. Alternate approach to existing alloc profiler PR: #33467 Complementary to garbage profiler PR: #42658 (maybe there's some nice way to meld them) This may be reinventing the wheel from #33467, but I'm not sure why that one needs stuff like LLVM passes. I mimicked some stuff from it, but this was my attempt to get something up and running. Could easily be missing stuff. ## Usage: ```julia using Profile.Allocs res = Allocs.@Profile sample_rate=0.001 my_func() prof = Allocs.fetch() # do something with `prof` ``` See also: JuliaPerf/PProf.jl#46 for support for visualizing these. Co-authored-by: Nathan Daly <nhdaly@gmail.com>

vchuravy · 2022-01-21T15:29:44Z

Now that this has landed in Base we should land this

NHDaly · 2022-01-21T19:02:42Z

Agreed. Just made some fixups to the API; this is ready to go now!

alloc prof: memoize stringifying type name

vilterp

re-approving 😛 API looks good.

vilterp · 2022-01-25T17:11:00Z

test/Allocs.jl

+    outf = PProf.Allocs.pprof(out=out, web=false)
+
+    # Read the exported profile
+    prof = open(io->readproto(io, PProf.perftools.profiles.Profile()), outf, "r")


😮 what is this -> syntax??

Lambda/Closure/Anonymous Function

oh, of course 🤦‍♂️ just hadn't seen it without parens I guess

NHDaly · 2022-01-25T17:55:50Z

Cool! Thanks all - merging now

NHDaly · 2022-01-25T17:56:47Z

(leaving the branch up for anyone who had pointed their PProf at it locally)

@Profile

## Overview Record the type and stack of every allocation (or only at a given sample interval), and return as Julia objects. Alternate approach to existing alloc profiler PR: JuliaLang#33467 Complementary to garbage profiler PR: JuliaLang#42658 (maybe there's some nice way to meld them) This may be reinventing the wheel from JuliaLang#33467, but I'm not sure why that one needs stuff like LLVM passes. I mimicked some stuff from it, but this was my attempt to get something up and running. Could easily be missing stuff. ## Usage: ```julia using Profile.Allocs res = Allocs.@Profile sample_rate=0.001 my_func() prof = Allocs.fetch() # do something with `prof` ``` See also: JuliaPerf/PProf.jl#46 for support for visualizing these. Co-authored-by: Nathan Daly <nhdaly@gmail.com>

@Profile

## Overview Record the type and stack of every allocation (or only at a given sample interval), and return as Julia objects. Alternate approach to existing alloc profiler PR: JuliaLang#33467 Complementary to garbage profiler PR: JuliaLang#42658 (maybe there's some nice way to meld them) This may be reinventing the wheel from JuliaLang#33467, but I'm not sure why that one needs stuff like LLVM passes. I mimicked some stuff from it, but this was my attempt to get something up and running. Could easily be missing stuff. ## Usage: ```julia using Profile.Allocs res = Allocs.@Profile sample_rate=0.001 my_func() prof = Allocs.fetch() # do something with `prof` ``` See also: JuliaPerf/PProf.jl#46 for support for visualizing these. Co-authored-by: Nathan Daly <nhdaly@gmail.com>

NHDaly force-pushed the nhd-profile-allocs branch from f1505c4 to 8c67750 Compare January 4, 2022 02:51

Add support for the Allocs profiles produced by Julia's Allocs Profiler

a81fb68

Support for visualizing the results from the allocations profiler in draft PR: JuliaLang/julia#42768. This was basically copy/pasted from https://github.com/vilterp/AllocProfileParser.jl.

NHDaly force-pushed the nhd-profile-allocs branch from 8c67750 to a81fb68 Compare January 4, 2022 02:52

vilterp approved these changes Jan 4, 2022

View reviewed changes

vilterp mentioned this pull request Jan 4, 2022

respect from_c; skip Array constructor #47

Merged

NHDaly mentioned this pull request Jan 6, 2022

Allocation profiler JuliaLang/julia#42768

Merged

7 tasks

vilterp and others added 4 commits January 7, 2022 09:58

respect from_c; skip Array constructor (#47)

57345be

* make from_c work * skip Array constructor * Leave out the "skip Array constructor" part for now... Co-authored-by: Nathan Daly <NHDaly@gmail.com>

Remove unused old code from back when we were parsing the JSON file

4a52d7b

Merge branch 'master' into nhd-profile-allocs

d4c8794

Full method signatures and other fixes

8dc2019

NHDaly force-pushed the nhd-profile-allocs branch from 35bc257 to 8dc2019 Compare January 7, 2022 16:07

NHDaly added 6 commits January 21, 2022 13:27

Rename PProf.Allocs.pprof()

e2a8129

rename Allocs.jl file

497dd4d

Fix minimum julia version based on merge-date

ee4df2d

Add tests for PProf.Allocs.pprof(); fix typo

a73f224

Remove done todos

bd46ab3

Fix flaky test for julia nightly

df43527

NHDaly marked this pull request as ready for review January 21, 2022 19:02

vilterp and others added 2 commits January 22, 2022 00:47

opt: memoize stringifying type name

5b54ef3

Merge pull request #48 from vilterp/pv-profile-allocs-type-name-cache

be54421

alloc prof: memoize stringifying type name

vilterp approved these changes Jan 25, 2022

View reviewed changes

vilterp reviewed Jan 25, 2022

View reviewed changes

NHDaly merged commit 71dcc12 into master Jan 25, 2022

NHDaly deleted the nhd-profile-allocs branch January 25, 2022 17:56

NHDaly restored the nhd-profile-allocs branch January 25, 2022 17:56

This was referenced May 10, 2022

Improve documentation for new allocation profiler JuliaLang/julia#45268

Closed

Feature request: memory flame graphs timholy/ProfileView.jl#166

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for the Allocs profiles produced by Julia's Allocs Profiler#46

Add support for the Allocs profiles produced by Julia's Allocs Profiler#46
NHDaly merged 13 commits intomasterfrom
nhd-profile-allocs

NHDaly commented Jan 4, 2022 •

edited

Loading

Uh oh!

codecov-commenter commented Jan 4, 2022 •

edited

Loading

Uh oh!

vilterp left a comment

Uh oh!

vilterp Jan 4, 2022

Uh oh!

vchuravy commented Jan 21, 2022

Uh oh!

NHDaly commented Jan 21, 2022

Uh oh!

vilterp left a comment •

edited

Loading

Uh oh!

vilterp Jan 25, 2022

Uh oh!

vchuravy Jan 25, 2022

Uh oh!

vilterp Jan 25, 2022

Uh oh!

NHDaly commented Jan 25, 2022

Uh oh!

NHDaly commented Jan 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

NHDaly commented Jan 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Jan 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

vilterp left a comment

Choose a reason for hiding this comment

Uh oh!

vilterp Jan 4, 2022

Choose a reason for hiding this comment

Uh oh!

vchuravy commented Jan 21, 2022

Uh oh!

NHDaly commented Jan 21, 2022

Uh oh!

vilterp left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vilterp Jan 25, 2022

Choose a reason for hiding this comment

Uh oh!

vchuravy Jan 25, 2022

Choose a reason for hiding this comment

Uh oh!

vilterp Jan 25, 2022

Choose a reason for hiding this comment

Uh oh!

NHDaly commented Jan 25, 2022

Uh oh!

NHDaly commented Jan 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

NHDaly commented Jan 4, 2022 •

edited

Loading

codecov-commenter commented Jan 4, 2022 •

edited

Loading

vilterp left a comment •

edited

Loading