alloc prof: memoize stringifying type name#48
Merged
vchuravy merged 1 commit intoJuliaPerf:nhd-profile-allocsfrom Jan 23, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## nhd-profile-allocs #48 +/- ##
======================================================
+ Coverage 96.34% 96.39% +0.04%
======================================================
Files 3 3
Lines 301 305 +4
======================================================
+ Hits 290 294 +4
Misses 11 11
Continue to review full report at Codecov.
|
vchuravy
approved these changes
Jan 23, 2022
NHDaly
reviewed
Jan 25, 2022
Member
NHDaly
left a comment
There was a problem hiding this comment.
wow that's crazy. String construction is expensive! Thanks Pete - great idea 💪
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
95.639299 sec
After:
33.457880 sec
