respect from_c; skip Array constructor#47
Merged
NHDaly merged 3 commits intoJuliaPerf:nhd-profile-allocsfrom Jan 7, 2022
Merged
respect from_c; skip Array constructor#47NHDaly merged 3 commits intoJuliaPerf:nhd-profile-allocsfrom
from_c; skip Array constructor#47NHDaly merged 3 commits intoJuliaPerf:nhd-profile-allocsfrom
Conversation
from_c; skip Array constructor
NHDaly
reviewed
Jan 7, 2022
from_c; skip Array constructorfrom_c; ~skip Array constructor~
from_c; ~skip Array constructor~from_c; skip Array constructor
NHDaly
approved these changes
Jan 7, 2022
Collaborator
Author
|
Thanks, yeah the Array thing was kind of a hack. I think including type arguments is a better way to fix this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #46
Skipped Array constructor so that there are edges directly from the functions that allocate arrays to the array types.EDIT(NHD): I'm going to leave this part out for now; we can always add it back in if we can't figure out a better, more general solution