Update app action commitment, disallow signing arbitrary appActionMetadata#81
Merged
attemka merged 2 commits intoJoystream:masterfrom Mar 1, 2023
Merged
Conversation
attemka
approved these changes
Feb 28, 2023
Lezek123
pushed a commit
that referenced
this pull request
Mar 30, 2023
* App-actions functionality (#75) * add support for AppAction signatures (#51) fixes #50 * New way to generate commitment and algorithm switch (#66) * New way to generate commitment and algorithm switch * Comment update * Update secret key comments Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com> --------- Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com> --------- Co-authored-by: WRadoslaw <92513933+WRadoslaw@users.noreply.github.com> Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com> * Update app action commitment, disallow signing arbitrary appActionMetadata (#81) * Update app action commitment, disallow signing arbitrary appActionMetadata * Linter fix * Update `generateAppActionCommitment` impl. (#85) --------- Co-authored-by: attemka <attemka@gmail.com> Co-authored-by: WRadoslaw <92513933+WRadoslaw@users.noreply.github.com> Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com>
dobertRowneySr
pushed a commit
to dobertRowneySr/orion
that referenced
this pull request
Jul 3, 2023
…adata (Joystream#81) * Update app action commitment, disallow signing arbitrary appActionMetadata * Linter fix
dobertRowneySr
pushed a commit
to dobertRowneySr/orion
that referenced
this pull request
Jul 3, 2023
* App-actions functionality (Joystream#75) * add support for AppAction signatures (Joystream#51) fixes Joystream#50 * New way to generate commitment and algorithm switch (Joystream#66) * New way to generate commitment and algorithm switch * Comment update * Update secret key comments Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com> --------- Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com> --------- Co-authored-by: WRadoslaw <92513933+WRadoslaw@users.noreply.github.com> Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com> * Update app action commitment, disallow signing arbitrary appActionMetadata (Joystream#81) * Update app action commitment, disallow signing arbitrary appActionMetadata * Linter fix * Update `generateAppActionCommitment` impl. (Joystream#85) --------- Co-authored-by: attemka <attemka@gmail.com> Co-authored-by: WRadoslaw <92513933+WRadoslaw@users.noreply.github.com> Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@joystream/jsimplementationAppActionMetadata(see: Problem: How does Orion validates theAppActionMetadatainformation coming from external actors? #80)