Skip to content

New way to generate commitment and algorithm switch#66

Merged
attemka merged 3 commits intoJoystream:app-actionsfrom
WRadoslaw:feature/app-action-v2
Feb 14, 2023
Merged

New way to generate commitment and algorithm switch#66
attemka merged 3 commits intoJoystream:app-actionsfrom
WRadoslaw:feature/app-action-v2

Conversation

@WRadoslaw
Copy link
Copy Markdown
Contributor

No description provided.

@WRadoslaw WRadoslaw requested a review from Lezek123 January 31, 2023 13:10
Copy link
Copy Markdown

@Lezek123 Lezek123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com>
@attemka attemka merged commit acd9cbf into Joystream:app-actions Feb 14, 2023
attemka added a commit that referenced this pull request Feb 24, 2023
* add support for AppAction signatures (#51)

fixes #50

* New way to generate commitment and algorithm switch (#66)

* New way to generate commitment and algorithm switch

* Comment update

* Update secret key comments

Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com>

---------

Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com>

---------

Co-authored-by: WRadoslaw <92513933+WRadoslaw@users.noreply.github.com>
Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com>
Lezek123 pushed a commit that referenced this pull request Mar 30, 2023
* App-actions functionality (#75)

* add support for AppAction signatures (#51)

fixes #50

* New way to generate commitment and algorithm switch (#66)

* New way to generate commitment and algorithm switch

* Comment update

* Update secret key comments

Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com>

---------

Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com>

---------

Co-authored-by: WRadoslaw <92513933+WRadoslaw@users.noreply.github.com>
Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com>

* Update app action commitment, disallow signing arbitrary appActionMetadata (#81)

* Update app action commitment, disallow signing arbitrary appActionMetadata

* Linter fix

* Update `generateAppActionCommitment` impl. (#85)

---------

Co-authored-by: attemka <attemka@gmail.com>
Co-authored-by: WRadoslaw <92513933+WRadoslaw@users.noreply.github.com>
Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com>
dobertRowneySr pushed a commit to dobertRowneySr/orion that referenced this pull request Jul 3, 2023
* add support for AppAction signatures (Joystream#51)

fixes Joystream#50

* New way to generate commitment and algorithm switch (Joystream#66)

* New way to generate commitment and algorithm switch

* Comment update

* Update secret key comments

Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com>

---------

Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com>

---------

Co-authored-by: WRadoslaw <92513933+WRadoslaw@users.noreply.github.com>
Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com>
dobertRowneySr pushed a commit to dobertRowneySr/orion that referenced this pull request Jul 3, 2023
* App-actions functionality (Joystream#75)

* add support for AppAction signatures (Joystream#51)

fixes Joystream#50

* New way to generate commitment and algorithm switch (Joystream#66)

* New way to generate commitment and algorithm switch

* Comment update

* Update secret key comments

Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com>

---------

Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com>

---------

Co-authored-by: WRadoslaw <92513933+WRadoslaw@users.noreply.github.com>
Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com>

* Update app action commitment, disallow signing arbitrary appActionMetadata (Joystream#81)

* Update app action commitment, disallow signing arbitrary appActionMetadata

* Linter fix

* Update `generateAppActionCommitment` impl. (Joystream#85)

---------

Co-authored-by: attemka <attemka@gmail.com>
Co-authored-by: WRadoslaw <92513933+WRadoslaw@users.noreply.github.com>
Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants