Try to relocate listener binding by koppor · Pull Request #9238 · JabRef/jabref

koppor · 2022-10-10T20:11:16Z

Tries to fixes #9221

However,

the number of groups is not updated any more.
the "changed" marker is not appearing correctly any more.

Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Co-authored-by: Christoph <siedlerkiller@gmail.com> Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com> Co-authored-by: Houssem Nasri <housi.housi2015@gmail.com> Co-authored-by: ThiloteE <73715071+ThiloteE@users.noreply.github.com>

HoussemNasri · 2022-10-11T10:58:44Z

        Platform.runLater(() -> stateManager.focusOwnerProperty().bind(
                EasyBind.map(mainStage.getScene().focusOwnerProperty(), Optional::ofNullable)));

+        EasyBind.subscribe(tabbedPane.getSelectionModel().selectedItemProperty(), selectedTab -> {


Here, I used EasyBind#subscribe instead of binding because a bound value cannot be set, but I'm setting it in another place. See the other comment.

HoussemNasri · 2022-10-11T11:06:05Z

There is still an issue where the count does not update when adding empty entries. IMHO, this is not important and is out of scoop for this pr.
Current behavior:

Adding the first empty entry to a new library increases the count to one.
Adding more empty entries does not change the count; it remains at 1.
When you enter content into the entry, the count starts to update.

Siedlerchr · 2022-10-19T18:18:44Z

Does this work now or is there anything else that needs to be done/checked?

HoussemNasri · 2022-10-19T18:42:29Z

Aside from the toolbar being enabled again, I have made changes to update the entry count when a library is opened asynchronously. However, empty entries are still not counted until they are filled with data or when JabRef is restarted.

* upstream/main: (28 commits) Minor code improvements in library properties dialog (#9265) Adjust and make tests for BibTex/Biblatex/CSL mapping more accurate by adding Apa 7th edition (#9255) Removed swing from default file dir detection (#9222) Make autosave tick in shared database opening dialog active (#9258) Bump controlsfx from 11.1.1 to 11.1.2 (#9261) Bump actions/configure-pages from 1 to 2 (#9262) Bump hmarr/auto-approve-action from 2.4.0 to 3.0.0 (#9259) Bump gittools/actions from 0.9.13 to 0.9.14 (#9260) Fix for resizing cleanup entries dialog (#9240) Refresh example styles Squashed 'buildres/csl/csl-locales/' changes from cb98d36691..e243665390 Squashed 'buildres/csl/csl-styles/' changes from 7bde3e4..4eee79a Fix casing Update contributing.md Remove obsolete Jekyll howto Updates Just-the-Docs from 0.3.3 to 0.4.0.rc3 (#9249) Place subgroups w.r.t. alphabetical ordering (#9228) DOAB Fetcher now fetches ISBN and imprint fields where possible (#9229) ISSUE-9145: implement isbn fetcher (#9205) Remove explicit javafx jmod stuff (#9245) ...

* upstream/main: [WIP] Add GitHub action: Greetings.yml - Automates advice to JabRefs first time code contributors (#9272)

- I must have mistakenly changed IntelliJ code style settings

Siedlerchr · 2022-10-27T18:38:15Z

I would like to merge this as it already is a huge step forward. A Changelog entry would be needed

…ok-info.com-JabRef#9145 * upstream/main: New Crowdin updates (JabRef#9333) Refresh example styles Squashed 'buildres/csl/csl-styles/' changes from 4eee79a..13fd98e Bump unirest-java from 3.13.11 to 3.13.12 (JabRef#9330) Bump checkstyle from 10.3.4 to 10.4 (JabRef#9331) Bump gittools/actions from 0.9.14 to 0.9.15 (JabRef#9332) Group context menu presents relevant options depending on number of subgroups (JabRef#9286) Removed BibTeX file type and included HTML and Markdown types (JabRef#9318) Fix issue: Auto-linking files with safe character replacements JabRef#9267 (JabRef#9316) Fix for issue 8806: Button highlights doesn't respect rounded corners (JabRef#9320) New Crowdin updates (JabRef#9324) Update CHANGELOG.md Try to relocate listener binding (JabRef#9238) Changed the messages after importing unlinked local files to past passive tense. (JabRef#9308) Changed the color of found text from red to high contrast (JabRef#9315) # Conflicts: # CHANGELOG.md

* upstream/main: (30 commits) New translations JabRef_en.properties (German) (JabRef#9336) Fix Abbreviation for Escaped Ampersand (JabRef#9288) Fix font size preference not updating in preference dialog 8386 (JabRef#9287) New Crowdin updates (JabRef#9333) Refresh example styles Squashed 'buildres/csl/csl-styles/' changes from 4eee79a..13fd98e Bump unirest-java from 3.13.11 to 3.13.12 (JabRef#9330) Bump checkstyle from 10.3.4 to 10.4 (JabRef#9331) Bump gittools/actions from 0.9.14 to 0.9.15 (JabRef#9332) Group context menu presents relevant options depending on number of subgroups (JabRef#9286) Removed BibTeX file type and included HTML and Markdown types (JabRef#9318) Fix issue: Auto-linking files with safe character replacements JabRef#9267 (JabRef#9316) Fix for issue 8806: Button highlights doesn't respect rounded corners (JabRef#9320) New Crowdin updates (JabRef#9324) Update CHANGELOG.md Try to relocate listener binding (JabRef#9238) Changed the messages after importing unlinked local files to past passive tense. (JabRef#9308) Changed the color of found text from red to high contrast (JabRef#9315) New Crowdin updates (JabRef#9317) Add skips for MacOS X build (JabRef#9305) ...

* upstream/main: New Crowdin updates (#9333) Refresh example styles Squashed 'buildres/csl/csl-styles/' changes from 4eee79a..13fd98e Bump unirest-java from 3.13.11 to 3.13.12 (#9330) Bump checkstyle from 10.3.4 to 10.4 (#9331) Bump gittools/actions from 0.9.14 to 0.9.15 (#9332) Group context menu presents relevant options depending on number of subgroups (#9286) Removed BibTeX file type and included HTML and Markdown types (#9318) Fix issue: Auto-linking files with safe character replacements #9267 (#9316) Fix for issue 8806: Button highlights doesn't respect rounded corners (#9320) New Crowdin updates (#9324) Update CHANGELOG.md Try to relocate listener binding (#9238) Changed the messages after importing unlinked local files to past passive tense. (#9308) Changed the color of found text from red to high contrast (#9315) New Crowdin updates (#9317) Add skips for MacOS X build (#9305) New Crowdin updates (#9248) Fix for issue 9304 (#9313) # Conflicts: # CHANGELOG.md

koppor and others added 2 commits October 10, 2022 22:10

Update the side pane when a library is opened asynchronously

a8c3137

HoussemNasri reviewed Oct 11, 2022

View reviewed changes

Comment thread src/main/java/org/jabref/gui/LibraryTab.java

HoussemNasri reviewed Oct 11, 2022

View reviewed changes

ThiloteE added the component: ui label Oct 12, 2022

koppor mentioned this pull request Oct 14, 2022

Fix libraries not being remembered when an unsaved library is discarded upon closing JabRef #9250

Closed

6 tasks

Siedlerchr marked this pull request as ready for review October 21, 2022 17:31

Siedlerchr and others added 5 commits October 21, 2022 19:32

Merge remote-tracking branch 'upstream/main' into fix-9221

6774b26

* upstream/main: [WIP] Add GitHub action: Greetings.yml - Automates advice to JabRefs first time code contributors (#9272)

Add a comment

e93f932

Remove weird catch statement formatting

0bcf9e8

- I must have mistakenly changed IntelliJ code style settings

Merge remote-tracking branch 'upstream/fix-9221' into fix-9221

4791a98

Siedlerchr merged commit 25b6858 into main Oct 28, 2022

Siedlerchr deleted the fix-9221 branch October 28, 2022 19:56

Siedlerchr mentioned this pull request Dec 12, 2022

Search results dialog show an empty table of search results #9440

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Try to relocate listener binding#9238

Try to relocate listener binding#9238
Siedlerchr merged 7 commits into
mainfrom
fix-9221

koppor commented Oct 10, 2022 •

edited by Siedlerchr

Loading

Uh oh!

Uh oh!

HoussemNasri Oct 11, 2022

Uh oh!

HoussemNasri commented Oct 11, 2022

Uh oh!

Siedlerchr commented Oct 19, 2022

Uh oh!

HoussemNasri commented Oct 19, 2022

Uh oh!

Siedlerchr commented Oct 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

koppor commented Oct 10, 2022 • edited by Siedlerchr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

HoussemNasri Oct 11, 2022

Choose a reason for hiding this comment

Uh oh!

HoussemNasri commented Oct 11, 2022

Uh oh!

Siedlerchr commented Oct 19, 2022

Uh oh!

HoussemNasri commented Oct 19, 2022

Uh oh!

Siedlerchr commented Oct 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

koppor commented Oct 10, 2022 •

edited by Siedlerchr

Loading