Changed the messages after importing unlinked local files to past passive tense.#9308
Merged
Conversation
Siedlerchr
reviewed
Oct 26, 2022
|
|
||
| entriesToAdd.addAll(bibtexParserResult.getDatabaseContext().getEntries()); | ||
| addResultToList(file, false, Localization.lang("Importing bib entry")); | ||
| addResultToList(file, true, Localization.lang("Bib entry was successfully imported")); |
Member
There was a problem hiding this comment.
Is there any reason why this second value is now "true"? I am probably msissing some context here, but I was just wondering
Contributor
Author
There was a problem hiding this comment.
The icon for "successfully imported BibTex" was the red warning icon (the same as the icon for no data found). I assume it was a small bug and I changed the icon to the green check by changing the second parameter to true.
Original:
Updated:
Member
There was a problem hiding this comment.
Ah thanks a lot! Can you mention this as well in the changelog? Thanks!
Contributor
Author
There was a problem hiding this comment.
Hi @Siedlerchr, sorry I just saw your comment. Thanks for changing the CHANGELOG and approving my changes.
Siedlerchr
approved these changes
Oct 27, 2022
ThiloteE
approved these changes
Oct 28, 2022
This was referenced Oct 28, 2022
Siedlerchr
added a commit
to tomazari/jabref
that referenced
this pull request
Nov 1, 2022
…ok-info.com-JabRef#9145 * upstream/main: New Crowdin updates (JabRef#9333) Refresh example styles Squashed 'buildres/csl/csl-styles/' changes from 4eee79a..13fd98e Bump unirest-java from 3.13.11 to 3.13.12 (JabRef#9330) Bump checkstyle from 10.3.4 to 10.4 (JabRef#9331) Bump gittools/actions from 0.9.14 to 0.9.15 (JabRef#9332) Group context menu presents relevant options depending on number of subgroups (JabRef#9286) Removed BibTeX file type and included HTML and Markdown types (JabRef#9318) Fix issue: Auto-linking files with safe character replacements JabRef#9267 (JabRef#9316) Fix for issue 8806: Button highlights doesn't respect rounded corners (JabRef#9320) New Crowdin updates (JabRef#9324) Update CHANGELOG.md Try to relocate listener binding (JabRef#9238) Changed the messages after importing unlinked local files to past passive tense. (JabRef#9308) Changed the color of found text from red to high contrast (JabRef#9315) # Conflicts: # CHANGELOG.md
Siedlerchr
added a commit
to DavidOWade/jabref
that referenced
this pull request
Nov 3, 2022
* upstream/main: (30 commits) New translations JabRef_en.properties (German) (JabRef#9336) Fix Abbreviation for Escaped Ampersand (JabRef#9288) Fix font size preference not updating in preference dialog 8386 (JabRef#9287) New Crowdin updates (JabRef#9333) Refresh example styles Squashed 'buildres/csl/csl-styles/' changes from 4eee79a..13fd98e Bump unirest-java from 3.13.11 to 3.13.12 (JabRef#9330) Bump checkstyle from 10.3.4 to 10.4 (JabRef#9331) Bump gittools/actions from 0.9.14 to 0.9.15 (JabRef#9332) Group context menu presents relevant options depending on number of subgroups (JabRef#9286) Removed BibTeX file type and included HTML and Markdown types (JabRef#9318) Fix issue: Auto-linking files with safe character replacements JabRef#9267 (JabRef#9316) Fix for issue 8806: Button highlights doesn't respect rounded corners (JabRef#9320) New Crowdin updates (JabRef#9324) Update CHANGELOG.md Try to relocate listener binding (JabRef#9238) Changed the messages after importing unlinked local files to past passive tense. (JabRef#9308) Changed the color of found text from red to high contrast (JabRef#9315) New Crowdin updates (JabRef#9317) Add skips for MacOS X build (JabRef#9305) ...
Siedlerchr
added a commit
that referenced
this pull request
Nov 8, 2022
* upstream/main: New Crowdin updates (#9333) Refresh example styles Squashed 'buildres/csl/csl-styles/' changes from 4eee79a..13fd98e Bump unirest-java from 3.13.11 to 3.13.12 (#9330) Bump checkstyle from 10.3.4 to 10.4 (#9331) Bump gittools/actions from 0.9.14 to 0.9.15 (#9332) Group context menu presents relevant options depending on number of subgroups (#9286) Removed BibTeX file type and included HTML and Markdown types (#9318) Fix issue: Auto-linking files with safe character replacements #9267 (#9316) Fix for issue 8806: Button highlights doesn't respect rounded corners (#9320) New Crowdin updates (#9324) Update CHANGELOG.md Try to relocate listener binding (#9238) Changed the messages after importing unlinked local files to past passive tense. (#9308) Changed the color of found text from red to high contrast (#9315) New Crowdin updates (#9317) Add skips for MacOS X build (#9305) New Crowdin updates (#9248) Fix for issue 9304 (#9313) # Conflicts: # CHANGELOG.md
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes koppor#548
This pull request changed the messages displayed after importing local files to past passive tense to indicate completion. Below are the screenshots of the original messages.
After importing the PDF file:
After importing BibTex entry:
After creating empty entry:
The updated messages are changed to past passive tense:
New message after importing the PDF file:
New message after importing the BibTex entry (the icon was changed to "check" as well):
New messages after creating a new empty entry:
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)