Implement isbn fetcher (#9145) by ezienecker · Pull Request #9205 · JabRef/jabref

ezienecker · 2022-10-03T12:20:23Z

Implemented a new ISBN Fetcher (doi-to-bibtex-converter.herokuapp.com).

Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

ezienecker · 2022-10-03T14:12:37Z

When I run the following command "./gradlew fetcherTest" locally on the main branch I get 29 test fails. I think my gradle configuration (or something else is broken). It makes no sense to work further on this task. Therefore I close this pull request.

Siedlerchr · 2022-10-03T15:23:53Z

@ezienecker No worries, it's okay that some fetcher tests fail. Some require an API key or something else. Just make sure that your tests are working.

ezienecker · 2022-10-04T21:00:03Z

@Siedlerchr Can you please tell me where to find the codestyle file so I can fix the checkstyle?

HoussemNasri · 2022-10-06T10:48:21Z

Hi, @ezienecker. Check out this link to learn how to configure JabRef code style in your environment. Once everything is in place, your IDE will start highlighting checkstyle errors and format the code according to JabRef style.

ezienecker · 2022-10-07T09:32:46Z

@HoussemNasri Thanks for pointing that out, it worked now.

From my point of view, the feature is complete. The tests in the places in the code where I have anticipated work. I have not worked on org.jabref.logic.importer.fetcher.CrossRefTest. I don't know why the test fails.

calixtus · 2022-10-07T23:31:27Z

Thanks for your contribution. Please excuse some delays. We are these days a bit busy with our day jobs, but we promise to look into it as soon as possible.

calixtus

Looks good to me

calixtus · 2022-10-12T16:49:56Z

Thanks for your great addition to JabRef! Looking forward to see more 😄

ThiloteE · 2022-10-12T17:08:47Z

Post merger feedback:

Fixes #9145: Will close the issue automatically
[Fixes #9145](https://github.com/JabRef/jabref/issues/9145): will not close the issue automatically

See GitHub documentation: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

Linking a pull request to an issue using a keyword

You can link a pull request to an issue by using a supported keyword in the pull request's description or in a commit message. The pull request must be on the default branch.

close

closes

closed

fix

fixes

fixed

resolve

resolves

resolved

If you use a keyword to reference a pull request comment in another pull request, the pull requests will be linked. Merging the referencing pull request also closes the referenced pull request.

The syntax for closing keywords depends on whether the issue is in the same repository as the pull request.

* upstream/main: (42 commits) Place subgroups w.r.t. alphabetical ordering (#9228) DOAB Fetcher now fetches ISBN and imprint fields where possible (#9229) ISSUE-9145: implement isbn fetcher (#9205) Remove explicit javafx jmod stuff (#9245) New Crowdin updates (#9239) Support Arabic language (#9243) Process CLI arguments before starting gui (#9217) Update README Decision Records link (#9241) Opening a file removes duplicate keywords and triggers lib changed (#9216) New Crowdin updates (#9237) Add Ukrainian as language (#9236) Add ADR-0026 on using Swing's FileChooser (#9235) Log exception (#9227) Fix archunit (#9234) Bump tika-core from 2.4.1 to 2.5.0 (#9232) Check group type before showing dialog in edit group (#8909) Fix unexpected closing of preferences dialog (#9225) Fix typo in connection error message (#9226) Improve VSCode config (#9218) Searching for an entry on the web shouldn't take forever (#9199) ... # Conflicts: # build.gradle # lib/afterburner.fx.jar # src/main/java/org/jabref/cli/Launcher.java # src/main/java/org/jabref/gui/EntryTypeView.java # src/main/java/org/jabref/gui/auximport/FromAuxDialog.java # src/main/java/org/jabref/gui/bibtexextractor/ExtractBibtexDialog.java # src/main/java/org/jabref/gui/collab/ExternalChangesResolverDialog.java # src/main/java/org/jabref/gui/commonfxcontrols/CitationKeyPatternPanel.java # src/main/java/org/jabref/gui/contentselector/ContentSelectorDialogView.java # src/main/java/org/jabref/gui/customentrytypes/CustomizeEntryTypeDialogView.java # src/main/java/org/jabref/gui/documentviewer/DocumentViewerView.java # src/main/java/org/jabref/gui/edit/ManageKeywordsDialog.java # src/main/java/org/jabref/gui/entryeditor/EntryEditor.java # src/main/java/org/jabref/gui/entryeditor/fileannotationtab/FileAnnotationTabView.java # src/main/java/org/jabref/gui/errorconsole/ErrorConsoleView.java # src/main/java/org/jabref/gui/exporter/CreateModifyExporterDialogView.java # src/main/java/org/jabref/gui/externalfiles/UnlinkedFilesDialogView.java # src/main/java/org/jabref/gui/help/AboutDialogView.java # src/main/java/org/jabref/gui/importer/ImportCustomEntryTypesDialog.java # src/main/java/org/jabref/gui/importer/ImportEntriesDialog.java # src/main/java/org/jabref/gui/integrity/IntegrityCheckDialog.java # src/main/java/org/jabref/gui/libraryproperties/AbstractPropertiesTabView.java # src/main/java/org/jabref/gui/libraryproperties/LibraryPropertiesView.java # src/main/java/org/jabref/gui/libraryproperties/constants/ConstantsPropertiesView.java # src/main/java/org/jabref/gui/libraryproperties/general/GeneralPropertiesView.java # src/main/java/org/jabref/gui/libraryproperties/keypattern/KeyPatternPropertiesView.java # src/main/java/org/jabref/gui/libraryproperties/saving/SavingPropertiesView.java # src/main/java/org/jabref/gui/linkedfile/LinkedFileEditDialogView.java # src/main/java/org/jabref/gui/openoffice/ManageCitationsDialogView.java # src/main/java/org/jabref/gui/openoffice/StyleSelectDialogView.java # src/main/java/org/jabref/gui/preferences/AbstractPreferenceTabView.java # src/main/java/org/jabref/gui/preferences/PreferencesDialogView.java # src/main/java/org/jabref/gui/preferences/customexporter/CustomExporterTab.java # src/main/java/org/jabref/gui/preferences/externalfiletypes/EditExternalFileTypeEntryDialog.java # src/main/java/org/jabref/gui/preferences/journals/JournalAbbreviationsTab.java # src/main/java/org/jabref/gui/preferences/keybindings/KeyBindingsTab.java # src/main/java/org/jabref/gui/preferences/preview/PreviewTab.java # src/main/java/org/jabref/gui/preferences/protectedterms/ProtectedTermsTab.java # src/main/java/org/jabref/gui/search/GlobalSearchResultDialog.java # src/main/java/org/jabref/gui/shared/SharedDatabaseLoginDialogView.java # src/main/java/org/jabref/gui/slr/ManageStudyDefinitionView.java # src/main/java/org/jabref/gui/texparser/ParseLatexDialogView.java # src/main/java/org/jabref/gui/texparser/ParseLatexResultView.java

* upstream/main: Make autosave tick in shared database opening dialog active (#9258) Bump controlsfx from 11.1.1 to 11.1.2 (#9261) Bump actions/configure-pages from 1 to 2 (#9262) Bump hmarr/auto-approve-action from 2.4.0 to 3.0.0 (#9259) Bump gittools/actions from 0.9.13 to 0.9.14 (#9260) Fix for resizing cleanup entries dialog (#9240) Refresh example styles Squashed 'buildres/csl/csl-locales/' changes from cb98d36691..e243665390 Squashed 'buildres/csl/csl-styles/' changes from 7bde3e4..4eee79a Fix casing Update contributing.md Remove obsolete Jekyll howto Updates Just-the-Docs from 0.3.3 to 0.4.0.rc3 (#9249) Place subgroups w.r.t. alphabetical ordering (#9228) DOAB Fetcher now fetches ISBN and imprint fields where possible (#9229) ISSUE-9145: implement isbn fetcher (#9205) Remove explicit javafx jmod stuff (#9245) New Crowdin updates (#9239)

* upstream/main: (28 commits) Minor code improvements in library properties dialog (#9265) Adjust and make tests for BibTex/Biblatex/CSL mapping more accurate by adding Apa 7th edition (#9255) Removed swing from default file dir detection (#9222) Make autosave tick in shared database opening dialog active (#9258) Bump controlsfx from 11.1.1 to 11.1.2 (#9261) Bump actions/configure-pages from 1 to 2 (#9262) Bump hmarr/auto-approve-action from 2.4.0 to 3.0.0 (#9259) Bump gittools/actions from 0.9.13 to 0.9.14 (#9260) Fix for resizing cleanup entries dialog (#9240) Refresh example styles Squashed 'buildres/csl/csl-locales/' changes from cb98d36691..e243665390 Squashed 'buildres/csl/csl-styles/' changes from 7bde3e4..4eee79a Fix casing Update contributing.md Remove obsolete Jekyll howto Updates Just-the-Docs from 0.3.3 to 0.4.0.rc3 (#9249) Place subgroups w.r.t. alphabetical ordering (#9228) DOAB Fetcher now fetches ISBN and imprint fields where possible (#9229) ISSUE-9145: implement isbn fetcher (#9205) Remove explicit javafx jmod stuff (#9245) ...

koppor · 2022-12-17T22:04:03Z

We needed to disable the fetcher, because the site is down. See #9465.

koppor · 2023-10-11T10:01:40Z

@ezienecker As of today, https://doi-to-bibtex-converter.herokuapp.com shows 404. Do you have contact to that information provider?

ezienecker · 2023-10-12T06:32:11Z

@koppor no, I don't know him. I think we have to remove this feature.

koppor · 2023-10-13T11:05:42Z

@ezienecker Thank you for letting me know. We already disabled it. I had the slight hope that we could probaly resurrect the feature.

ezienecker added 2 commits October 3, 2022 14:06

ISSUE-9145: Add new ISBN fetcher doi-to-bibtex-converter.herokuapp.com

6705427

ISSUE-9145: Refactor IsbnFetcher to support multiple retry isbn fetcher

c00ff96

ezienecker closed this Oct 3, 2022

Siedlerchr reopened this Oct 3, 2022

ISSUE-262: Fix checkstyle issues

eae6519

ezienecker force-pushed the feature/implement-isbn-fetcher-issue-9145 branch from e419c81 to eae6519 Compare October 7, 2022 08:46

ISSUE-2: Fix error handling in ISBN Fetcher and fix unit tests

ba6ad09

calixtus added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 7, 2022

ThiloteE added the component: fetcher label Oct 9, 2022

calixtus added 2 commits October 10, 2022 23:21

Update IsbnFetcher.java

9c8ba14

Update DoiToBibtexConverterComIsbnFetcher.java

54bf4ae

calixtus reviewed Oct 10, 2022

View reviewed changes

calixtus requested a review from Siedlerchr October 10, 2022 21:25

Merge branch 'main' into feature/implement-isbn-fetcher-issue-9145

706ada5

Siedlerchr approved these changes Oct 12, 2022

View reviewed changes

calixtus merged commit 5f7aa46 into JabRef:main Oct 12, 2022

calixtus changed the title ~~ISSUE-9145: implement isbn fetcher~~ Implement isbn fetcher (#9145) Oct 12, 2022

Siedlerchr mentioned this pull request Oct 15, 2022

ISBN fetcher: OttoBib is no longer operational #9254

Closed

2 tasks

Uh oh!

Conversation

ezienecker commented Oct 3, 2022 • edited by ThiloteE Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ezienecker commented Oct 3, 2022

Uh oh!

Siedlerchr commented Oct 3, 2022

Uh oh!

ezienecker commented Oct 4, 2022

Uh oh!

HoussemNasri commented Oct 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ezienecker commented Oct 7, 2022

Uh oh!

calixtus commented Oct 7, 2022

Uh oh!

calixtus left a comment

Choose a reason for hiding this comment

Uh oh!

calixtus commented Oct 12, 2022

Uh oh!

ThiloteE commented Oct 12, 2022

Linking a pull request to an issue using a keyword

Uh oh!

koppor commented Dec 17, 2022

Uh oh!

koppor commented Oct 11, 2023

Uh oh!

ezienecker commented Oct 12, 2023

Uh oh!

koppor commented Oct 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ezienecker commented Oct 3, 2022 •

edited by ThiloteE

Loading

HoussemNasri commented Oct 6, 2022 •

edited

Loading