Remove local jgoodies dependency#62
Merged
Merged
Conversation
simonharrer
added a commit
that referenced
this pull request
Jul 21, 2015
Remove local jgoodies dependency
renovate-bot
pushed a commit
to renovate-bot/JabRef-_-jabref
that referenced
this pull request
May 14, 2026
* feat: JabRef#3 add required functionality to bookCoverFetcher (JabRef#8) * feat: add a test for requirement RE02 (JabRef#28) * feat: add a test for requirement RE02 I also had to change the access modifier to `protected` for one download function. Additionally, I refactored the download method a bit, in order to mock at test it more easily. * fix: cleanup imports * feat: JabRef#4 add background download and refresh when opening preview (JabRef#21) * feat: JabRef#34 add missing space and fixed style (JabRef#35) * feat: JabRef#22 add test for requirement RE03 (JabRef#23) * changed comments to markdown (JabRef#44) Co-authored-by: Melker Trané <melkert@kth.se> * feat: JabRef#52 add new test and created setUp and tearDown (JabRef#53) * feat: JabRef#13 add test for retrieving cover from empty directory (JabRef#51) * feat: JabRef#54 add more tests and change modifiers (JabRef#57) * fix: JabRef#43 change variable names to make their type clear (JabRef#59) * made tests more uniform and made originally private methods private agai (JabRef#62) Co-authored-by: Melker Trané <melkert@kth.se> * docs: JabRef#64 added change to changelog (JabRef#66) * almost done * fixed comments * removed line for debugging * fixed typo * added static back * changed !isEmpty to isPresent --------- Co-authored-by: SkitArgDuva <117955752+SkitArgDuva@users.noreply.github.com> Co-authored-by: Melker Trané <melkert@kth.se>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request replaces two classes that were contained in a local self-made jgoodies dependency. Thereby, the local dependency can be deleted.
SimpleInternalFrameis replaced byJXTitledPanelfrom the swingx project (This adds a new dependency from maven)UIFSplitPaneis replaced by the standard swingJSplitPane. This is just one step up in the inheritence hierarchy. As far as I can see, there is no visual difference in the result.