Solve the bug '1248 Key bindings not modified'#35
Closed
alauber wants to merge 3 commits into
Closed
Conversation
…tified que the creation of the hashmap list 'defKeyBinds' that sets the standard keyboard shortcuts , the feature 'Open folder' was not included in the 'defineDefaultKeyBindings ( )' method in 'JabRefPreferences' class .
…was Identified que the creation of the hashmap list 'defKeyBinds' that sets the standard keyboard shortcuts , the feature 'Open folder' was not included in the 'defineDefaultKeyBindings ( )' method in 'JabRefPreferences' class ." This reverts commit 8e46928.
Member
|
Thanks for the PR. Please add yourself to About.html as described in CONTRIBUTING.MD |
Member
|
I would also prefer not to include the first two commits (8e46928 and 1e1ca6). Or are they interesting for guys working on the issue? |
Member
|
Nope. It is ok to not include the first two commits Oliver |
Member
|
I cherry-picked the last commit which converted to commit 522d8e4 |
InAnYan
added a commit
that referenced
this pull request
Jun 26, 2024
renovate-bot
pushed a commit
to renovate-bot/JabRef-_-jabref
that referenced
this pull request
May 14, 2026
* feat: JabRef#3 add required functionality to bookCoverFetcher (JabRef#8) * feat: add a test for requirement RE02 (JabRef#28) * feat: add a test for requirement RE02 I also had to change the access modifier to `protected` for one download function. Additionally, I refactored the download method a bit, in order to mock at test it more easily. * fix: cleanup imports * feat: JabRef#4 add background download and refresh when opening preview (JabRef#21) * feat: JabRef#34 add missing space and fixed style (JabRef#35) * feat: JabRef#22 add test for requirement RE03 (JabRef#23) * changed comments to markdown (JabRef#44) Co-authored-by: Melker Trané <melkert@kth.se> * feat: JabRef#52 add new test and created setUp and tearDown (JabRef#53) * feat: JabRef#13 add test for retrieving cover from empty directory (JabRef#51) * feat: JabRef#54 add more tests and change modifiers (JabRef#57) * fix: JabRef#43 change variable names to make their type clear (JabRef#59) * made tests more uniform and made originally private methods private agai (JabRef#62) Co-authored-by: Melker Trané <melkert@kth.se> * docs: JabRef#64 added change to changelog (JabRef#66) * almost done * fixed comments * removed line for debugging * fixed typo * added static back * changed !isEmpty to isPresent --------- Co-authored-by: SkitArgDuva <117955752+SkitArgDuva@users.noreply.github.com> Co-authored-by: Melker Trané <melkert@kth.se>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After checking the bug '1248 Key bindings not modified', it was Identified que the creation of the hashmap list 'defKeyBinds' that sets the standard keyboard shortcuts, the feature 'Open folder' was not included in the 'defineDefaultKeyBindings ( )' method in 'JabRefPreferences' class .
In the creation of the menu item in the 'JabRefFrame' class for the item 'Open folder', it was not possible to recover the value of the item in the list 'defKeyBinds', occurring error 'NullPointerException' in the 'String makeEscape (String s) 'method in 'JabRefPreferences' class, which shouldnt return the value of 'String' to fill out the menu item.
When the 'User' tried to change and save the list, the error 'NullPointerException' not allow the execution of the procedure.
To solve the bug , was included in the verification of the presence of null in 'keyBinds' list (copy of 'defKeyBinds'), the value 'Not associated' being passed to the 'String' return.
The warning that menu feature is created in the 'JabRefFrame' class without associated keyboard shortcut, was moved to the method mentioned before, as was duplicated.