Skip to content

Update to UI: Remove some borders#43

Closed
tobiasdiez wants to merge 2 commits into
JabRef:masterfrom
tobiasdiez:ui2
Closed

Update to UI: Remove some borders#43
tobiasdiez wants to merge 2 commits into
JabRef:masterfrom
tobiasdiez:ui2

Conversation

@tobiasdiez

Copy link
Copy Markdown
Member

I tried to remove some 'clutter' in the UI by removing the gridlines and a few borders.
Before:
before
After:
after

@ThomasA

ThomasA commented May 11, 2015

Copy link
Copy Markdown
Member

I am not immediately convinced that this a good idea. I am afraid that it makes it harder to align various fields of each entry visually when looking over a large database.

@hakova

hakova commented May 11, 2015

Copy link
Copy Markdown
Contributor

Agreed with Thomas. Although it looks cleaner, for those of us who have
older eyes, it may get a little tricky not having the gridlines.

2015-05-11 12:57 GMT-05:00 Thomas Arildsen notifications@github.com:

I am not immediately convinced that this a good idea. I am afraid that it
makes it harder to align various fields of each entry visually when looking
over a large database.


Reply to this email directly or view it on GitHub
#43 (comment).

@igorsteinmacher

Copy link
Copy Markdown
Member

Is there a way to make is as an option in Preferences?

Igor Fabio Steinmacher, Ph.D.
Professor in Dept. of Computing at Universidade Tecnológica Federal do
Paraná

On Mon, May 11, 2015 at 3:01 PM, hakova notifications@github.com wrote:

Agreed with Thomas. Although it looks cleaner, for those of us who have
older eyes, it may get a little tricky not having the gridlines.

2015-05-11 12:57 GMT-05:00 Thomas Arildsen notifications@github.com:

I am not immediately convinced that this a good idea. I am afraid that it
makes it harder to align various fields of each entry visually when
looking
over a large database.


Reply to this email directly or view it on GitHub
#43 (comment).


Reply to this email directly or view it on GitHub
#43 (comment).

@mlep

mlep commented May 11, 2015

Copy link
Copy Markdown
Contributor

I had the same filling.
What about a gray strip every five entries?
(see attached file)

Frédéric

Le 11/05/2015 19:57, Thomas Arildsen a écrit :

I am not immediately convinced that this a good idea. I am afraid that
it makes it harder to align various fields of each entry visually when
looking over a large database.


Reply to this email directly or view it on GitHub
#43 (comment).

.......................................................
UR Science du Sol
INRA
2163 Avenue de la Pomme de Pin
CS 40001 - Ardon
F-45075 Orléans Cedex 2
France
Ph: +33 2 38 41 48 23
Fax: +33 2 38 41 78 69
Email: Frederic.Darboux@orleans.inra.fr
WebPage: http://huit.re/DarbouxInraEn
Lab.: http://www6.val-de-loire.inra.fr/ur-sols/

@ThomasA

ThomasA commented May 11, 2015

Copy link
Copy Markdown
Member

I think it's a fine idea of it can be toggled in the preferences.

Sent from my Android device with K-9 Mail. Please excuse my brevity.

@tobiasdiez

Copy link
Copy Markdown
Member Author

Ok, I will add an option to toggle the gridlines on and off. Originally, I also planned to add alternating background colors to better distinguish between rows. However, since JabRef also allows for marking entries, I doubt that this is a good approach.

@ThomasA

ThomasA commented May 11, 2015

Copy link
Copy Markdown
Member

I think you're right about the background colours. It could easily collide with marked entries.

Sent from my Android device with K-9 Mail. Please excuse my brevity.

@mlep

mlep commented May 11, 2015

Copy link
Copy Markdown
Contributor

Also I am not a Java programmer (and may be because I am not...), I
believe it may not be difficult to add some gray to every five lines to
whatever is the color of the background (while, yellow, orange, red).

Frédéric

Le 11/05/2015 21:35, Tobias Diez a écrit :

Ok, I will add an option to toggle the gridlines on and off. Originally,
I also planned to add alternating background colors to better
distinguish between rows. However, since JabRef also allows for marking
entries, I doubt that this is a good approach.


Reply to this email directly or view it on GitHub
#43 (comment).

.......................................................
UR Science du Sol
INRA
2163 Avenue de la Pomme de Pin
CS 40001 - Ardon
F-45075 Orléans Cedex 2
France
Ph: +33 2 38 41 48 23
Fax: +33 2 38 41 78 69
Email: Frederic.Darboux@orleans.inra.fr
WebPage: http://huit.re/DarbouxInraEn
Lab.: http://www6.val-de-loire.inra.fr/ur-sols/

@tobiasdiez

Copy link
Copy Markdown
Member Author

I added an option (under 'Appearance') to re-enable the gridlines. Moreover, it is now possible to change the row height.

@tobiasdiez tobiasdiez closed this May 16, 2015
@tobiasdiez tobiasdiez deleted the ui2 branch November 7, 2015 14:07
renovate-bot pushed a commit to renovate-bot/JabRef-_-jabref that referenced this pull request May 14, 2026
* feat: JabRef#3 add required functionality to bookCoverFetcher (JabRef#8)

* feat: add a test for requirement RE02 (JabRef#28)

* feat: add a test for requirement RE02

I also had to change the access modifier to `protected` for one download
function. Additionally, I refactored the download method a bit, in order
to mock at test it more easily.

* fix: cleanup imports

* feat: JabRef#4 add background download and refresh when opening preview (JabRef#21)

* feat: JabRef#34 add missing space and fixed style (JabRef#35)

* feat: JabRef#22 add test for requirement RE03 (JabRef#23)

* changed comments to markdown (JabRef#44)

Co-authored-by: Melker Trané <melkert@kth.se>

* feat: JabRef#52 add new test and created setUp and tearDown (JabRef#53)

* feat: JabRef#13 add test for retrieving cover from empty directory (JabRef#51)

* feat: JabRef#54 add more tests and change modifiers (JabRef#57)

* fix: JabRef#43 change variable names to make their type clear (JabRef#59)

* made tests more uniform and made originally private methods private agai (JabRef#62)

Co-authored-by: Melker Trané <melkert@kth.se>

* docs: JabRef#64 added change to changelog (JabRef#66)

* almost done

* fixed comments

* removed line for debugging

* fixed typo

* added static back

* changed !isEmpty to isPresent

---------

Co-authored-by: SkitArgDuva <117955752+SkitArgDuva@users.noreply.github.com>
Co-authored-by: Melker Trané <melkert@kth.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants