Skip to content

Disable search when no library is opened#5923

Merged
Siedlerchr merged 1 commit into
masterfrom
fixSearch
Feb 10, 2020
Merged

Disable search when no library is opened#5923
Siedlerchr merged 1 commit into
masterfrom
fixSearch

Conversation

@Siedlerchr

@Siedlerchr Siedlerchr commented Feb 8, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

and Fix exception when getSearchResultSize returned null

I found this wile trying to reproduce
Hopefully Fixes #5897
and fixes #5821

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for bigger UI changes)
  • Checked documentation: Is the information available and up to date? If not: Issue created at https://github.com/JabRef/user-documentation/issues.

@Siedlerchr
Disable search when no library is opened
dea1da5 
Fix exception when getSearchResultSize returned null
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 8, 2020
tobiasdiez
tobiasdiez approved these changes Feb 9, 2020
View reviewed changes

@tobiasdiez tobiasdiez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Siedlerchr Siedlerchr merged commit f8dbac6 into master Feb 10, 2020
@Siedlerchr Siedlerchr deleted the fixSearch branch February 10, 2020 20:18
@wujastyk

wujastyk commented Feb 10, 2020

Copy link
Copy Markdown

JabRef 5.0-beta.409--2020-02-09--6a9c915
Linux 5.3.0-28-generic amd64
Java 13.0.2

  1. close all libraries
  2. type abc in search box
  3. multiple "uncaught exception" error messages pop up.

image

java.lang.NullPointerException
	at org.jabref/org.jabref.gui.search.GlobalSearchBar.lambda$new$10(Unknown Source)
	at java.base/java.util.Optional.ifPresent(Unknown Source)
	at org.jabref/org.jabref.gui.search.GlobalSearchBar.lambda$new$11(Unknown Source)
	at org.jabref.merged.module/org.fxmisc.easybind.EasyBind.lambda$subscribe$12(Unknown Source)
	at org.jabref.merged.module/com.sun.javafx.binding.ExpressionHelper$Generic.fireValueChangedEvent(Unknown Source)
	at org.jabref.merged.module/com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(Unknown Source)
	at org.jabref.merged.module/javafx.beans.property.ObjectPropertyBase.fireValueChangedEvent(Unknown Source)
	at org.jabref.merged.module/javafx.beans.property.ObjectPropertyBase.markInvalid(Unknown Source)
	at org.jabref.merged.module/javafx.beans.property.ObjectPropertyBase.set(Unknown Source)
	at org.jabref.merged.module/javafx.beans.property.ObjectProperty.setValue(Unknown Source)
	at org.jabref/org.jabref.gui.StateManager.setSearchQuery(Unknown Source)
	at org.jabref/org.jabref.gui.search.GlobalSearchBar.performSearch(Unknown Source)
	at org.jabref.merged.module/org.reactfx.util.FxTimer.lambda$restart$0(Unknown Source)
	at org.jabref.merged.module/com.sun.scenario.animation.shared.TimelineClipCore.visitKeyFrame(Unknown Source)
	at org.jabref.merged.module/com.sun.scenario.animation.shared.TimelineClipCore.playTo(Unknown Source)
	at org.jabref.merged.module/javafx.animation.Timeline.doPlayTo(Unknown Source)
	at org.jabref.merged.module/javafx.animation.AnimationAccessorImpl.playTo(Unknown Source)
	at org.jabref.merged.module/com.sun.scenario.animation.shared.SingleLoopClipEnvelope.timePulse(Unknown Source)
	at org.jabref.merged.module/javafx.animation.Animation.doTimePulse(Unknown Source)
	at org.jabref.merged.module/javafx.animation.Animation$1.lambda$timePulse$0(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at org.jabref.merged.module/javafx.animation.Animation$1.timePulse(Unknown Source)
	at org.jabref.merged.module/com.sun.scenario.animation.AbstractMasterTimer.timePulseImpl(Unknown Source)
	at org.jabref.merged.module/com.sun.scenario.animation.AbstractMasterTimer$MainLoop.run(Unknown Source)
	at org.jabref.merged.module/com.sun.javafx.tk.quantum.QuantumToolkit.pulse(Unknown Source)
	at org.jabref.merged.module/com.sun.javafx.tk.quantum.QuantumToolkit.pulse(Unknown Source)
	at org.jabref.merged.module/com.sun.javafx.tk.quantum.QuantumToolkit.pulseFromQueue(Unknown Source)
	at org.jabref.merged.module/com.sun.javafx.tk.quantum.QuantumToolkit.lambda$runToolkit$11(Unknown Source)
	at org.jabref.merged.module/com.sun.glass.ui.InvokeLaterDispatcher$Future.run(Unknown Source)
	at org.jabref.merged.module/com.sun.glass.ui.gtk.GtkApplication.enterNestedEventLoopImpl(Native Method)
	at org.jabref.merged.module/com.sun.glass.ui.gtk.GtkApplication._enterNestedEventLoop(Unknown Source)
	at org.jabref.merged.module/com.sun.glass.ui.Application.enterNestedEventLoop(Unknown Source)
	at org.jabref.merged.module/com.sun.glass.ui.EventLoop.enter(Unknown Source)
	at org.jabref.merged.module/com.sun.javafx.tk.quantum.QuantumToolkit.enterNestedEventLoop(Unknown Source)
	at org.jabref.merged.module/javafx.stage.Stage.showAndWait(Unknown Source)
	at org.jabref.merged.module/javafx.scene.control.HeavyweightDialog.showAndWait(Unknown Source)
	at org.jabref.merged.module/javafx.scene.control.Dialog.showAndWait(Unknown Source)
	at org.jabref/org.jabref.gui.JabRefDialogService.showErrorDialogAndWait(Unknown Source)
	at org.jabref/org.jabref.FallbackExceptionHandler.lambda$uncaughtException$0(Unknown Source)
	at org.jabref.merged.module/com.sun.javafx.application.PlatformImpl.lambda$runLater$10(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at org.jabref.merged.module/com.sun.javafx.application.PlatformImpl.lambda$runLater$11(Unknown Source)
	at org.jabref.merged.module/com.sun.glass.ui.InvokeLaterDispatcher$Future.run(Unknown Source)
	at org.jabref.merged.module/com.sun.glass.ui.gtk.GtkApplication.enterNestedEventLoopImpl(Native Method)
	at org.jabref.merged.module/com.sun.glass.ui.gtk.GtkApplication._enterNestedEventLoop(Unknown Source)
	at org.jabref.merged.module/com.sun.glass.ui.Application.enterNestedEventLoop(Unknown Source)
	at org.jabref.merged.module/com.sun.glass.ui.EventLoop.enter(Unknown Source)
	at org.jabref.merged.module/com.sun.javafx.tk.quantum.QuantumToolkit.enterNestedEventLoop(Unknown Source)
	at org.jabref.merged.module/javafx.stage.Stage.showAndWait(Unknown Source)
	at org.jabref.merged.module/javafx.scene.control.HeavyweightDialog.showAndWait(Unknown Source)
	at org.jabref.merged.module/javafx.scene.control.Dialog.showAndWait(Unknown Source)
	at org.jabref/org.jabref.gui.JabRefDialogService.showErrorDialogAndWait(Unknown Source)
	at org.jabref/org.jabref.FallbackExceptionHandler.lambda$uncaughtException$0(Unknown Source)
	at org.jabref.merged.module/com.sun.javafx.application.PlatformImpl.lambda$runLater$10(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at org.jabref.merged.module/com.sun.javafx.application.PlatformImpl.lambda$runLater$11(Unknown Source)
	at org.jabref.merged.module/com.sun.glass.ui.InvokeLaterDispatcher$Future.run(Unknown Source)
	at org.jabref.merged.module/com.sun.glass.ui.gtk.GtkApplication.enterNestedEventLoopImpl(Native Method)
	at org.jabref.merged.module/com.sun.glass.ui.gtk.GtkApplication._enterNestedEventLoop(Unknown Source)
	at org.jabref.merged.module/com.sun.glass.ui.Application.enterNestedEventLoop(Unknown Source)
	at org.jabref.merged.module/com.sun.glass.ui.EventLoop.enter(Unknown Source)
	at org.jabref.merged.module/com.sun.javafx.tk.quantum.QuantumToolkit.enterNestedEventLoop(Unknown Source)
	at org.jabref.merged.module/javafx.stage.Stage.showAndWait(Unknown Source)
	at org.jabref.merged.module/javafx.scene.control.HeavyweightDialog.showAndWait(Unknown Source)
	at org.jabref.merged.module/javafx.scene.control.Dialog.showAndWait(Unknown Source)
	at org.jabref/org.jabref.gui.JabRefDialogService.showErrorDialogAndWait(Unknown Source)
	at org.jabref/org.jabref.FallbackExceptionHandler.lambda$uncaughtException$0(Unknown Source)
	at org.jabref.merged.module/com.sun.javafx.application.PlatformImpl.lambda$runLater$10(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at org.jabref.merged.module/com.sun.javafx.application.PlatformImpl.lambda$runLater$11(Unknown Source)
	at org.jabref.merged.module/com.sun.glass.ui.InvokeLaterDispatcher$Future.run(Unknown Source)
	at org.jabref.merged.module/com.sun.glass.ui.gtk.GtkApplication._runLoop(Native Method)
	at org.jabref.merged.module/com.sun.glass.ui.gtk.GtkApplication.lambda$runLoop$11(Unknown Source)
	at java.base/java.lang.Thread.run(Unknown Source)

@Siedlerchr

Siedlerchr commented Feb 10, 2020

Copy link
Copy Markdown
Member Author

Seems like you still have an old version from yesterday. This is fixed in today's version.

@wujastyk

wujastyk commented Feb 11, 2020

Copy link
Copy Markdown

I hope so! The version of 10 Feb isn't downloadable yet. I'll report back when I've tried it.

@Siedlerchr

Siedlerchr commented Feb 11, 2020

Copy link
Copy Markdown
Member Author

@wujastyk Unfortunately we currently have no space left on our build server. However, you can download a version from here https://github.com/JabRef/jabref/actions/runs/37249397

Siedlerchr added a commit that referenced this pull request Mar 6, 2020
@Siedlerchr
Merge remote-tracking branch 'upstream/master'
8bf0c77 
* upstream/master:
  Bump unirest-java from 3.4.01 to 3.4.03 (#5932)
  Bump postgresql from 42.2.9 to 42.2.10 (#5930)
  Bump archunit-junit5-api from 0.13.0 to 0.13.1 (#5928)
  Bump classgraph from 4.8.60 to 4.8.62 (#5927)
  Bump commons-csv from 1.7 to 1.8 (#5929)
  Bump jsoup from 1.12.1 to 1.12.2 (#5931)
  Disable search when no library is opened (#5923)
  Fix maintable not updated when changing entry type (#5925)
koppor pushed a commit that referenced this pull request Mar 1, 2022
Squashed 'buildres/csl/csl-styles/' changes from eb97405..8f69d4e
927b7e7 
8f69d4e Container-title text-case set to title (#5931)
7200616 Create arrbhousestyle.csl (#5674)
8933609 Create hospital-a-domicilio.csl (#5924)
622bf63 Create international-journal-of-cosmetic-science.csl (#5886)
07e179f remove default-locale journal-de-la-societe-des-oceanistes.csl (#5887)
4435d1e update norsk-henvisningsstandard-for-rettsvitenskapelige-tekster.csl (#5892)
18e547f Added fixes for steel-research-international.csl (#5921)
79e53a2 Update springer-basic-brackets-no-et-al.csl (#5925)
e4f411f Update antiquites-africaines.csl (#5923)
f4b3830 Create hemijska-industrija.csl (#5881)
1b33712 Create dhd.csl (#5920)
8462846 Update China national standard GB/T 7714 styles (#5860)
2c298be ISO formatted dates in sodertorns hogskola citation styles (#5882)
1114ec2 Update sodertorns-hogskola-oxford.csl (#5865)
20c439b Create boletin-de-la-sociedad-geologica-mexicana.csl (#5841)
e02b500 Create jurisprudence.csl (#5856)
a860c30 Update organization-studies.csl (#5914)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 8f69d4e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasdiez tobiasdiez tobiasdiez approved these changes

Assignees

No one assigned

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uncaught exception in search Jabref5 Portable Linux

3 participants

@Siedlerchr @wujastyk @tobiasdiez