Skip to content

[WIP] Fix fetcher tests#5674

Merged
Siedlerchr merged 13 commits into
masterfrom
fix+fetchertest
Nov 29, 2019
Merged

[WIP] Fix fetcher tests#5674
Siedlerchr merged 13 commits into
masterfrom
fix+fetchertest

Conversation

@Siedlerchr

@Siedlerchr Siedlerchr commented Nov 26, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Fix some wrong data
Fix help pages
Use jsoup for parsing pre content in inspire fetcher

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for bigger UI changes)
  • Checked documentation: Is the information available and up to date? If not: Issue created at https://github.com/JabRef/user-documentation/issues.

@Siedlerchr
[WIP] Fix fetcher tests
a6029c9 
Fix some wrong data
Fix help pages
Use jsoup for parsing pre content in inspire fetcher
TODO: Find out why the bibtex parser does not work for the second and third returned entry
koppor
koppor reviewed Nov 27, 2019
View reviewed changes
Comment thread src/test/java/org/jabref/logic/importer/fetcher/TitleFetcherTest.java
@@ -44,7 +44,7 @@ public void testGetName() {

@Test

@koppor koppor Nov 27, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be OK for me to remove these kind of tests completely. Think, the have been introduced in 2015 by students to increase test coverage.

LinusDietz
LinusDietz approved these changes Nov 29, 2019
View reviewed changes

@LinusDietz LinusDietz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to be good

@Siedlerchr

Siedlerchr commented Nov 29, 2019

Copy link
Copy Markdown
Member Author

Nope, still some failing ones. https://travis-ci.org/JabRef/jabref/jobs/618489482?utm_medium=notification&utm_source=github_status

@Siedlerchr

Siedlerchr commented Nov 29, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

I don't understand why the equals is failing: I don't see a differencec

Edit: Debugging showed that PRIMARYCLASS is a standardfield argh!

org.opentest4j.AssertionFailedError: iterable contents differ at index [0], expected: 
org.jabref.model.entry.BibEntry@44a085e5<@phdthesis{Diez:2019pkg,
  archiveprefix = {arXiv},
  author = {Diez, Tobias},
  eprint = {1909.00744},
  primaryclass = {math.SG},
  reportnumber = {urn:nbn:de:bsz:15-qucosa2-352179},
  title = {Normal Form of Equivariant Maps and Singular Symplectic Reduction in Infinite Dimensions with Applications to Gauge Field Theory},
  year = {2019}
}> but was: org.jabref.model.entry.BibEntry@1a3e8e24<@phdthesis{Diez:2019pkg,
  archiveprefix = {arXiv},
  author = {Diez, Tobias},
  eprint = {1909.00744},
  primaryclass = {math.SG},
  reportnumber = {urn:nbn:de:bsz:15-qucosa2-352179},
  title = {Normal Form of Equivariant Maps and Singular Symplectic Reduction in Infinite Dimensions with Applications to Gauge Field Theory},
  year = {2019}
}>

tobiasdiez
tobiasdiez approved these changes Nov 29, 2019
View reviewed changes

@tobiasdiez tobiasdiez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we merge this now so that the changes to the actual fetcher are still included in the 5.0 beta release?

@Siedlerchr

Siedlerchr commented Nov 29, 2019

Copy link
Copy Markdown
Member Author

Yes, most things should be fixed. I will continue after the merge.

@Siedlerchr

Siedlerchr commented Nov 29, 2019

Copy link
Copy Markdown
Member Author

I will just fix the ACS test then we can merge, the fetcher is broken

@Siedlerchr
fix acs fetcher
99f9d48
@Siedlerchr
Merge branch 'fix+fetchertest' of github.com:JabRef/jabref into fix+f…
3dc3aff 
…etchertest

* 'fix+fetchertest' of github.com:JabRef/jabref:
  Update INSPIREFetcherTest.java
  Update GoogleScholarTest.java
@Siedlerchr
fix help pag test
609b60c
@Siedlerchr Siedlerchr merged commit f9cf996 into master Nov 29, 2019
@Siedlerchr Siedlerchr deleted the fix+fetchertest branch November 29, 2019 15:42
koppor pushed a commit that referenced this pull request Mar 1, 2022
Squashed 'buildres/csl/csl-styles/' changes from eb97405..8f69d4e
927b7e7 
8f69d4e Container-title text-case set to title (#5931)
7200616 Create arrbhousestyle.csl (#5674)
8933609 Create hospital-a-domicilio.csl (#5924)
622bf63 Create international-journal-of-cosmetic-science.csl (#5886)
07e179f remove default-locale journal-de-la-societe-des-oceanistes.csl (#5887)
4435d1e update norsk-henvisningsstandard-for-rettsvitenskapelige-tekster.csl (#5892)
18e547f Added fixes for steel-research-international.csl (#5921)
79e53a2 Update springer-basic-brackets-no-et-al.csl (#5925)
e4f411f Update antiquites-africaines.csl (#5923)
f4b3830 Create hemijska-industrija.csl (#5881)
1b33712 Create dhd.csl (#5920)
8462846 Update China national standard GB/T 7714 styles (#5860)
2c298be ISO formatted dates in sodertorns hogskola citation styles (#5882)
1114ec2 Update sodertorns-hogskola-oxford.csl (#5865)
20c439b Create boletin-de-la-sociedad-geologica-mexicana.csl (#5841)
e02b500 Create jurisprudence.csl (#5856)
a860c30 Update organization-studies.csl (#5914)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 8f69d4e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koppor koppor koppor left review comments

@tobiasdiez tobiasdiez tobiasdiez approved these changes

+1 more reviewer

@LinusDietz LinusDietz LinusDietz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Siedlerchr @LinusDietz @koppor @tobiasdiez