Skip to content

Fix missing file extension for downloaded files. #5841

Merged
Siedlerchr merged 1 commit into
masterfrom
fixDownloadExt
Jan 18, 2020
Merged

Fix missing file extension for downloaded files. #5841
Siedlerchr merged 1 commit into
masterfrom
fixDownloadExt

Conversation

@tobiasdiez

Copy link
Copy Markdown
Member

Fixes #5816 by falling back to PDF as default file type.

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for bigger UI changes)
  • Checked documentation: Is the information available and up to date? If not: Issue created at https://github.com/JabRef/user-documentation/issues.

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 18, 2020
@Siedlerchr Siedlerchr merged commit 2612e22 into master Jan 18, 2020
@Siedlerchr Siedlerchr deleted the fixDownloadExt branch January 18, 2020 11:49
Siedlerchr added a commit that referenced this pull request Jan 18, 2020
# By Oliver Kopp (4) and others
# Via github actions (3) and Christoph (1)
* upstream/master:
  Fix missing file extension for downloaded files. Fixes #5816 by falling back to PDF as default file type. (#5841)
  The PDF has a title - try another publication without an available PDF (#5840)
  Fix BibTeX VM for IEEE (and some micro other fixes) (#5839)
  Squashed 'src/main/resources/csl-styles/' changes from 19c89f5..9c0f5c6
  Improve serialization to fix #4877 (#5838)
  Build on all branches
  update unirest (#5836)
  Squashed 'src/main/resources/csl-locales/' changes from a3e8843f75..41da445acc
  Squashed 'src/main/resources/csl-styles/' changes from bb01625..19c89f5
  Build binaries only when src/main changes (#5806)
  Bump archunit-junit5-api from 0.12.0 to 0.13.0 (#5827)
  Bump classgraph from 4.8.59 to 4.8.60 (#5828)
  Bump mariadb-java-client from 2.5.2 to 2.5.3 (#5829)
  Update jdk to build 30
  Improve change detection (#5824)

# Conflicts:
#	src/main/resources/l10n/JabRef_en.properties
koppor pushed a commit that referenced this pull request Mar 1, 2022
8f69d4e Container-title text-case set to title (#5931)
7200616 Create arrbhousestyle.csl (#5674)
8933609 Create hospital-a-domicilio.csl (#5924)
622bf63 Create international-journal-of-cosmetic-science.csl (#5886)
07e179f remove default-locale journal-de-la-societe-des-oceanistes.csl (#5887)
4435d1e update norsk-henvisningsstandard-for-rettsvitenskapelige-tekster.csl (#5892)
18e547f Added fixes for steel-research-international.csl (#5921)
79e53a2 Update springer-basic-brackets-no-et-al.csl (#5925)
e4f411f Update antiquites-africaines.csl (#5923)
f4b3830 Create hemijska-industrija.csl (#5881)
1b33712 Create dhd.csl (#5920)
8462846 Update China national standard GB/T 7714 styles (#5860)
2c298be ISO formatted dates in sodertorns hogskola citation styles (#5882)
1114ec2 Update sodertorns-hogskola-oxford.csl (#5865)
20c439b Create boletin-de-la-sociedad-geologica-mexicana.csl (#5841)
e02b500 Create jurisprudence.csl (#5856)
a860c30 Update organization-studies.csl (#5914)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 8f69d4e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing file extension for downloaed file

2 participants