Fix that "Rename and move file" throws file not found exception#4317
Merged
Conversation
Fixes #4307. Moreover, I refactored a bit how files are renamed/moved to the default file directory. This should make it easier to reuse the code.
Siedlerchr
reviewed
Sep 4, 2018
| this.filePreferences = Objects.requireNonNull(filePreferences); | ||
| } | ||
|
|
||
| public boolean moveToDefaultDirectory() throws IOException { |
Member
There was a problem hiding this comment.
I don't understand why you duplicate the code of the moveFilesCleanup, is not necessary, as the moveFiles cleanup can also work with a single linked file
Member
There was a problem hiding this comment.
Ah I see you refactored this out of the cleanup, But you now have a architecture violation from logic to gui
Member
Author
|
I'll merge this now so that progress on #4306 is not blocked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4307. Moreover, I refactored a bit how files are renamed/moved to the default file directory. This should make it easier to reuse the code.