Skip to content

Convert update worker to BackgroundTask#4334

Merged
tobiasdiez merged 1 commit into
masterfrom
convertUpdateWorkerNew
Sep 11, 2018
Merged

Convert update worker to BackgroundTask#4334
tobiasdiez merged 1 commit into
masterfrom
convertUpdateWorkerNew

Conversation

@tobiasdiez

Copy link
Copy Markdown
Member

No description provided.

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 11, 2018
* Prints up-to-date to the status bar (and shows a dialog it was executed manually) if there is now new version.
* Shows a "New Version" Dialog to the user if there is.
*/
private void showUpdateInfo(Optional<Version> newerVersion, boolean manualExecution) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This optional parameter is coming from the Background Task?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@tobiasdiez tobiasdiez merged commit 0e1acfe into master Sep 11, 2018
@tobiasdiez tobiasdiez deleted the convertUpdateWorkerNew branch September 11, 2018 22:14
Siedlerchr added a commit that referenced this pull request Sep 12, 2018
* upstream/master:
  Fix that web search pane steals input (#4335)
  Fix entry editor field display (#4333)
  Convert update worker to BackgroundTask (#4334)
  Fix that "Rename and move file" throws file not found exception (#4317)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants