Skip to content

In JUnit tests, always state the expected value before the actual#2959

Merged
tobiasdiez merged 1 commit into
masterfrom
expected-before-actual
Jul 3, 2017
Merged

In JUnit tests, always state the expected value before the actual#2959
tobiasdiez merged 1 commit into
masterfrom
expected-before-actual

Conversation

@LinusDietz

Copy link
Copy Markdown
Member

This is only an internal change, no functionality was actually changed. I thought it would be good to open a PR anyways to raise awareness.

@LinusDietz LinusDietz added dev: code-quality Issues related to code or architecture decisions status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Jul 3, 2017
@Siedlerchr

Copy link
Copy Markdown
Member

Ah good one!

@Siedlerchr

Copy link
Copy Markdown
Member

LGTM, no idea why freecite fails

@tobiasdiez tobiasdiez merged commit 32a1f22 into master Jul 3, 2017
@tobiasdiez tobiasdiez deleted the expected-before-actual branch July 3, 2017 11:20
Siedlerchr added a commit that referenced this pull request Jul 3, 2017
* upstream/master:
  In JUnit tests, always state the expected value before the actual (#2959)
  Update latex2unicode from 0.2 -> 0.2.1
  Fix the function "Edit - Copy BibTeX key and link"  (#2952)
  Update gradle from 3.5 to 4.0
  Update build-scan plugin from 1.3 to 1.8
  Add a shortcut to "Quality - Look up full text documents" (#2943)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev: code-quality Issues related to code or architecture decisions status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants