Skip to content

Fix the function "Edit - Copy BibTeX key and link" #2952

Merged
tobiasdiez merged 4 commits into
JabRef:masterfrom
jhshinn:fix_CopyBibTeXKeyAndLinkAction
Jul 3, 2017
Merged

Fix the function "Edit - Copy BibTeX key and link" #2952
tobiasdiez merged 4 commits into
JabRef:masterfrom
jhshinn:fix_CopyBibTeXKeyAndLinkAction

Conversation

@jhshinn

@jhshinn jhshinn commented Jun 30, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR fixes the function "Edit - Copy BibTeX key and link" to pass a hyperlink rather than an HTML statement. A copied hyperlink is more useful than an HTML statement in practice, like when writing emails. This is related with #549.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

Siedlerchr
Siedlerchr reviewed Jun 30, 2017
View reviewed changes

@Siedlerchr Siedlerchr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the clipboard functionality for Linux, there is already avn issue, somehow named x11 clipboard

@tobiasdiez

tobiasdiez commented Jun 30, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

LGTM. I just removed the comment that contained the non-working code (we had a discussion about such code and decided to almost always remove them as JabRef was cluttered with these kind of comments).

Can you please fix the import order (see wiki on how to set-up your IDE) and then this is ready to go.

We should think about reimplementing the ClipboardManager using the JavaFX facilities. Follow-up PR in this direction is highly welcome :-).

Thanks again for you contribution!

@jhshinn

jhshinn commented Jul 3, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@Siedlerchr Thanks for the comment. I was not aware of the issue. 👍
@tobiasdiez Thanks a lot for telling me the configuration file. 👍 But, I'm not sure if I did it correctly, because the only change was an addition of a blank line (-_-;). If something has to be done again, please let me know.

@tobiasdiez

tobiasdiez commented Jul 3, 2017

Copy link
Copy Markdown
Member

Everything is fine now. Thanks!

@tobiasdiez tobiasdiez merged commit 37dc46e into JabRef:master Jul 3, 2017
@jhshinn jhshinn deleted the fix_CopyBibTeXKeyAndLinkAction branch July 3, 2017 12:49
Siedlerchr added a commit that referenced this pull request Jul 3, 2017
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into sharelatex
13e544f 
* upstream/master:
  In JUnit tests, always state the expected value before the actual (#2959)
  Update latex2unicode from 0.2 -> 0.2.1
  Fix the function "Edit - Copy BibTeX key and link"  (#2952)
  Update gradle from 3.5 to 4.0
  Update build-scan plugin from 1.3 to 1.8
  Add a shortcut to "Quality - Look up full text documents" (#2943)
@tobiasdiez tobiasdiez mentioned this pull request Jul 9, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jhshinn @tobiasdiez @Siedlerchr