Add a shortcut to "Quality - Look up full text documents"#2943
Conversation
Siedlerchr
left a comment
There was a problem hiding this comment.
Just add the missing plus sign and we can merge.
Thanks again for your contribution!
| CUT("Cut", Localization.lang("Cut"), "ctrl+X", KeyBindingCategory.EDIT), | ||
| DECREASE_TABLE_FONT_SIZE("Decrease table font size", Localization.lang("Decrease table font size"), "ctrl+MINUS", KeyBindingCategory.VIEW), | ||
| DELETE_ENTRY("Delete entry", Localization.lang("Delete entry"), "DELETE", KeyBindingCategory.BIBTEX), | ||
| DOWNLOAD_FULL_TEXT("Look up full text documents", Localization.lang("Look up full text documents"), "alt F7", KeyBindingCategory.QUALITY), |
There was a problem hiding this comment.
As a result of fixing the keybindind stuff, there now needs to be a plus sign between the modifiers and the key, otherwise it may not be recognized correctly.
Otherwise the code looks good, thanks for your contribution
There was a problem hiding this comment.
@Siedlerchr Thanks for the correction~ I've added the sign.
e68f280 to
aa4cc10
Compare
| atLeastOneEntryActions.clear(); | ||
| atLeastOneEntryActions.addAll(Arrays.asList(downloadFullText, lookupIdentifiers)); | ||
| atLeastOneEntryActions.addAll(Arrays.asList(downloadFullText)); | ||
| atLeastOneEntryActions.clear(); |
There was a problem hiding this comment.
I don't understand these changes: you first add the download action but then clear the list right after.
There was a problem hiding this comment.
@tobiasdiez sorry for the confusion and thanks for the note. I misunderstood something while doing try and error. I've reverted the changes.
|
I've no idea why the build fails, but since these changes should not be the reason for the failing test I'll merge it now. |
* upstream/master: In JUnit tests, always state the expected value before the actual (#2959) Update latex2unicode from 0.2 -> 0.2.1 Fix the function "Edit - Copy BibTeX key and link" (#2952) Update gradle from 3.5 to 4.0 Update build-scan plugin from 1.3 to 1.8 Add a shortcut to "Quality - Look up full text documents" (#2943)
This PR adds a shortcut key Alt + F7 to the function "Quality"-"Look up full text documents". I've found that a issue was already raised in #1323 after finishing the code revision (hence, I happened to use the modifier Alt rather than Ctrl :-) )
gradle localizationUpdate?