Skip to content

Fix opening of preference dialog with Java 9#2329

Merged
tobiasdiez merged 3 commits into
masterfrom
fixJava9Prefs
Dec 1, 2016
Merged

Fix opening of preference dialog with Java 9#2329
tobiasdiez merged 3 commits into
masterfrom
fixJava9Prefs

Conversation

@tobiasdiez

Copy link
Copy Markdown
Member

Fixes the issue mentioned in http://discourse.jabref.org/t/cannot-start-jabref-3-7-3-6-on-ubuntu-16-04/361/4

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 1, 2016

@matthiasgeiger matthiasgeiger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small typo should be fixed

} catch (ClassNotFoundException ignored) {
// Ignored
} catch (ClassNotFoundException|IllegalAccessError ignored) {
// LookAndFeel class does not exists or we don't have rights to access it

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exist

@koppor koppor removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 1, 2016
@koppor

koppor commented Dec 1, 2016

Copy link
Copy Markdown
Member

Plz merge after the fix

@stefan-kolb stefan-kolb added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 1, 2016
@tobiasdiez tobiasdiez merged commit 40384b3 into master Dec 1, 2016
@tobiasdiez tobiasdiez deleted the fixJava9Prefs branch December 1, 2016 16:56
Siedlerchr added a commit that referenced this pull request Dec 2, 2016
* upstream/master:
  Ignore failing test
  Replace usage of Threads and priorities with thread pool (#2304)
  Class variable declarations and method declarations are now separated by one line
  Disable joining of wrapped lines
  Installer Code Signing #1879 (#2320)
  Add bibtex key deviation check (#2328)
  Update mockito-core (2.2.21 -> 2.2.26) and wiremock (2.3.1 -> 2.4.1)
  Fix opening of preference dialog with Java 9 (#2329)
  Add longer explanation for ID-based entry generation. (#2330)
  Add DOI integrity check (#2327)
  New strings translated (#2325)
  Fix exporting via commandline in no gui mode (#2316)
  Cleanup EMACS code (#2317)
  Update mockito-core from 2.2.15 to 2.2.21
  Fix typo in comment
  Updated JabRef_tr.properties (#2315)

# Conflicts:
#	CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants