Skip to content

Add bibtex key deviation check#2328

Merged
simonharrer merged 12 commits into
masterfrom
add-bibtexkey-deviation-check
Dec 2, 2016
Merged

Add bibtex key deviation check#2328
simonharrer merged 12 commits into
masterfrom
add-bibtexkey-deviation-check

Conversation

@simonharrer

Copy link
Copy Markdown
Contributor

Refs #2206

Adds integrity check to determine all entries which bibtex keys deviate from the set bibtex key generation pattern.

  • Change in CHANGELOG.md described
  • Manually tested changed features in running JabRef
  • If you changed the localization: Did you run gradle localizationUpdate?

@simonharrer simonharrer added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 1, 2016
import net.sf.jabref.model.database.BibDatabaseContext;
import net.sf.jabref.model.entry.BibEntry;

public class BibtexkeyDeviationChecker implements Checker {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe rename to BibtexKeyDeviationChecker?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another class which is called BibtexkeyChecker, so I used the naming convention from this other Checker class.

@simonharrer simonharrer merged commit 326ef9f into master Dec 2, 2016
@stefan-kolb stefan-kolb deleted the add-bibtexkey-deviation-check branch December 2, 2016 12:37
Siedlerchr added a commit that referenced this pull request Dec 2, 2016
* upstream/master:
  Ignore failing test
  Replace usage of Threads and priorities with thread pool (#2304)
  Class variable declarations and method declarations are now separated by one line
  Disable joining of wrapped lines
  Installer Code Signing #1879 (#2320)
  Add bibtex key deviation check (#2328)
  Update mockito-core (2.2.21 -> 2.2.26) and wiremock (2.3.1 -> 2.4.1)
  Fix opening of preference dialog with Java 9 (#2329)
  Add longer explanation for ID-based entry generation. (#2330)
  Add DOI integrity check (#2327)
  New strings translated (#2325)
  Fix exporting via commandline in no gui mode (#2316)
  Cleanup EMACS code (#2317)
  Update mockito-core from 2.2.15 to 2.2.21
  Fix typo in comment
  Updated JabRef_tr.properties (#2315)

# Conflicts:
#	CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants