Add DOI integrity check#2327
Merged
Merged
Conversation
Member
|
I have some valid DOIs, which look a bit weird, maybe you could add a test for them:
|
Member
|
I don't think the additional tests proposed by @Siedlerchr are necessary here. They are more tests of the DOI implementation and not tests of the integrity checker. (the second DOI is even already a testcase in https://github.com/JabRef/jabref/blob/master/src/test/java/net/sf/jabref/logic/util/DOITest.java). Apart from that: LGTM |
stefan-kolb
suggested changes
Dec 1, 2016
stefan-kolb
left a comment
Member
There was a problem hiding this comment.
Sorry but please focus on your diss! (l)
Siedlerchr
added a commit
that referenced
this pull request
Dec 2, 2016
* upstream/master: Ignore failing test Replace usage of Threads and priorities with thread pool (#2304) Class variable declarations and method declarations are now separated by one line Disable joining of wrapped lines Installer Code Signing #1879 (#2320) Add bibtex key deviation check (#2328) Update mockito-core (2.2.21 -> 2.2.26) and wiremock (2.3.1 -> 2.4.1) Fix opening of preference dialog with Java 9 (#2329) Add longer explanation for ID-based entry generation. (#2330) Add DOI integrity check (#2327) New strings translated (#2325) Fix exporting via commandline in no gui mode (#2316) Cleanup EMACS code (#2317) Update mockito-core from 2.2.15 to 2.2.21 Fix typo in comment Updated JabRef_tr.properties (#2315) # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1445
Adds an integrity check to determine whether we can handle the content in the DOI field of a bib entry.
gradle localizationUpdate?