Skip to content

New Crowdin updates#15787

Merged
Siedlerchr merged 25 commits into
mainfrom
l10n_main
May 20, 2026
Merged

New Crowdin updates#15787
Siedlerchr merged 25 commits into
mainfrom
l10n_main

Conversation

@Siedlerchr

Copy link
Copy Markdown
Member

No description provided.

Siedlerchr added 25 commits May 20, 2026 10:12
@koppor koppor enabled auto-merge May 20, 2026 08:13
@qodo-free-for-open-source-projects

Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Crowdin translation updates for multiple languages

📝 Documentation

Grey Divider

Walkthroughs

Description
• Update translations for 25 languages via Crowdin
• Modify citation key message to include parameter %0
• Add new command-line help messages for subcommands
• Remove outdated citation key translation in several languages
Diagram
flowchart LR
  A["Translation Files"] -->|Update strings| B["25 Language Files"]
  B -->|Modify citation key| C["Add %0 parameter"]
  B -->|Add new messages| D["CLI subcommand help"]
  B -->|Remove obsolete| E["Old translations"]
Loading

Grey Divider

File Changes

1. jablib/src/main/resources/l10n/JabRef_fr.properties 📝 Documentation +6/-1

French translations with new CLI messages

jablib/src/main/resources/l10n/JabRef_fr.properties


2. jablib/src/main/resources/l10n/JabRef_it.properties 📝 Documentation +7/-1

Italian translations with experimental search

jablib/src/main/resources/l10n/JabRef_it.properties


3. jablib/src/main/resources/l10n/JabRef_de.properties 📝 Documentation +1/-1

German translations with citation key update

jablib/src/main/resources/l10n/JabRef_de.properties


View more (22)
4. jablib/src/main/resources/l10n/JabRef_es.properties 📝 Documentation +1/-1

Spanish translations with citation key removal

jablib/src/main/resources/l10n/JabRef_es.properties


5. jablib/src/main/resources/l10n/JabRef_pt_BR.properties 📝 Documentation +1/-1

Brazilian Portuguese citation key translation

jablib/src/main/resources/l10n/JabRef_pt_BR.properties


6. jablib/src/main/resources/l10n/JabRef_ru.properties 📝 Documentation +1/-1

Russian translations with citation key update

jablib/src/main/resources/l10n/JabRef_ru.properties


7. jablib/src/main/resources/l10n/JabRef_ja.properties 📝 Documentation +1/-1

Japanese translations with citation key removal

jablib/src/main/resources/l10n/JabRef_ja.properties


8. jablib/src/main/resources/l10n/JabRef_ko.properties 📝 Documentation +1/-1

Korean translations with citation key removal

jablib/src/main/resources/l10n/JabRef_ko.properties


9. jablib/src/main/resources/l10n/JabRef_nl.properties 📝 Documentation +1/-1

Dutch translations with citation key removal

jablib/src/main/resources/l10n/JabRef_nl.properties


10. jablib/src/main/resources/l10n/JabRef_tr.properties 📝 Documentation +1/-1

Turkish translations with citation key removal

jablib/src/main/resources/l10n/JabRef_tr.properties


11. jablib/src/main/resources/l10n/JabRef_zh_CN.properties 📝 Documentation +1/-1

Simplified Chinese citation key translation

jablib/src/main/resources/l10n/JabRef_zh_CN.properties


12. jablib/src/main/resources/l10n/JabRef_ar.properties 📝 Documentation +1/-0

Arabic translations whitespace formatting

jablib/src/main/resources/l10n/JabRef_ar.properties


13. jablib/src/main/resources/l10n/JabRef_da.properties 📝 Documentation +1/-0

Danish translations whitespace formatting

jablib/src/main/resources/l10n/JabRef_da.properties


14. jablib/src/main/resources/l10n/JabRef_el.properties 📝 Documentation +1/-0

Greek translations whitespace formatting

jablib/src/main/resources/l10n/JabRef_el.properties


15. jablib/src/main/resources/l10n/JabRef_fa.properties 📝 Documentation +1/-0

Persian translations whitespace formatting

jablib/src/main/resources/l10n/JabRef_fa.properties


16. jablib/src/main/resources/l10n/JabRef_fi.properties 📝 Documentation +1/-0

Finnish translations whitespace formatting

jablib/src/main/resources/l10n/JabRef_fi.properties


17. jablib/src/main/resources/l10n/JabRef_id.properties 📝 Documentation +1/-0

Indonesian translations whitespace formatting

jablib/src/main/resources/l10n/JabRef_id.properties


18. jablib/src/main/resources/l10n/JabRef_no.properties 📝 Documentation +1/-0

Norwegian translations whitespace formatting

jablib/src/main/resources/l10n/JabRef_no.properties


19. jablib/src/main/resources/l10n/JabRef_pl.properties 📝 Documentation +1/-0

Polish translations whitespace formatting

jablib/src/main/resources/l10n/JabRef_pl.properties


20. jablib/src/main/resources/l10n/JabRef_pt.properties 📝 Documentation +1/-0

Portuguese translations whitespace formatting

jablib/src/main/resources/l10n/JabRef_pt.properties


21. jablib/src/main/resources/l10n/JabRef_sv.properties Additional files +1/-0

...

jablib/src/main/resources/l10n/JabRef_sv.properties


22. jablib/src/main/resources/l10n/JabRef_tl.properties Additional files +1/-0

...

jablib/src/main/resources/l10n/JabRef_tl.properties


23. jablib/src/main/resources/l10n/JabRef_uk.properties Additional files +1/-0

...

jablib/src/main/resources/l10n/JabRef_uk.properties


24. jablib/src/main/resources/l10n/JabRef_vi.properties Additional files +1/-0

...

jablib/src/main/resources/l10n/JabRef_vi.properties


25. jablib/src/main/resources/l10n/JabRef_zh_TW.properties Additional files +1/-0

...

jablib/src/main/resources/l10n/JabRef_zh_TW.properties


Grey Divider

Qodo Logo

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (2)

Grey Divider


Remediation recommended

1. Citation key translation removed 📘 Rule violation ⚙ Maintainability
Description
Multiple locale bundles removed the Citation key deviates from generated key entry but did not add
the new replacement-parameter variant Citation key deviates from generated key %0 used by
CitationKeyDeviationChecker (and present in JabRef_en.properties). As a result, affected locales
will fall back to the English key/text (or show missing text), reducing localization completeness.
Code

jablib/src/main/resources/l10n/JabRef_de.properties[1890]

-Citation\ key\ deviates\ from\ generated\ key=Zitationsschlüssel weicht vom generierten Schlüssel ab
Evidence
CitationKeyDeviationChecker looks up the parameterized localization key `Citation key deviates
from generated key %0 (with the %0` placeholder), so each locale must define that exact key. The
English bundle defines Citation\ key\ deviates\ from\ generated\ key\ %0=..., and some locales
(e.g., French/Italian) include it, but the affected locales in this PR (e.g.,
German/Spanish/Japanese and others) no longer contain any Citation key deviates... entry in the
relevant section because the old non-parameterized key was deleted without adding the %0 key,
causing lookup failure and UI fallback to the raw English key/string.

AGENTS.md
jablib/src/main/resources/l10n/JabRef_en.properties[1953-1958]
jablib/src/main/resources/l10n/JabRef_fr.properties[1956-1958]
jablib/src/main/resources/l10n/JabRef_de.properties[1886-1892]
jablib/src/main/resources/l10n/JabRef_es.properties[1877-1883]
jablib/src/main/java/org/jabref/logic/integrity/CitationKeyDeviationChecker.java[36-42]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Several translated `JabRef_<lang>.properties` files removed the old key `Citation key deviates from generated key` but do not include the new key `Citation key deviates from generated key %0` (which is what `CitationKeyDeviationChecker` requests and is present in English). This causes localized UIs to fall back to English (or fail to resolve the key) for that integrity message.

## Issue Context
- `CitationKeyDeviationChecker` calls `Localization.lang("Citation key deviates from generated key %0", generatedKey)`, so the **key** must include `... key %0`.
- `JabRef_en.properties` contains `Citation\ key\ deviates\ from\ generated\ key\ %0=...`.
- Only some locales (e.g., French/Italian) provide translations for the `%0` key; in the affected locales, the prior (non-parameterized) key was removed and there is currently no `Citation key deviates...` entry at all.
- For each affected locale, add a line like:
 `Citation\ key\ deviates\ from\ generated\ key\ %0=<localized text including %0>`
 (You can adapt the previously existing translation text and incorporate `%0` appropriately.)

## Fix Focus Areas
- jablib/src/main/resources/l10n/JabRef_en.properties[1953-1958]
- jablib/src/main/resources/l10n/JabRef_de.properties[1886-1892]
- jablib/src/main/resources/l10n/JabRef_es.properties[1877-1883]
- jablib/src/main/resources/l10n/JabRef_ja.properties[1499-1505]
- jablib/src/main/resources/l10n/JabRef_ko.properties[1411-1417]
- jablib/src/main/resources/l10n/JabRef_nl.properties[1555-1561]
- jablib/src/main/resources/l10n/JabRef_pt_BR.properties[1882-1888]
- jablib/src/main/resources/l10n/JabRef_ru.properties[1502-1508]
- jablib/src/main/resources/l10n/JabRef_tr.properties[1577-1583]
- jablib/src/main/resources/l10n/JabRef_zh_CN.properties[1946-1952]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


2. Whitespace-only l10n diffs 📘 Rule violation ⚙ Maintainability
Description
The PR introduces whitespace-only changes (blank lines) across many localization files, increasing
diff noise without changing translations. This makes reviews harder and conflicts with the
requirement to avoid formatting-only changes in unrelated areas.
Code

jablib/src/main/resources/l10n/JabRef_da.properties[1099]

+
Evidence
The modified localization files end with runs of empty lines, and the PR adds additional empty lines
(as shown by the diff hunks), constituting formatting-only changes across many files.

AGENTS.md
jablib/src/main/resources/l10n/JabRef_da.properties[1089-1098]
jablib/src/main/resources/l10n/JabRef_ar.properties[821-833]
jablib/src/main/resources/l10n/JabRef_de.properties[3326-3331]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Many `JabRef_<lang>.properties` files gain an extra blank line at the end (whitespace-only change), creating broad formatting-only diffs.

## Issue Context
These changes do not appear to modify any key/value translations and primarily add/remove empty lines.

## Fix Focus Areas
- jablib/src/main/resources/l10n/JabRef_ar.properties[831-834]
- jablib/src/main/resources/l10n/JabRef_da.properties[1096-1099]
- jablib/src/main/resources/l10n/JabRef_de.properties[3329-3332]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Qodo Logo

@Siedlerchr Siedlerchr disabled auto-merge May 20, 2026 12:57
@Siedlerchr Siedlerchr merged commit 4454d9e into main May 20, 2026
18 checks passed
@Siedlerchr Siedlerchr deleted the l10n_main branch May 20, 2026 12:57
Siedlerchr added a commit that referenced this pull request May 20, 2026
* upstream/main:
  Update PULL_REQUEST_TEMPLATE.md (#15788)
  New Crowdin updates (#15787)
  Update heylogs to 0.18.0 and use github-actions format (#15786)
  Grand refactoring of the AI features (#15688)
  Chore(deps): Bump com.fasterxml:aalto-xml in /versions (#15782)
  Chore(deps): Bump org.junit:junit-bom from 6.0.3 to 6.1.0 in /versions (#15783)
  Fix default value for unwanted characters (#15743)
  Fix runner tag
  Fix runner for JBang (PR)
  Fix duplicate finder progress counter incrementing on empty queue polls (#15781)
  Refine JabKit CLI: positional input argument and check command group (#15759)
  Ignore exception in unregisterListener to prevent exception (#15761)
  Fix wrong usage of "key" (#15779)
  Fix Hayagriva export to nest identifiers under serial-number (#15750)
f0restron07 pushed a commit to f0restron07/jabref that referenced this pull request May 24, 2026
* New translations jabref_en.properties (French)

[ci skip]

* New translations jabref_en.properties (Spanish)

[ci skip]

* New translations jabref_en.properties (Arabic)

[ci skip]

* New translations jabref_en.properties (Danish)

[ci skip]

* New translations jabref_en.properties (German)

[ci skip]

* New translations jabref_en.properties (Greek)

[ci skip]

* New translations jabref_en.properties (Finnish)

[ci skip]

* New translations jabref_en.properties (Italian)

[ci skip]

* New translations jabref_en.properties (Japanese)

[ci skip]

* New translations jabref_en.properties (Korean)

[ci skip]

* New translations jabref_en.properties (Dutch)

[ci skip]

* New translations jabref_en.properties (Norwegian)

[ci skip]

* New translations jabref_en.properties (Polish)

[ci skip]

* New translations jabref_en.properties (Portuguese)

[ci skip]

* New translations jabref_en.properties (Russian)

[ci skip]

* New translations jabref_en.properties (Swedish)

[ci skip]

* New translations jabref_en.properties (Turkish)

[ci skip]

* New translations jabref_en.properties (Ukrainian)

[ci skip]

* New translations jabref_en.properties (Chinese Simplified)

[ci skip]

* New translations jabref_en.properties (Chinese Traditional)

[ci skip]

* New translations jabref_en.properties (Vietnamese)

[ci skip]

* New translations jabref_en.properties (Portuguese, Brazilian)

[ci skip]

* New translations jabref_en.properties (Indonesian)

[ci skip]

* New translations jabref_en.properties (Persian)

[ci skip]

* New translations jabref_en.properties (Tagalog)

[ci skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants