• Fixed Hayagriva YAML exporter to nest identifiers under serial-number
• DOI, ISBN, and ISSN now correctly nested per Hayagriva spec
• Added three unit tests for each identifier type
• Updated layout template with conditional serial-number block

Nest identifiers under serial-number block

• Replaced individual top-level DOI, ISBN, ISSN fields with nested structure
• Added conditional serial-number block using || operator
• Increased indentation for nested identifier fields
• Added quotes around ISBN value for consistency

jablib/src/main/resources/resource/layout/hayagrivayaml.layout

Add tests for serial-number identifier nesting

• Added exportsDoiNestedUnderSerialNumber() test for DOI nesting
• Added exportsIsbnNestedUnderSerialNumber() test for ISBN nesting
• Added exportsIssnNestedUnderSerialNumber() test for ISSN nesting
• Each test validates correct YAML structure with serial-number block

jablib/src/test/java/org/jabref/logic/exporter/HayagrivaYamlExporterTest.java

Document Hayagriva serial-number fix

• Added entry documenting the Hayagriva YAML exporter fix
• References issue #15713 and Hayagriva format specification compliance

CHANGELOG.md

Description

exportsIssnNestedUnderSerialNumber builds an expected YAML output but never asserts it against
the exported file contents, so ISSN serialization is not actually covered and regressions could slip
through. This violates the requirement to have unit tests validating ISSN is nested under
serial-number.issn (and not emitted as a top-level field).

Code

jablib/src/test/java/org/jabref/logic/exporter/HayagrivaYamlExporterTest.java[R323-333]

+        List<String> expected = List.of(
+                "test:",
+                "  type: article",
+                "  title: \"Test Article\"",
+                "  author:",
+                "    - Author, Test",
+                "  date: 2020-10-14",
+                "  url: http://example.com",
+                "  serial-number:",
+                "    issn: \"0896-3207\"");
+    }

Evidence

PR Compliance ID 2 requires unit tests that validate ISSN is serialized as serial-number.issn and
not as a top-level field. In exportsIssnNestedUnderSerialNumber, the test method ends immediately
after defining the expected output and does not include an `assertEquals(expected,
Files.readAllLines(file))`, unlike the DOI and ISBN tests in the same class which do assert the
exported file contents; therefore the ISSN behavior is not verified.

Hayagriva export nests ISBN and ISSN under serial-number and unit tests cover each identifier type
jablib/src/test/java/org/jabref/logic/exporter/HayagrivaYamlExporterTest.java[309-333]
jablib/src/test/java/org/jabref/logic/exporter/HayagrivaYamlExporterTest.java[253-279]
jablib/src/test/java/org/jabref/logic/exporter/HayagrivaYamlExporterTest.java[281-307]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The test `exportsIssnNestedUnderSerialNumber` currently constructs an `expected` YAML output but never compares it to the actual exporter output, meaning it cannot fail and does not validate that ISSN is nested under `serial-number` rather than emitted as a top-level YAML field.
## Issue Context
PR Compliance requires unit tests for DOI/ISBN/ISSN export verifying the identifiers are nested under `serial-number` and not emitted as top-level YAML fields. In the same test class, the DOI and ISBN tests use `assertEquals(expected, Files.readAllLines(file));`, but the ISSN test ends right after creating `expected` without asserting the file contents.
## Fix Focus Areas
- jablib/src/test/java/org/jabref/logic/exporter/HayagrivaYamlExporterTest.java[309-333]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools