Fix duplicate finder progress counter incrementing on empty queue polls by raphaelterencio · Pull Request #15781 · JabRef/jabref

raphaelterencio · 2026-05-19T19:54:52Z

Related issues and pull requests

PR Description

The duplicate finder progress counter in DuplicateSearch.java was being incremented on every iteration of the polling loop, including iterations where the queue was empty and no pair was shown to the user. This fix moves the increment to the point where a duplicate pair is actually presented to the user, and corrects the title binding to use the observable property directly instead of a static captured value

Steps to test

Open a library with several duplicate entries (at least 50+ total entries so the search takes a moment)
Go to Quality -> Find Duplicates
Observe the counter in the dialog title, it should now start at (1/N) and increment sequentially as you resolve each pair
Before this fix, the counter would start at a number higher than 1 (e.g. 5/10) due to empty queue poll iterations being counted

(Screenshots: before fix showing 5/10 on first dialog, after fix showing 1/10)

AI usage

Claude Code (claude-sonnet-4-6) -> Only used to find the source of the problem and a way to correct it

Checklist

I own the copyright of the code submitted and I license it under the MIT license
If AI tools were used, I disclosed them in the "AI usage" section and reviewed, understood, and take full ownership of all AI-generated code
I manually tested my changes in running JabRef (always required)
[/] I added JUnit tests for changes (if applicable)
I added screenshots in the PR description (if change is visible to the user)
I added a screenshot in the PR description showing a library with a single entry with me as author and as title the issue number
I described the change in CHANGELOG.md in a way that can be understood by the average user (if change is visible to the user)
[/] I checked the user documentation for up to dateness and submitted a pull request to our user documentation repository

qodo-free-for-open-source-projects · 2026-05-19T19:55:06Z

Review Summary by Qodo

Fix duplicate finder progress counter incrementing logic

🐞 Bug fix

Walkthroughs

Description

• Fixed progress counter incrementing on empty queue polls
• Counter now increments only when duplicate pair shown
• Corrected title binding to use observable property
• Updated changelog with fix description

Diagram

flowchart LR
  A["Empty queue poll"] -->|Before| B["Counter incremented"]
  C["Duplicate pair found"] -->|Before| B
  A -->|After| D["Counter unchanged"]
  C -->|After| E["Counter incremented"]
  E --> F["Dialog title updated"]
  B --> G["Incorrect progress display"]
  F --> H["Correct progress display"]

File Changes

1. jabgui/src/main/java/org/jabref/gui/duplicationFinder/DuplicateSearch.java 🐞 Bug fix +3/-3

Move counter increment to pair presentation point

• Moved progress counter increment from polling loop to duplicate pair presentation
• Counter now increments only when a duplicate pair is shown to user
• Fixed title binding to use duplicateProgress observable property instead of static getValue()
 call
• Ensures counter starts at 1 and increments sequentially as pairs are resolved

jabgui/src/main/java/org/jabref/gui/duplicationFinder/DuplicateSearch.java

2. CHANGELOG.md 📝 Documentation +1/-0

Document duplicate finder counter fix

• Added entry documenting fix for duplicate finder progress counter issue
• References issue #11848
• Describes the fix in user-friendly language

CHANGELOG.md

qodo-free-for-open-source-projects · 2026-05-19T19:55:07Z

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (1) 📎 Requirement gaps (0)

Context used

✅ Tickets: 🎫 Duplicate finder counter makes no sense

1. duplicateProgress.set() off FX thread 📘 Rule violation ☼ Reliability

Description

duplicateProgress (a JavaFX property bound to the dialog title) is incremented inside
verifyDuplicates(), which is executed via a BackgroundTask and therefore may run off the JavaFX
Application Thread. Updating an FX-observed property from the worker thread can notify
bindings/listeners on the wrong thread, causing intermittent UI exceptions, crashes, or undefined
behavior.

Code

jabgui/src/main/java/org/jabref/gui/duplicationFinder/DuplicateSearch.java[154]
+                duplicateProgress.set(duplicateProgress.getValue() + 1);

Evidence
PR Compliance ID 47 requires JavaFX UI reads/writes to occur on the JavaFX Application Thread, yet
the PR adds/increments duplicateProgress.set(...) inside verifyDuplicates() while
verifyDuplicates() is run through BackgroundTask.wrap(this::verifyDuplicates) (whose call()
executes on a background thread in UiTaskExecutor). Since askResolveStrategy() binds
dialog.titleProperty() to observe duplicateProgress, any increment performed before switching to
the FX thread can trigger title updates (and other listener notifications) from the worker thread;
the surrounding codebase pattern also shows UI-related updates are normally marshaled to the FX
thread (e.g., duplicateTotal updates via runAndWaitInJavaFXThread).
jabgui/src/main/java/org/jabref/gui/duplicationFinder/DuplicateSearch.java[98-101]
jabgui/src/main/java/org/jabref/gui/duplicationFinder/DuplicateSearch.java[151-156]
jabgui/src/main/java/org/jabref/gui/duplicationFinder/DuplicateSearch.java[95-101]
jabgui/src/main/java/org/jabref/gui/duplicationFinder/DuplicateSearch.java[122-156]
jabgui/src/main/java/org/jabref/gui/duplicationFinder/DuplicateSearch.java[162-166]
jabgui/src/main/java/org/jabref/gui/util/UiTaskExecutor.java[108-110]
jabgui/src/main/java/org/jabref/gui/util/UiTaskExecutor.java[186-190]
Best Practice: Learned patterns

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`duplicateProgress` is a JavaFX `SimpleIntegerProperty` that is bound into the dialog title, but it is currently incremented inside `verifyDuplicates()` while that method runs via `BackgroundTask` on a worker thread. Because bindings/listeners may be notified on the worker thread, this can drive JavaFX UI updates off the FX Application Thread, leading to unstable UI behavior or runtime exceptions.

## Issue Context
- `verifyDuplicates()` is executed via `BackgroundTask.wrap(this::verifyDuplicates)`, and in JabRef’s `UiTaskExecutor` the task `call()` runs on a background thread.
- `askResolveStrategy()` binds `dialog.titleProperty()` to `duplicateProgress`, making `duplicateProgress` a UI-observed property.
- The codebase already marshals UI-related changes to the JavaFX thread (e.g., `duplicateTotal` is updated via `runAndWaitInJavaFXThread`).

## Fix Focus Areas
- jabgui/src/main/java/org/jabref/gui/duplicationFinder/DuplicateSearch.java[98-101]
- jabgui/src/main/java/org/jabref/gui/duplicationFinder/DuplicateSearch.java[122-166]
- jabgui/src/main/java/org/jabref/gui/duplicationFinder/DuplicateSearch.java[151-156]

## Suggested approach
Move the `duplicateProgress` increment so it always executes on the JavaFX Application Thread (e.g., into the existing `UiTaskExecutor.runAndWaitInJavaFXThread(...)` block around `askResolveStrategy()` or by wrapping just the increment in `UiTaskExecutor.runInJavaFXThread(...)`), and remove the worker-thread `duplicateProgress.set(...)` call.

Optionally, ensure the dialog title binding is unbound after the dialog is closed to avoid keeping bindings/listeners alive longer than needed.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

raphaelterencio · 2026-05-19T19:56:50Z

Sorry for the confusion and the noise on this PR, I know that the auto-merge was already enabled,but I had some problems. During the process of addressing review feedback, I accidentally performed a force push which invalidated the previous approval and caused CI failures related to that. While trying to fix the resulting issues, the CHANGELOG entry ended up duplicated multiple times due to repeated rebasing, and the CI kept failing. To avoid further complications on an already messy history, I decided to close this PR and open a clean one from scratch with a single commit on top of upstream/main. The fix itself is unchanged, same two line logic correction

qodo-free-for-open-source-projects · 2026-05-19T20:02:19Z

                DuplicateResolverType resolverType = askAboutExact ? DuplicateResolverType.DUPLICATE_SEARCH_WITH_EXACT : DuplicateResolverType.DUPLICATE_SEARCH;

+                // Increment only when a pair is actually shown to the user
+                duplicateProgress.set(duplicateProgress.getValue() + 1);


1. duplicateprogress.set() off fx thread 📘 Rule violation ☼ Reliability

duplicateProgress (a JavaFX property bound to the dialog title) is incremented inside verifyDuplicates(), which is executed via a BackgroundTask and therefore may run off the JavaFX Application Thread. Updating an FX-observed property from the worker thread can notify bindings/listeners on the wrong thread, causing intermittent UI exceptions, crashes, or undefined behavior.

Agent Prompt

## Issue description `duplicateProgress` is a JavaFX `SimpleIntegerProperty` that is bound into the dialog title, but it is currently incremented inside `verifyDuplicates()` while that method runs via `BackgroundTask` on a worker thread. Because bindings/listeners may be notified on the worker thread, this can drive JavaFX UI updates off the FX Application Thread, leading to unstable UI behavior or runtime exceptions. ## Issue Context - `verifyDuplicates()` is executed via `BackgroundTask.wrap(this::verifyDuplicates)`, and in JabRef’s `UiTaskExecutor` the task `call()` runs on a background thread. - `askResolveStrategy()` binds `dialog.titleProperty()` to `duplicateProgress`, making `duplicateProgress` a UI-observed property. - The codebase already marshals UI-related changes to the JavaFX thread (e.g., `duplicateTotal` is updated via `runAndWaitInJavaFXThread`). ## Fix Focus Areas - jabgui/src/main/java/org/jabref/gui/duplicationFinder/DuplicateSearch.java[98-101] - jabgui/src/main/java/org/jabref/gui/duplicationFinder/DuplicateSearch.java[122-166] - jabgui/src/main/java/org/jabref/gui/duplicationFinder/DuplicateSearch.java[151-156] ## Suggested approach Move the `duplicateProgress` increment so it always executes on the JavaFX Application Thread (e.g., into the existing `UiTaskExecutor.runAndWaitInJavaFXThread(...)` block around `askResolveStrategy()` or by wrapping just the increment in `UiTaskExecutor.runInJavaFXThread(...)`), and remove the worker-thread `duplicateProgress.set(...)` call. Optionally, ensure the dialog title binding is unbound after the dialog is closed to avoid keeping bindings/listeners alive longer than needed.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

* upstream/main: Update PULL_REQUEST_TEMPLATE.md (#15788) New Crowdin updates (#15787) Update heylogs to 0.18.0 and use github-actions format (#15786) Grand refactoring of the AI features (#15688) Chore(deps): Bump com.fasterxml:aalto-xml in /versions (#15782) Chore(deps): Bump org.junit:junit-bom from 6.0.3 to 6.1.0 in /versions (#15783) Fix default value for unwanted characters (#15743) Fix runner tag Fix runner for JBang (PR) Fix duplicate finder progress counter incrementing on empty queue polls (#15781) Refine JabKit CLI: positional input argument and check command group (#15759) Ignore exception in unregisterListener to prevent exception (#15761) Fix wrong usage of "key" (#15779) Fix Hayagriva export to nest identifiers under serial-number (#15750)

…ls (JabRef#15781)

Fix duplicate finder progress counter incrementing on empty queue polls

3b89299

qodo-free-for-open-source-projects Bot added the Compliance violation label May 19, 2026

qodo-free-for-open-source-projects Bot reviewed May 19, 2026

View reviewed changes

github-actions Bot mentioned this pull request May 19, 2026

Duplicate finder counter makes no sense #11848

Closed

2 tasks

github-actions Bot added the status: no-bot-comments label May 19, 2026

Siedlerchr approved these changes May 19, 2026

View reviewed changes

Siedlerchr enabled auto-merge May 19, 2026 21:24

koppor added the status: to-be-merged PRs which are accepted and should go into the merge-queue. label May 19, 2026

Siedlerchr added this pull request to the merge queue May 19, 2026

Merged via the queue into JabRef:main with commit 5f25cbb May 19, 2026
115 of 124 checks passed

f0restron07 pushed a commit to f0restron07/jabref that referenced this pull request May 24, 2026

Fix duplicate finder progress counter incrementing on empty queue pol…

57fa09e

…ls (JabRef#15781)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix duplicate finder progress counter incrementing on empty queue polls#15781

Fix duplicate finder progress counter incrementing on empty queue polls#15781
Siedlerchr merged 1 commit into
JabRef:mainfrom
raphaelterencio:fix/duplicate-finder-counter-11848-v3

raphaelterencio commented May 19, 2026

Uh oh!

qodo-free-for-open-source-projects Bot commented May 19, 2026

Uh oh!

qodo-free-for-open-source-projects Bot commented May 19, 2026 •

edited

Loading

Uh oh!

raphaelterencio commented May 19, 2026 •

edited

Loading

Uh oh!

qodo-free-for-open-source-projects Bot May 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

raphaelterencio commented May 19, 2026

Related issues and pull requests

PR Description

Steps to test

AI usage

Checklist

Uh oh!

qodo-free-for-open-source-projects Bot commented May 19, 2026

Review Summary by Qodo

Walkthroughs

File Changes

Uh oh!

qodo-free-for-open-source-projects Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review by Qodo

Uh oh!

raphaelterencio commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qodo-free-for-open-source-projects Bot May 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

qodo-free-for-open-source-projects Bot commented May 19, 2026 •

edited

Loading

raphaelterencio commented May 19, 2026 •

edited

Loading